Commit d1ce2d33 authored by Demetrios Papadopoulos's avatar Demetrios Papadopoulos Committed by Commit Bot

Restore OmniboxViewTest.EditSearchEngines test.

This test, previously named
OmniboxViewTestWithoutSplitSettings.EditSearchEngines, was deleted at r727291.
The test seems relevant regardless  of whether the OS/Browser settings are split
though. Restoring it since it still seems useful, without the now obsolete
"WithoutSplitSettings" suffix.

Fixed: 994927
Change-Id: I87bbbdc312a1a22b21fd2391c8c8f112302a5ad6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993941Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729916}
parent 425e7ab7
......@@ -1619,6 +1619,17 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, Paste) {
// TODO(msw): Test that AltGr+V does not paste.
}
IN_PROC_BROWSER_TEST_F(OmniboxViewTest, EditSearchEngines) {
OmniboxView* omnibox_view = nullptr;
ASSERT_NO_FATAL_FAILURE(GetOmniboxView(&omnibox_view));
EXPECT_TRUE(chrome::ExecuteCommand(browser(), IDC_EDIT_SEARCH_ENGINES));
ASSERT_NO_FATAL_FAILURE(WaitForAutocompleteControllerDone());
const std::string target_url =
std::string(chrome::kChromeUISettingsURL) + chrome::kSearchEnginesSubPage;
EXPECT_EQ(ASCIIToUTF16(target_url), omnibox_view->GetText());
EXPECT_FALSE(omnibox_view->model()->popup_model()->IsOpen());
}
// Flaky test. The below suggestions are in a random order, and the injected
// keys may or may not have registered. Probably https://crbug.com/751031,
// but I believe the whole input mechanism needs to be re-architected.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment