Commit d1f7214f authored by Nico Weber's avatar Nico Weber Committed by Commit Bot

Reenable test now that https://github.com/google/sanitizers/issues/295 is fixed.

Bug: none
Change-Id: Ib11ae467efea7ce3a44375850ddbf78524914aef
Reviewed-on: https://chromium-review.googlesource.com/996853Reviewed-by: default avatarHans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548405}
parent fef0bad0
......@@ -17,20 +17,9 @@ namespace {
class ImageDataTest : public testing::Test {};
// Under asan_clang_phone, the test crashes after the memory allocation
// is not successful. It is probably related to the value of
// allocator_may_return_null on trybots, which in this case causes ASAN
// to terminate the process instead of returning null.
// crbug.com/704948
#if defined(ADDRESS_SANITIZER)
#define MAYBE_CreateImageDataTooBig DISABLED_CreateImageDataTooBig
#else
#define MAYBE_CreateImageDataTooBig CreateImageDataTooBig
#endif
// This test passes if it does not crash. If the required memory is not
// allocated to the ImageData, then an exception must raise.
TEST_F(ImageDataTest, MAYBE_CreateImageDataTooBig) {
TEST_F(ImageDataTest, CreateImageDataTooBig) {
DummyExceptionStateForTesting exception_state;
ImageData* too_big_image_data =
ImageData::Create(32767, 32767, exception_state);
......@@ -529,6 +518,5 @@ TEST_F(ImageDataTest, ImageDataTooBigToAllocateDoesNotCrash) {
EXPECT_EQ(image_data, nullptr);
}
#undef MAYBE_CreateImageDataTooBig
} // namespace
} // namespace blink
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment