a11y: Refer to subpage arrows as subpage buttons

For browser settings add the "Subpage button" role description to
<cr-link-row>'s to clarify the button's action to the user.

Fixed: 1012105
Change-Id: Ic5836c656adf119ea3da0ae3d1319ee7e2cafe8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485036Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818560}

chrome/app/extensions_strings.grdp

@@ -406,6 +406,9 @@
   <message name="IDS_EXTENSIONS_TYPE_A_SHORTCUT" desc="The prompt to the user to enter a keyboard shortcut in order to assign it to an extension.">
     Type a shortcut
   </message>
+  <message name="IDS_EXTENSIONS_SUBPAGE_BUTTON" is_accessibility_with_no_ui="true" desc="Accessibility description for a button navigating the user from an extension's settings page to its settings subpage.">
+    Subpage button
+  </message>
 <if expr="is_macosx">
   <message name="IDS_EXTENSIONS_INCLUDE_START_MODIFIER" desc="Error message explaining that shortcuts must start with either the Control, Alt, or Command key.">
     Include Ctrl, Alt, or ⌘

chrome/browser/resources/extensions/detail_view.html

@@ -377,7 +377,8 @@
         external></cr-link-row>
     <cr-link-row class="hr"
         id="extensionsActivityLogLink" hidden$="[[!showActivityLog]]"
-        label="$i18n{viewActivityLog}" on-click="onActivityLogTap_">
+        label="$i18n{viewActivityLog}" on-click="onActivityLogTap_"
+        role-description="$i18n{subpageArrowRoleDescription}">
     </cr-link-row>
     <cr-link-row class="hr" hidden="[[!data.manifestHomePageUrl.length]]"
         id="extensionWebsite" label="$i18n{extensionWebsite}"

chrome/browser/resources/settings/people_page/sync_page.html

@@ -161,6 +161,7 @@
         <div id="other-sync-items" class="list-frame">
           <cr-link-row id="sync-advanced-row"
               label="$i18n{syncAdvancedPageTitle}"
+              role-description="$i18n{subpageArrowRoleDescription}"
               on-click="onSyncAdvancedClick_"></cr-link-row>
 
           <cr-link-row class="hr"

chrome/browser/resources/settings/privacy_page/cookies_page.html

@@ -138,7 +138,8 @@
         on-settings-boolean-control-change="onNetworkPredictionChange_">
     </settings-toggle-button>
     <cr-link-row id="site-data-trigger" class="hr"
-        on-click="onSiteDataClick_" label="$i18n{siteSettingsCookieLink}">
+        on-click="onSiteDataClick_" label="$i18n{siteSettingsCookieLink}"
+        role-description="$i18n{subpageArrowRoleDescription}">
     </cr-link-row>
     <div  id="exceptionHeader" hidden="[[!enableContentSettingsRedesign_]]">
       <h2>$i18n{siteSettingsCustomizedBehaviors}</h2>

chrome/browser/resources/settings/privacy_page/privacy_page.html

@@ -19,15 +19,18 @@
         <cr-link-row id="cookiesLinkRow" start-icon="settings:cookie"
             class="hr" label="$i18n{cookiePageTitle}"
             sub-label="[[cookieSettingDescription_]]"
-            on-click="onCookiesClick_"></cr-link-row>
+            on-click="onCookiesClick_"
+            role-description="$i18n{subpageArrowRoleDescription}"></cr-link-row>
         <cr-link-row id="securityLinkRow" start-icon="cr:security"
             class="hr" label="$i18n{securityPageTitle}"
             sub-label="$i18n{securityPageDescription}"
-            on-click="onSecurityPageClick_"></cr-link-row>
+            on-click="onSecurityPageClick_"
+            role-description="$i18n{subpageArrowRoleDescription}"></cr-link-row>
         <cr-link-row id="permissionsLinkRow" start-icon="settings:permissions"
             class="hr" label="$i18n{siteSettings}"
             sub-label="$i18n{permissionsPageDescription}"
-            on-click="onPermissionsPageClick_"></cr-link-row>
+            on-click="onPermissionsPageClick_"
+            role-description="$i18n{subpageArrowRoleDescription}"></cr-link-row>
       </div>
 
 <if expr="use_nss_certs">

chrome/browser/resources/settings/privacy_page/security_page.html

@@ -160,13 +160,17 @@
           class="hr"
           label="$i18n{securityKeysTitle}"
           sub-label="$i18n{securityKeysDesc}"
-          on-click="onSecurityKeysClick_"></cr-link-row>
+          on-click="onSecurityKeysClick_"
+          role-description="$i18n{subpageArrowRoleDescription}"></cr-link-row>
     </template>
 <if expr="use_nss_certs or is_win or is_macosx">
     <cr-link-row id="manageCertificates"
         class="hr"
 <if expr="not use_nss_certs">
         external
+</if>
+<if expr="use_nss_certs">
+        role-description="$i18n{subpageArrowRoleDescription}"
 </if>
         label="$i18n{manageCertificates}"
         sub-label="$i18n{manageCertificatesDescription}"

chrome/browser/ui/webui/extensions/extensions_ui.cc

@@ -236,6 +236,7 @@ content::WebUIDataSource* CreateMdExtensionsSource(Profile* profile,
     {"shortcutIncludeStartModifier", IDS_EXTENSIONS_INCLUDE_START_MODIFIER},
     {"shortcutTooManyModifiers", IDS_EXTENSIONS_TOO_MANY_MODIFIERS},
     {"shortcutNeedCharacter", IDS_EXTENSIONS_NEED_CHARACTER},
+    {"subpageArrowRoleDescription", IDS_EXTENSIONS_SUBPAGE_BUTTON},
     {"toolbarDevMode", IDS_EXTENSIONS_DEVELOPER_MODE},
     {"toolbarLoadUnpacked", IDS_EXTENSIONS_TOOLBAR_LOAD_UNPACKED},
     {"toolbarPack", IDS_EXTENSIONS_TOOLBAR_PACK},