Skip to content

GitLab

T
tangled
Commit d3695968 authored by Nico Weber's avatar Nico Weber
Browse files
Options

Remove many chromium.memory exceptions. 

If we run tests on the main waterfall, we generally should run them
on the memory waterfall as well.

I filed bugs and added comments to those for the few tests that
actually don't pass on the memory waterfall. Most do pass.

Bug: 814403,831667,831674,831676,830653
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0ea3cf12745f089d7fb87da8fc20e2665d86d53f
Reviewed-on: https://chromium-review.googlesource.com/987916
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550005}
parent d3737943
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 358 additions and 117 deletions
testing/buildbot/chromium.memory.json
View file @ d3695968
This diff is collapsed.
testing/buildbot/test_suite_exceptions.pyl
View file @ d3695968
......@@ -70,19 +70,10 @@
# chromium.fyi
'Out of Process Profiling Windows',
'Win 10 Fast Ring',
# chromium.memory
'Linux ASan LSan Tests (1)',
'Linux Chromium OS ASan LSan Tests (1)',
'Linux ChromiumOS MSan Tests',
'Linux MSan Tests',
'Linux TSan Tests',
],
},
'mash_ash_unittests': {
'remove_from': [
# chromium.memory
# Unclear why this isn't run. http://crbug.com/814403
'Linux Chromium OS ASan LSan Tests (1)',
],
},
'aura_unittests': {
......@@ -90,8 +81,6 @@
# chromium.fyi
'Out of Process Profiling Windows',
'Win 10 Fast Ring',
# chromium.memory
'Linux ASan LSan Tests (1)',
],
},
'base_unittests': {
......@@ -140,13 +129,6 @@
},
},
},
'battor_agent_unittests': {
'remove_from': [
# chromium.memory
'Linux ASan LSan Tests (1)',
'Linux CFI',
],
},
'blink_heap_unittests': {
'remove_from': [
# On chromium.android, unclear why these aren't run on all bots.
......@@ -170,9 +152,7 @@
'CrWinAsan(dll) tester',
'CrWinAsanCov tester',
# chromium.memory
'Linux Chromium OS ASan LSan Tests (1)',
'Linux ChromiumOS MSan Tests',
'Linux TSan Tests',
'Linux TSan Tests', # https://crbug.com/831674
],
'modifications': {
# chromium.android
......@@ -235,12 +215,6 @@
'linux-chromeos-rel',
# On chromium.mac, unclear why these aren't run on "Mac10.12 Tests".
'Mac10.12 Tests',
# chromium.memory
'Linux ASan LSan Tests (1)',
'Linux CFI',
'Linux Chromium OS ASan LSan Tests (1)',
'Linux ChromiumOS MSan Tests',
'Linux TSan Tests',
],
},
'boringssl_ssl_tests': {
......@@ -266,13 +240,6 @@
'linux-chromeos-rel',
# On chromium.mac, unclear why these aren't run on "Mac10.12 Tests".
'Mac10.12 Tests',
# chromium.memory
'Linux ASan LSan Tests (1)',
'Linux CFI',
'Linux Chromium OS ASan LSan Tests (1)',
'Linux ChromiumOS MSan Tests',
'Linux MSan Tests',
'Linux TSan Tests',
],
},
'breakpad_unittests': {
......@@ -304,7 +271,7 @@
# chromium.fyi
'CrWinAsanCov tester',
# chromium.memory
'Linux TSan Tests',
'Linux TSan Tests', # https://crbug.com/368525
],
'modifications': {
# chromium.chromiumos
......@@ -465,9 +432,6 @@
'ToTLinuxThinLTO',
# chromium.fyi
'ThinLTO Linux ToT',
# chromium.memory
'Android CFI',
'Mac ASan 64 Tests (1)',
],
},
'cc_unittests': {
......@@ -476,8 +440,6 @@
'Linux ChromiumOS Tests (dbg)(1)',
'linux-chromeos-dbg',
'linux-chromeos-rel',
# chromium.memory
'Linux Chromium OS ASan LSan Tests (1)',
],
},
'checkbins': {
......@@ -779,9 +741,6 @@
'linux-chromeos-rel',
# chromium.clang
'ToTLinuxASan',
# chromium.memory
'Linux ASan LSan Tests (1)',
'Linux Chromium OS ASan LSan Tests (1)',
],
},
'components_background_task_scheduler_junit_tests': {
......@@ -934,9 +893,6 @@
# chromium.fyi
'Out of Process Profiling Windows',
'Win 10 Fast Ring',
# chromium.memory
'Linux ASan LSan Tests (1)',
'Linux TSan Tests',
],
},
'content_browsertests': {
......@@ -1368,8 +1324,6 @@
'ToTLinuxASan',
# chromium.linux
'Linux Tests (dbg)(1)(32)',
# chromium.memory
'Linux ASan LSan Tests (1)',
],
},
'device_unittests': {
......@@ -1383,8 +1337,6 @@
'Chromium Mac 10.11 Force Mac Toolchain',
'Chromium Mac 10.13',
'Out of Process Profiling Mac',
# chromium.memory
'Mac ASan 64 Tests (1)',
# chromium.win
'Win7 Tests (dbg)(1)',
],
......@@ -1446,8 +1398,6 @@
# chromium.fyi
'mac-views-rel',
'Chromium Mac 10.11 Force Mac Toolchain',
# chromium.memory
'Mac ASan 64 Tests (1)',
# chromium.win
'Win7 Tests (dbg)(1)',
],
......@@ -1456,8 +1406,6 @@
'remove_from': [
# chromium.clang
'ToTLinuxASan',
# chromium.memory
'Linux ASan LSan Tests (1)',
],
'modifications': {
'KitKat Tablet Tester': {
......@@ -1502,22 +1450,9 @@
'Mac ASan 64 Tests (1)',
],
},
'extensions_unittests': {
'remove_from': [
# chromium.memory
'Linux Chromium OS ASan LSan Tests (1)',
'Mac ASan 64 Tests (1)',
],
},
'filesystem_service_unittests': {
'remove_from': [
'Linux Tests (dbg)(1)(32)',
# chromium.memory
'Linux ASan LSan Tests (1)',
'Linux CFI',
'Linux ChromiumOS MSan Tests',
'Linux MSan Tests',
'Linux TSan Tests',
],
},
'gfx_unittests': {
......@@ -1529,9 +1464,6 @@
# chromium.android.fyi
'Lollipop Low-end Tester',
'x86 Cloud Tester',
# chromium.memory
'Linux ChromiumOS MSan Tests',
'Mac ASan 64 Tests (1)',
# chromium.win
'Win7 Tests (dbg)(1)',
],
......@@ -1582,7 +1514,7 @@
'Mac10.13 Tests',
'Mac10.13 Tests (dbg)',
# chromium.memory
'Linux ASan LSan Tests (1)',
'Linux ASan LSan Tests (1)', # https://crbug.com/831667
# On chromium.win, unclear why these only run on "Win7 Tests (1)".
'Win 7 Tests x64 (1)',
'Win10 Tests x64',
......@@ -1603,9 +1535,7 @@
'Out of Process Profiling Linux',
'ThinLTO Linux ToT',
# chromium.memory
'Linux ASan LSan Tests (1)',
'Linux CFI',
'Linux CFI',
'Linux ASan LSan Tests (1)', # https://crbug.com/830659
'Linux MSan Tests', # https://crbug.com/830659
'Linux ChromiumOS MSan Tests', # https://crbug.com/830659
'Linux TSan Tests', # https://crbug.com/830659
......@@ -1627,8 +1557,6 @@
'remove_from': [
# chromium.fyi
'Out of Process Profiling Linux',
# chromium.memory
'Linux ASan LSan Tests (1)',
],
'modifications': {
# chromium.android
......@@ -1724,8 +1652,6 @@
'Chromium Mac 10.13',
'Out of Process Profiling Linux',
'Out of Process Profiling Mac',
# chromium.memory
'Linux ASan LSan Tests (1)',
],
},
'google_apis_unittests': {
......@@ -1750,8 +1676,6 @@
# On chromium.linux, unclear why these aren't run on Cast.
'Cast Audio Linux',
'Cast Linux',
# chromium.memory
'Mac ASan 64 Tests (1)',
# chromium.win
'Win7 Tests (dbg)(1)',
],
......@@ -1993,9 +1917,6 @@
'Linux Tests',
'Linux Tests (dbg)(1)',
'Linux Tests (dbg)(1)(32)',
# chromium.memory
'Linux ASan LSan Tests (1)',
'Linux TSan Tests',
],
'modifications': {
'KitKat Tablet Tester': {
......@@ -2136,13 +2057,6 @@
# On chromium.linux, unclear why these aren't run.
'Linux Tests (dbg)(1)',
'Linux Tests (dbg)(1)(32)',
# chromium.memory
'Linux ASan LSan Tests (1)',
'Linux CFI',
'Linux ChromiumOS MSan Tests',
'Linux MSan Tests',
'Linux TSan Tests',
'Mac ASan 64 Tests (1)',
],
},
'metrics_python_tests': {
......@@ -2328,8 +2242,6 @@
'ToTMacASan',
# chromium.linux
'Linux Tests (dbg)(1)(32)',
# chromium.memory
'Linux ASan LSan Tests (1)',
],
},
'net_unittests': {
......@@ -2766,11 +2678,8 @@
'Cast Audio Linux',
'Cast Linux',
# chromium.memory
'Linux CFI',
'Linux ChromiumOS MSan Tests',
'Linux MSan Tests',
'Linux TSan Tests',
'Mac ASan 64 Tests (1)',
'Linux ChromiumOS MSan Tests', # https://crbug.com/831676
'Linux MSan Tests', # https://crbug.com/831676
],
'modifications': {
# chromium.android
......@@ -3225,9 +3134,6 @@
'remove_from': [
# chromium.clang
'ToTLinuxASan',
# chromium.memory
'Linux ASan LSan Tests (1)',
'Linux ChromiumOS MSan Tests',
],
'modifications': {
'KitKat Tablet Tester': {
......@@ -3372,8 +3278,6 @@
'ToTMacASan',
# chromium.linux
'Linux Tests (dbg)(1)(32)',
# chromium.memory
'Linux ASan LSan Tests (1)',
],
},
'viz_browser_tests': {
......@@ -3414,8 +3318,6 @@
'ThinLTO Linux ToT',
# chromium.win
'Win10 Tests x64',
# chromium.memory
'Linux CFI',
],
'modifications': {
'KitKat Tablet Tester': {
......@@ -3813,9 +3715,6 @@
'CrWinAsanCov tester',
# chromium.chromiumos
'linux-chromeos-rel', # crbug.com/795440
# chromium.memory
'Linux Chromium OS ASan LSan Tests (1)',
'Linux ChromiumOS MSan Tests',
],
'modifications': {
# chromium.memory
......@@ -3918,9 +3817,6 @@
# chromium.fyi
'Out of Process Profiling Windows',
'Win 10 Fast Ring',
# chromium.memory
'Linux ASan LSan Tests (1)',
'Linux Chromium OS ASan LSan Tests (1)',
],
},
'wtf_unittests': {
......@@ -3952,10 +3848,6 @@
'CrWinAsan tester',
'CrWinAsan(dll) tester',
'CrWinAsanCov tester',
# chromium.memory
'Linux Chromium OS ASan LSan Tests (1)',
'Linux ChromiumOS MSan Tests',
'Linux TSan Tests',
],
},
'zucchini_unittests': {
......
ui/gl/gl_context_glx_unittest.cc
View file @ d3695968
......@@ -15,7 +15,8 @@
namespace gl {
#if defined(THREAD_SANITIZER) || defined(MEMORY_SANITIZER)
#if defined(ADDRESS_SANITIZER) || defined(MEMORY_SANITIZER) || \
defined(THREAD_SANITIZER)
// https://crbug.com/830653
#define MAYBE_DoNotDestroyOnFailedMakeCurrent \
DISABLED_DoNotDestroyOnFailedMakeCurrent
......
ui/gl/gl_image_shared_memory_unittest.cc
View file @ d3695968
......@@ -69,7 +69,8 @@ INSTANTIATE_TYPED_TEST_CASE_P(GLImageSharedMemory,
GLImageTestTypes);
// https://crbug.com/830653
#if !defined(THREAD_SANITIZER) && !defined(MEMORY_SANITIZER)
#if !defined(ADDRESS_SANITIZER) && !defined(MEMORY_SANITIZER) && \
!defined(THREAD_SANITIZER)
INSTANTIATE_TYPED_TEST_CASE_P(GLImageSharedMemory,
GLImageCopyTest,
GLImageTestTypes);
......@@ -113,7 +114,8 @@ class GLImageSharedMemoryPoolTestDelegate : public GLImageTestDelegateBase {
};
// https://crbug.com/830653
#if !defined(THREAD_SANITIZER) && !defined(MEMORY_SANITIZER)
#if !defined(ADDRESS_SANITIZER) && !defined(MEMORY_SANITIZER) && \
!defined(THREAD_SANITIZER)
INSTANTIATE_TYPED_TEST_CASE_P(GLImageSharedMemoryPool,
GLImageCopyTest,
GLImageSharedMemoryPoolTestDelegate);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment