Commit d393828d authored by Alex Rudenko's avatar Alex Rudenko Committed by Commit Bot

Send CSS.styleSheetChanged when a stylesheet is mutated

Sending CSS.styleSheetChanged allows DevTools to pick up the latest
styles from the mutated stylesheet.

Fixed: 1096371
Change-Id: I9acdee212309e2f6f98cdf8bdbbecf9046fd01f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253739Reviewed-by: default avatarPeter Marshall <petermarshall@chromium.org>
Reviewed-by: default avatarMathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780240}
parent afbb4eba
...@@ -2228,6 +2228,7 @@ void InspectorCSSAgent::DidMutateStyleSheet(CSSStyleSheet* css_style_sheet) { ...@@ -2228,6 +2228,7 @@ void InspectorCSSAgent::DidMutateStyleSheet(CSSStyleSheet* css_style_sheet) {
if (!style_sheet) if (!style_sheet)
return; return;
style_sheet->MarkForSync(); style_sheet->MarkForSync();
StyleSheetChanged(style_sheet);
} }
void InspectorCSSAgent::StyleSheetChanged( void InspectorCSSAgent::StyleSheetChanged(
......
...@@ -11,4 +11,5 @@ div { ((index):1 -> :1:6) ...@@ -11,4 +11,5 @@ div { ((index):1 -> :1:6)
div { (user agent stylesheet) div { (user agent stylesheet)
display: block; display: block;
StyleSheetChanged triggered
...@@ -15,10 +15,20 @@ ...@@ -15,10 +15,20 @@
document.adoptedStyleSheets = [s]; document.adoptedStyleSheets = [s];
`); `);
ElementsTestRunner.selectNodeAndWaitForStyles('inspected', dump); ElementsTestRunner.selectNodeAndWaitForStyles('inspected', modify);
async function dump() { async function modify() {
await ElementsTestRunner.dumpSelectedElementStyles(true); await ElementsTestRunner.dumpSelectedElementStyles(true);
TestRunner.cssModel.addEventListener(SDK.CSSModel.Events.StyleSheetChanged, onStyleSheetChanged, this);
function onStyleSheetChanged(event) {
TestRunner.addResult('StyleSheetChanged triggered');
TestRunner.completeTest(); TestRunner.completeTest();
} }
await TestRunner.evaluateInPagePromise(`
s.insertRule('div {color: green}');
`);
}
})(); })();
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment