Commit d3a306e9 authored by Moe Ahmadi's avatar Moe Ahmadi Committed by Commit Bot

[iOS][Translate] Moves legacy translate infobar EG tests to a new target

Moves the EG tests related to the legacy translate infobar to a new target
as the new infobar EG tests rely on the CompactTranslateInfobarIOS feature
to be enabled via command line which will break the legacy infobar tests.

- This CL does not make any changes to the tests logic.
- The new target is the previous translate_egtest target which runs on
  downstream bots.

Bug: 910994
Change-Id: I9ea34207e20a5fb72e257ec5f0c8d9a43f05a440
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506571
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638333}
parent bcf5e8f8
......@@ -123,3 +123,32 @@ source_set("eg_tests") {
]
libs = [ "XCTest.framework" ]
}
source_set("external_url_eg_tests") {
configs += [ "//build/config/compiler:enable_arc" ]
testonly = true
sources = [
"legacy_translate_infobar_egtest.mm",
]
deps = [
":translate",
"//base",
"//base/test:test_support",
"//components/language/ios/browser",
"//components/strings",
"//components/translate/core/browser",
"//components/translate/core/common",
"//components/translate/ios/browser",
"//ios/chrome/browser/browser_state",
"//ios/chrome/browser/ui/translate:translate_ui",
"//ios/chrome/test/app:test_support",
"//ios/chrome/test/earl_grey:test_support",
"//ios/third_party/earl_grey:earl_grey+link",
"//ios/web:earl_grey_test_support",
"//ios/web/public/test",
"//ios/web/public/test/http_server",
"//net",
"//ui/base",
]
libs = [ "XCTest.framework" ]
}
specific_include_rules = {
# web::HttpServer is deprecated in favor of net::EmbeddedTestServer.
# TODO:(crbug.com/891834) Remove this exception.
# TODO:(crbug.com/891834) Remove these exceptions.
"translate_egtest\.mm": [
"+ios/web/public/test/http_server",
],
"legacy_translate_infobar_egtest\.mm": [
"+ios/web/public/test/http_server",
],
}
......@@ -10,6 +10,7 @@ group("all_tests") {
":ios_chrome_autofill_automation_egtests",
":ios_chrome_bookmarks_egtests",
":ios_chrome_device_check_egtests",
":ios_chrome_external_url_egtests",
":ios_chrome_flaky_egtests",
":ios_chrome_integration_egtests",
":ios_chrome_manual_fill_egtests",
......@@ -201,6 +202,12 @@ chrome_ios_eg_test("ios_chrome_translate_egtests") {
]
}
chrome_ios_eg_test("ios_chrome_external_url_egtests") {
deps = [
"//ios/chrome/browser/translate:external_url_eg_tests",
]
}
chrome_ios_eg_test("ios_chrome_unified_consent_egtests") {
deps = [
"//ios/chrome/browser/ui/settings/google_services:unified_consent_eg_tests",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment