Commit d4a58774 authored by Dan Harrington's avatar Dan Harrington Committed by Chromium LUCI CQ

Enable lottie capability

We're no longer blocked on using lottie, see crbug.com/1116501
I was able to confirm a lottie animation works.

Bug: 1158468
Change-Id: I05724d6f24630195e8eed0ec985edcc6792e9337
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636848Reviewed-by: default avatarJustin DeWitt <dewittj@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845404}
parent eccb423c
...@@ -120,6 +120,7 @@ feedwire::Request CreateFeedQueryRequest( ...@@ -120,6 +120,7 @@ feedwire::Request CreateFeedQueryRequest(
feedwire::FeedRequest& feed_request = *request.mutable_feed_request(); feedwire::FeedRequest& feed_request = *request.mutable_feed_request();
feed_request.add_client_capability(feedwire::Capability::BASE_UI); feed_request.add_client_capability(feedwire::Capability::BASE_UI);
feed_request.add_client_capability(feedwire::Capability::CARD_MENU); feed_request.add_client_capability(feedwire::Capability::CARD_MENU);
feed_request.add_client_capability(feedwire::Capability::LOTTIE_ANIMATIONS);
for (auto capability : GetFeedConfig().experimental_capabilities) for (auto capability : GetFeedConfig().experimental_capabilities)
feed_request.add_client_capability(capability); feed_request.add_client_capability(capability);
if (base::FeatureList::IsEnabled(kInterestFeedV2Hearts)) { if (base::FeatureList::IsEnabled(kInterestFeedV2Hearts)) {
......
...@@ -58,6 +58,7 @@ TEST(ProtoUtilTest, DefaultCapabilities) { ...@@ -58,6 +58,7 @@ TEST(ProtoUtilTest, DefaultCapabilities) {
request.client_capability(), request.client_capability(),
testing::UnorderedElementsAre( testing::UnorderedElementsAre(
feedwire::Capability::BASE_UI, feedwire::Capability::REQUEST_SCHEDULE, feedwire::Capability::BASE_UI, feedwire::Capability::REQUEST_SCHEDULE,
feedwire::Capability::LOTTIE_ANIMATIONS,
feedwire::Capability::OPEN_IN_TAB, feedwire::Capability::CARD_MENU, feedwire::Capability::OPEN_IN_TAB, feedwire::Capability::CARD_MENU,
feedwire::Capability::DOWNLOAD_LINK, feedwire::Capability::DOWNLOAD_LINK,
feedwire::Capability::INFINITE_FEED, feedwire::Capability::INFINITE_FEED,
...@@ -99,6 +100,7 @@ TEST(ProtoUtilTest, DisableCapabilitiesWithFinch) { ...@@ -99,6 +100,7 @@ TEST(ProtoUtilTest, DisableCapabilitiesWithFinch) {
request.client_capability(), request.client_capability(),
testing::UnorderedElementsAre( testing::UnorderedElementsAre(
feedwire::Capability::BASE_UI, feedwire::Capability::REQUEST_SCHEDULE, feedwire::Capability::BASE_UI, feedwire::Capability::REQUEST_SCHEDULE,
feedwire::Capability::LOTTIE_ANIMATIONS,
feedwire::Capability::OPEN_IN_TAB, feedwire::Capability::CARD_MENU, feedwire::Capability::OPEN_IN_TAB, feedwire::Capability::CARD_MENU,
feedwire::Capability::DOWNLOAD_LINK, feedwire::Capability::DOWNLOAD_LINK,
feedwire::Capability::DISMISS_COMMAND, feedwire::Capability::DISMISS_COMMAND,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment