Commit d4a5a6ce authored by ojan@chromium.org's avatar ojan@chromium.org

Make a bunch of static changes to sheriff-o-matic.

-A bunch of minor UI tweaks to get things to line up better.
-Align the examine/snooze buttons vertically so they take up less space.
-Make the tabs in ct-results-by-builder black and more tab-looking.
-Change the name to Sheriff-o-matic now that it's clear we're sticking with it.
-Add a useful links link to the right of the revisions.

BUG=400411,400398
NOTRY=true

Review URL: https://codereview.chromium.org/462363003

git-svn-id: svn://svn.chromium.org/blink/trunk@180294 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 788e2d49
...@@ -24,6 +24,7 @@ found in the LICENSE file. ...@@ -24,6 +24,7 @@ found in the LICENSE file.
border: 1px solid #dcdcdc; border: 1px solid #dcdcdc;
color: #444; color: #444;
padding: 0 16px; padding: 0 16px;
margin-bottom: 5px;
text-align: center; text-align: center;
} }
...@@ -48,25 +49,27 @@ found in the LICENSE file. ...@@ -48,25 +49,27 @@ found in the LICENSE file.
width: 250px; width: 250px;
} }
.failure { #failure {
flex: 1; flex: 1;
} }
.snoozed { #buttons {
opacity: 0.5; display: flex;
flex-direction: column;
} }
#examine, #snooze { .snoozed {
align-self: flex-start; opacity: 0.5;
} }
</style> </style>
<ct-builder-grid failures="{{ group.failures }}"></ct-builder-grid> <ct-builder-grid failures="{{ group.failures }}"></ct-builder-grid>
<div class="{{ { failure: true, snoozed: group.isSnoozed } | tokenList }}"> <div id="failure" class="{{ { snoozed: group.isSnoozed } | tokenList }}">
<ct-test-list tests="{{ group.failures }}" tree="{{ tree }}"></ct-test-list> <ct-test-list tests="{{ group.failures }}" tree="{{ tree }}"></ct-test-list>
<ct-commit-list first="{{ group.failures[0].lastPassingRevisions }}" <ct-commit-list first="{{ group.failures[0].lastPassingRevisions }}"
last="{{ group.failures[0].firstFailingRevisions }}" last="{{ group.failures[0].firstFailingRevisions }}"
commits="{{ commits }}"></ct-commit-list> commits="{{ commits }}"></ct-commit-list>
</div> </div>
<div id="buttons">
<paper-button id="examine" on-tap="{{ examine }}">Examine</paper-button> <paper-button id="examine" on-tap="{{ examine }}">Examine</paper-button>
<template if="{{ !group.isSnoozed }}"> <template if="{{ !group.isSnoozed }}">
<paper-button id="snooze" on-tap="{{ snooze }}">Snooze</paper-button> <paper-button id="snooze" on-tap="{{ snooze }}">Snooze</paper-button>
...@@ -74,6 +77,7 @@ found in the LICENSE file. ...@@ -74,6 +77,7 @@ found in the LICENSE file.
<template if="{{ group.isSnoozed }}"> <template if="{{ group.isSnoozed }}">
<paper-button id="snooze" on-tap="{{ unsnooze }}">Unsnooze</paper-button> <paper-button id="snooze" on-tap="{{ unsnooze }}">Unsnooze</paper-button>
</template> </template>
</div>
</template> </template>
<script> <script>
Polymer({ Polymer({
......
...@@ -14,7 +14,7 @@ found in the LICENSE file. ...@@ -14,7 +14,7 @@ found in the LICENSE file.
} }
ct-failure-card { ct-failure-card {
margin: 5px; margin-bottom: 5px;
padding: 5px; padding: 5px;
border-top: 1px solid lightgrey; border-top: 1px solid lightgrey;
} }
......
...@@ -15,6 +15,17 @@ found in the LICENSE file. ...@@ -15,6 +15,17 @@ found in the LICENSE file.
:host { :host {
display: block; display: block;
} }
paper-tabs::shadow #selectionBar {
background-color: #212121;
height: 4px;
}
paper-tab {
border: 1px solid #212121;
border-radius: 5px 5px 0 0;
}
paper-tab::shadow #ink {
color: #212121;
}
</style> </style>
<paper-tabs selected="{{ selected }}"> <paper-tabs selected="{{ selected }}">
<template repeat="{{ builder in builders }}"> <template repeat="{{ builder in builders }}">
......
...@@ -11,9 +11,6 @@ found in the LICENSE file. ...@@ -11,9 +11,6 @@ found in the LICENSE file.
<polymer-element name="ct-revision-details" attributes="builderLatestRevisions revisionLog tree"> <polymer-element name="ct-revision-details" attributes="builderLatestRevisions revisionLog tree">
<template> <template>
<style> <style>
:host {
padding-left: 2em;
}
ct-popup-menu > div { ct-popup-menu > div {
display: flex; display: flex;
justify-content: space-between; justify-content: space-between;
......
...@@ -29,6 +29,7 @@ found in the LICENSE file. ...@@ -29,6 +29,7 @@ found in the LICENSE file.
display: flex; display: flex;
justify-content: space-between; justify-content: space-between;
font-size: 1.1em; font-size: 1.1em;
padding: 0 5px;
} }
header a, header span { header a, header span {
color: white; color: white;
...@@ -36,6 +37,13 @@ found in the LICENSE file. ...@@ -36,6 +37,13 @@ found in the LICENSE file.
padding: 0.25em 4px; padding: 0.25em 4px;
text-decoration: none; text-decoration: none;
} }
#right-toolbar {
display: flex;
align-items: center;
}
ct-last-updated {
margin: 0 5px;
}
core-animated-pages { core-animated-pages {
flex: 1; flex: 1;
} }
...@@ -44,7 +52,7 @@ found in the LICENSE file. ...@@ -44,7 +52,7 @@ found in the LICENSE file.
<header> <header>
<div> <div>
<template if="{{ selected == 0 }}"> <template if="{{ selected == 0 }}">
<span><img src="../favicon.ico"> Auto-sheriff-o-maticon</span> <img src="../favicon.ico"> <span>Sheriff-o-matic</span>
</template> </template>
<template if="{{ selected == 1 }}"> <template if="{{ selected == 1 }}">
<a on-click="{{ onBack }}"> <a on-click="{{ onBack }}">
...@@ -52,7 +60,7 @@ found in the LICENSE file. ...@@ -52,7 +60,7 @@ found in the LICENSE file.
</a> </a>
</template> </template>
</div> </div>
<div> <div id="right-toolbar">
<ct-last-updated date="{{ lastUpdateDate }}"></ct-last-updated> <ct-last-updated date="{{ lastUpdateDate }}"></ct-last-updated>
<!-- FIXME: Use a proper polymer component with data binding. --> <!-- FIXME: Use a proper polymer component with data binding. -->
<select id="tree" on-change="{{ _updateTree }}"> <select id="tree" on-change="{{ _updateTree }}">
......
...@@ -13,9 +13,19 @@ found in the LICENSE file. ...@@ -13,9 +13,19 @@ found in the LICENSE file.
display: block; display: block;
} }
:host > div {
/* Be at least the height of a paper-icon-button.
So things line up nicely. */
min-height: 24px;
}
paper-icon-button { paper-icon-button {
vertical-align: middle; vertical-align: middle;
} }
paper-icon-button::shadow #icon {
margin: 0;
}
</style> </style>
<template repeat="{{ groups in testGroups_ }}"> <template repeat="{{ groups in testGroups_ }}">
<!-- FIXME: Find a less redundant UI than repeating the step on each line. --> <!-- FIXME: Find a less redundant UI than repeating the step on each line. -->
......
...@@ -29,11 +29,21 @@ found in the LICENSE file. ...@@ -29,11 +29,21 @@ found in the LICENSE file.
margin: 0; margin: 0;
padding: 0; padding: 0;
} }
.toolbar {
display: flex;
justify-content: space-between;
align-items: baseline;
padding: 0 5px;
}
</style> </style>
<ct-failure-analyzer id="analyzer" failures="{{ failures }}" builderLatestRevisions="{{ builderLatestRevisions }}" lastUpdateDate="{{ lastUpdateDate }}"></ct-failure-analyzer> <ct-failure-analyzer id="analyzer" failures="{{ failures }}" builderLatestRevisions="{{ builderLatestRevisions }}" lastUpdateDate="{{ lastUpdateDate }}"></ct-failure-analyzer>
<div class="toolbar">
<ct-revision-details id="revisionDetails" builderLatestRevisions="{{ builderLatestRevisions }}" revisionLog="{{ revisionLog }}" tree="{{ tree }}"></ct-revision-details>
<a href="https://code.google.com/p/chromium/wiki/UsefulURLs">Useful URLs</a>
</div>
<ct-tree-status status="{{ treeStatuses['chromium'] }}" state="{{ treeStatuses['chromium'].status }}"></ct-tree-status> <ct-tree-status status="{{ treeStatuses['chromium'] }}" state="{{ treeStatuses['chromium'].status }}"></ct-tree-status>
<ct-tree-status status="{{ treeStatuses['blink'] }}" state="{{ treeStatuses['blink'].status }}"></ct-tree-status> <ct-tree-status status="{{ treeStatuses['blink'] }}" state="{{ treeStatuses['blink'].status }}"></ct-tree-status>
<ct-revision-details id="revisionDetails" builderLatestRevisions="{{ builderLatestRevisions }}" revisionLog="{{ revisionLog }}" tree="{{ tree }}"></ct-revision-details>
<ct-party-time failures="{{ failures }}" tree="{{ tree }}"></ct-party-time> <ct-party-time failures="{{ failures }}" tree="{{ tree }}"></ct-party-time>
<ct-failure-stream groups="{{ failures[tree] }}" commits="{{ revisionLog }}" tree="{{ tree }}"></ct-failure-stream> <ct-failure-stream groups="{{ failures[tree] }}" commits="{{ revisionLog }}" tree="{{ tree }}"></ct-failure-stream>
</template> </template>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment