Commit d4de4cd7 authored by Carlos Caballero's avatar Carlos Caballero Committed by Commit Bot

Remove SequenceManager on top of MessageLoop tests

MessageLoop is deprecated and we no longer run SequenceManager
instances on top of a MessageLoop

BUG=891670

Change-Id: Ie24973c321b0656b7decc2bc33b9d0566d4e2fc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715502
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: default avatarSami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#682717}
parent 73c5df92
......@@ -64,15 +64,7 @@ class PerfTestTimeDomain : public MockTimeDomain {
DISALLOW_COPY_AND_ASSIGN(PerfTestTimeDomain);
};
// TODO(crbug.com/891670): This can be simplified after the transition away from
// the old base::MessageLoop.
enum class PerfTestType {
// A SequenceManager on top of a MessageLoop (which is SequenceManager based).
// This configuration is now strictly overkill.
kUseSequenceManagerWithMessageLoop,
kUseSequenceManagerWithUIMessageLoop,
kUseSequenceManagerWithIOMessageLoop,
// A SequenceManager with a ThreadControllerWithMessagePumpImpl driving the
// thread.
kUseSequenceManagerWithMessagePump,
......@@ -80,12 +72,6 @@ enum class PerfTestType {
kUseSequenceManagerWithIOMessagePump,
kUseSequenceManagerWithMessagePumpAndRandomSampling,
// A SequenceManager backed base::MessageLoop (now the default and only
// base::MessageLoop configuration).
kUseMessageLoop,
kUseUIMessageLoop,
kUseIOMessageLoop,
// A SingleThreadTaskRunner in the thread pool.
kUseSingleThreadInThreadPool,
};
......@@ -594,21 +580,6 @@ class SequenceManagerPerfTest : public testing::TestWithParam<PerfTestType> {
std::unique_ptr<PerfTestDelegate> CreateDelegate() {
switch (GetParam()) {
case PerfTestType::kUseSequenceManagerWithMessageLoop:
return std::make_unique<
SequenceManagerWithMessageLoopPerfTestDelegate<MessageLoop>>(
" SequenceManager with MessageLoop ");
case PerfTestType::kUseSequenceManagerWithUIMessageLoop:
return std::make_unique<
SequenceManagerWithMessageLoopPerfTestDelegate<MessageLoopForUI>>(
" SequenceManager with MessageLoopForUI ");
case PerfTestType::kUseSequenceManagerWithIOMessageLoop:
return std::make_unique<
SequenceManagerWithMessageLoopPerfTestDelegate<MessageLoopForIO>>(
" SequenceManager with MessageLoopForIO ");
case PerfTestType::kUseSequenceManagerWithMessagePump:
return std::make_unique<SequenceManagerWithMessagePumpPerfTestDelegate>(
" SequenceManager with MessagePumpDefault ",
......@@ -627,18 +598,6 @@ class SequenceManagerPerfTest : public testing::TestWithParam<PerfTestType> {
" SequenceManager with MessagePumpDefault and random sampling ",
MessagePump::Type::DEFAULT, true);
case PerfTestType::kUseMessageLoop:
return std::make_unique<MessageLoopPerfTestDelegate>(
" MessageLoop ", std::make_unique<MessageLoop>());
case PerfTestType::kUseUIMessageLoop:
return std::make_unique<MessageLoopPerfTestDelegate>(
" MessageLoopForUI ", std::make_unique<MessageLoopForUI>());
case PerfTestType::kUseIOMessageLoop:
return std::make_unique<MessageLoopPerfTestDelegate>(
" MessageLoopForIO ", std::make_unique<MessageLoopForIO>());
case PerfTestType::kUseSingleThreadInThreadPool:
return std::make_unique<SingleThreadInThreadPoolPerfTestDelegate>();
......@@ -687,15 +646,9 @@ INSTANTIATE_TEST_SUITE_P(
,
SequenceManagerPerfTest,
testing::Values(
PerfTestType::kUseSequenceManagerWithMessageLoop,
PerfTestType::kUseSequenceManagerWithMessagePump,
PerfTestType::kUseSequenceManagerWithUIMessageLoop,
PerfTestType::kUseSequenceManagerWithUIMessagePump,
PerfTestType::kUseSequenceManagerWithIOMessageLoop,
PerfTestType::kUseSequenceManagerWithIOMessagePump,
PerfTestType::kUseMessageLoop,
PerfTestType::kUseUIMessageLoop,
PerfTestType::kUseIOMessageLoop,
PerfTestType::kUseSingleThreadInThreadPool,
PerfTestType::kUseSequenceManagerWithMessagePumpAndRandomSampling));
TEST_P(SequenceManagerPerfTest, PostDelayedTasks_OneQueue) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment