Commit d5eceb19 authored by Eugene But's avatar Eugene But Committed by Commit Bot

Log User Actions for Most Visited taps earlier.

User Actions are added to Breadscrumbs (log attached to steps to
reproduce). Logging the actions earler will include them into
Breadcrumbs if presentation code crashes (like what happens in
crbug.com/1050786).

Bug: 1046231
Change-Id: I6cde3c11320d41135bbeffc9d4943d5b9645a293
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087874
Auto-Submit: Eugene But <eugenebut@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747148}
parent ca90c90b
...@@ -251,20 +251,20 @@ const char kNTPHelpURL[] = ...@@ -251,20 +251,20 @@ const char kNTPHelpURL[] =
item); item);
switch (mostVisitedItem.collectionShortcutType) { switch (mostVisitedItem.collectionShortcutType) {
case NTPCollectionShortcutTypeBookmark: case NTPCollectionShortcutTypeBookmark:
[self.dispatcher showBookmarksManager];
base::RecordAction(base::UserMetricsAction("MobileNTPShowBookmarks")); base::RecordAction(base::UserMetricsAction("MobileNTPShowBookmarks"));
[self.dispatcher showBookmarksManager];
break; break;
case NTPCollectionShortcutTypeReadingList: case NTPCollectionShortcutTypeReadingList:
[self.dispatcher showReadingList];
base::RecordAction(base::UserMetricsAction("MobileNTPShowReadingList")); base::RecordAction(base::UserMetricsAction("MobileNTPShowReadingList"));
[self.dispatcher showReadingList];
break; break;
case NTPCollectionShortcutTypeRecentTabs: case NTPCollectionShortcutTypeRecentTabs:
[self.dispatcher showRecentTabs];
base::RecordAction(base::UserMetricsAction("MobileNTPShowRecentTabs")); base::RecordAction(base::UserMetricsAction("MobileNTPShowRecentTabs"));
[self.dispatcher showRecentTabs];
break; break;
case NTPCollectionShortcutTypeHistory: case NTPCollectionShortcutTypeHistory:
[self.dispatcher showHistory];
base::RecordAction(base::UserMetricsAction("MobileNTPShowHistory")); base::RecordAction(base::UserMetricsAction("MobileNTPShowHistory"));
[self.dispatcher showHistory];
break; break;
case NTPCollectionShortcutTypeCount: case NTPCollectionShortcutTypeCount:
NOTREACHED(); NOTREACHED();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment