Dedupe mime_handler_view test extension id

Several mime_handler_view tests have a copy of the test extension id.
We now use the common constant.

Bug: None
Change-Id: If9c08f486698a1c32fc9c2871a379e474589a2f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624771
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842666}

chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_browsertest.cc

@@ -62,10 +62,6 @@ using guest_view::GuestViewManager;
 using guest_view::TestGuestViewManager;
 using guest_view::TestGuestViewManagerFactory;
 
-namespace {
-constexpr char kTestExtensionId[] = "oickdpebdnfbgkcaoklfcdhjniefkcji";
-}
-
 // Note: This file contains several old WebViewGuest tests which were for
 // certain BrowserPlugin features and no longer made sense for the new
 // WebViewGuest which is based on cross-process frames. Since
@@ -123,7 +119,8 @@ class ChromeMimeHandlerViewTest : public extensions::ExtensionApiTest {
     const extensions::Extension* extension =
         LoadExtension(test_data_dir_.AppendASCII("mime_handler_view"));
     ASSERT_TRUE(extension);
-    CHECK_EQ(kTestExtensionId, extension->id());
+    ASSERT_EQ(std::string(extension_misc::kMimeHandlerPrivateTestExtensionId),
+              extension->id());
 
     extensions::ResultCatcher catcher;
     ui_test_utils::NavigateToURL(browser(), url);
@@ -156,11 +153,13 @@ class ChromeMimeHandlerViewTest : public extensions::ExtensionApiTest {
     transferrable_loader->head->mime_type = "application/pdf";
     transferrable_loader->head->headers =
         base::MakeRefCounted<net::HttpResponseHeaders>("HTTP/2 200 OK");
+    const std::string extension_id =
+        extension_misc::kMimeHandlerPrivateTestExtensionId;
     return std::make_unique<extensions::StreamContainer>(
         0 /* tab_id */, false /* embedded */,
-        GURL(std::string(extensions::kExtensionScheme) +
-             kTestExtensionId) /* handler_url */,
-        kTestExtensionId, std::move(transferrable_loader), url);
+        extensions::Extension::GetBaseURLFromExtensionId(
+            extension_id) /* handler_url */,
+        extension_id, std::move(transferrable_loader), url);
   }
 
  private:

chrome/test/data/extensions/api_test/mime_handler_view/manifest.json

 {
+  // This extension's id is allowed to handle mime types.
+  // chrome-extension://oickdpebdnfbgkcaoklfcdhjniefkcji
   "name": "Test MIMEHandlerView",
   "version": "1",
   "manifest_version": 2,

extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc

@@ -38,6 +38,7 @@
 #include "extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h"
 #include "extensions/browser/guest_view/mime_handler_view/test_mime_handler_view_guest.h"
 #include "extensions/browser/process_manager.h"
+#include "extensions/common/constants.h"
 #include "extensions/common/guest_view/extensions_guest_view_messages.h"
 #include "extensions/common/mojom/guest_view.mojom.h"
 #include "extensions/test/result_catcher.h"
@@ -58,9 +59,6 @@ using guest_view::GuestViewManagerDelegate;
 using guest_view::TestGuestViewManager;
 using guest_view::TestGuestViewManagerFactory;
 
-// The test extension id is set by the key value in the manifest.
-const char kExtensionId[] = "oickdpebdnfbgkcaoklfcdhjniefkcji";
-
 class MimeHandlerViewTest : public extensions::ExtensionApiTest {
  public:
   MimeHandlerViewTest() {
@@ -117,7 +115,8 @@ class MimeHandlerViewTest : public extensions::ExtensionApiTest {
     if (!extension)
       return nullptr;
 
-    CHECK_EQ(std::string(kExtensionId), extension->id());
+    EXPECT_EQ(std::string(extension_misc::kMimeHandlerPrivateTestExtensionId),
+              extension->id());
 
     return extension;
   }

extensions/browser/guest_view/mime_handler_view/mime_handler_view_interactive_uitest.cc

@@ -30,6 +30,7 @@
 #include "extensions/browser/guest_view/extensions_guest_view_manager_delegate.h"
 #include "extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h"
 #include "extensions/browser/guest_view/mime_handler_view/test_mime_handler_view_guest.h"
+#include "extensions/common/constants.h"
 #include "extensions/test/result_catcher.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "third_party/blink/public/common/input/web_pointer_properties.h"
@@ -41,9 +42,6 @@ using guest_view::TestGuestViewManagerFactory;
 
 namespace extensions {
 
-// The test extension id is set by the key value in the manifest.
-const char kExtensionId[] = "oickdpebdnfbgkcaoklfcdhjniefkcji";
-
 // Counts the number of URL requests made for a given URL.
 class MimeHandlerViewTest : public ExtensionApiTest {
  public:
@@ -88,7 +86,8 @@ class MimeHandlerViewTest : public ExtensionApiTest {
     if (!extension)
       return nullptr;
 
-    CHECK_EQ(std::string(kExtensionId), extension->id());
+    EXPECT_EQ(std::string(extension_misc::kMimeHandlerPrivateTestExtensionId),
+              extension->id());
 
     return extension;
   }