Commit d699aa1e authored by Gabriel Charette's avatar Gabriel Charette Committed by Commit Bot

Migrate comment in BackgroundTracingManager off of FILE thread.

Bug: 689520
Change-Id: I2bd06d69cb54fc81edb8a462caa6458effb5bdfe
Reviewed-on: https://chromium-review.googlesource.com/580397Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488658}
parent bc3e2f93
...@@ -22,30 +22,26 @@ class BackgroundTracingManager { ...@@ -22,30 +22,26 @@ class BackgroundTracingManager {
public: public:
CONTENT_EXPORT static BackgroundTracingManager* GetInstance(); CONTENT_EXPORT static BackgroundTracingManager* GetInstance();
// ReceiveCallback will will be called on the UI thread every time the // ReceiveCallback will be called on the UI thread every time the
// BackgroundTracingManager finalizes a trace. The first parameter of // BackgroundTracingManager finalizes a trace. The first parameter of this
// this callback is the trace data. The second is metadata that was // callback is the trace data. The second is metadata that was generated and
// generated and embedded into the trace. The third is a callback to // embedded into the trace. The third is a callback to notify the
// notify the BackgroundTracingManager that you've finished processing // BackgroundTracingManager that you've finished processing the trace data.
// the trace data.
// //
// Example: // Example:
// //
// void Upload(const scoped_refptr<base::RefCountedString>& data, // void Upload(const scoped_refptr<base::RefCountedString>& data,
// std::unique_ptr<base::DictionaryValue>, // std::unique_ptr<base::DictionaryValue>,
// base::Closure done_callback) { // base::Closure done_callback) {
// BrowserThread::PostTaskAndReply( // base::PostTaskWithTraitsAndReply(
// BrowserThread::FILE, // FROM_HERE, {base::MayBlock(), base::TaskPriority::BACKGROUND},
// FROM_HERE, // base::Bind(&DoUploadInBackground, data), done_callback);
// base::Bind(&DoUploadOnFileThread, data),
// done_callback
// );
// } // }
// //
typedef base::Callback<void(const scoped_refptr<base::RefCountedString>&, using ReceiveCallback =
base::Callback<void(const scoped_refptr<base::RefCountedString>&,
std::unique_ptr<const base::DictionaryValue>, std::unique_ptr<const base::DictionaryValue>,
base::Closure)> base::Closure)>;
ReceiveCallback;
// Set the triggering rules for when to start recording. // Set the triggering rules for when to start recording.
// //
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment