Commit d87ffab4 authored by binji's avatar binji Committed by Commit bot

[NaCl SDK] Install libpnacl_irt_shim.a into the correct location.

After we changed the PNaCl toolchain layout, this library was being installed
to the wrong location. Actually, it was worse -- the directory didn't exist, so
the library was being copied into a file called linux_pnacl/lib-<arch>.

The correct location is now linux_pnacl/translator/<arch>/lib.

BUG=423373
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/655353002

Cr-Commit-Position: refs/heads/master@{#299974}
parent 81ab7b01
...@@ -138,10 +138,10 @@ def GetOutputToolchainLib(pepperdir, tcname, xarch): ...@@ -138,10 +138,10 @@ def GetOutputToolchainLib(pepperdir, tcname, xarch):
return GetToolchainNaClLib(tcname, tcpath, xarch) return GetToolchainNaClLib(tcname, tcpath, xarch)
def GetPNaClNativeLib(tcpath, arch): def GetPNaClTranslatorLib(tcpath, arch):
if arch not in ['arm', 'x86-32', 'x86-64']: if arch not in ['arm', 'x86-32', 'x86-64']:
buildbot_common.ErrorExit('Unknown architecture %s.' % arch) buildbot_common.ErrorExit('Unknown architecture %s.' % arch)
return os.path.join(tcpath, 'lib-' + arch) return os.path.join(tcpath, 'translator', arch, 'lib')
def BuildStepDownloadToolchains(toolchains): def BuildStepDownloadToolchains(toolchains):
...@@ -613,9 +613,14 @@ def BuildStepBuildToolchains(pepperdir, toolchains): ...@@ -613,9 +613,14 @@ def BuildStepBuildToolchains(pepperdir, toolchains):
'gen', 'tc_pnacl_translate', 'gen', 'tc_pnacl_translate',
'lib-' + nacl_arch) 'lib-' + nacl_arch)
pnacl_translator_lib_dir = GetPNaClTranslatorLib(pnacldir, nacl_arch)
if not os.path.isdir(pnacl_translator_lib_dir):
buildbot_common.ErrorExit('Expected %s directory to exist.' %
pnacl_translator_lib_dir)
buildbot_common.CopyFile( buildbot_common.CopyFile(
os.path.join(release_build_dir, 'libpnacl_irt_shim.a'), os.path.join(release_build_dir, 'libpnacl_irt_shim.a'),
GetPNaClNativeLib(pnacldir, nacl_arch)) pnacl_translator_lib_dir)
InstallNaClHeaders(GetToolchainNaClInclude('pnacl', pnacldir, 'x86'), InstallNaClHeaders(GetToolchainNaClInclude('pnacl', pnacldir, 'x86'),
'newlib') 'newlib')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment