Make integration test extension manifest names consistent

Name various test extensions used in integration test consistently, in
particular, the test extensions used in the providers.js tests [1].

[1] these are the only integration testcases that explicitly depend on
test extension manifest name. Add a helper to return the name.

Bug: 869240
Change-Id: I9d5ab74af9083201ab2c0173c2e505ec6f6e05be
Reviewed-on: https://chromium-review.googlesource.com/1154784Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579316}

ui/file_manager/integration_tests/audio_player_test_manifest.json

 {
   // chrome-extension:/ddabbgbggambiildohfagdkliahiecfl/
   "key": "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAqyMPfoy88DMSxVONd2NEK9u7OQfKjWQujB541dn+NNSFUEqSF6lYehgX77x7eGEs1DCHhZynX71o5JYLe2oeWt/HBDR/tWpdwwh80owIQDwaKJrfRtisyVL++dMmf0pNjFv1F5tFXObO84F22oZyBA89Z0S0jNlHjyVzm7U4BwbDHhHBoGXGJxf5AXL5quLdwlVe69d6ZjiSkYvaAAGwwYDWuqG8VFaZuz4Onh/bSYocBtd6rpeRwS7tAkTugCU0Mnivaj/x9WYajomcg+/QSQhwjbH+9+8zqsmpnKIeCY/qxadI9CYMMyg3Kbo53THQKRe6/DaXazgthMqAL9TGAwIDAQAB",
-  "name": "chrome os audio player browser tests",
+  "name": "Audio Player test extension",
   "version": "0.1",
   "manifest_version": 2,
   "web_accessible_resources": ["*"],

ui/file_manager/integration_tests/file_manager/providers.js

@@ -6,6 +6,25 @@
 
 (function() {
 
+/**
+ * Returns provider name of the given testing provider manifest viz., the
+ * the value of the name field in the |manifest| file.
+ * @param {string} manifest Testing provider manifest file name.
+ * @return {string} Testing provider name.
+ */
+function getProviderNameForTest(manifest) {
+  if (manifest === 'manifest.json')
+    return 'Files Testing Provider test extension';
+  if (manifest === 'manifest_multiple_mounts.json')
+    return 'Files Testing Provider multiple mounts test extension';
+  if (manifest === 'manifest_source_device.json')
+    return 'Files Testing Provider device test extension';
+  if (manifest === 'manifest_source_file.json')
+    return 'Files Testing Provider file test extension';
+
+  throw new Error('unknown mainfest: '.concat(manifest));
+}
+
 var appId;
 
 /**
@@ -101,6 +120,8 @@ function getConfirmVolumeSteps(ejectExpected) {
  *     extension.
  */
 function requestMountInternal(multipleMounts, manifest) {
+  const providerName = getProviderNameForTest(manifest);
+
   StepsRunner.runGroups([
     getSetupSteps(manifest),
     getClickMenuSteps(),
@@ -114,7 +135,7 @@ function requestMountInternal(multipleMounts, manifest) {
             .then(this.next);
       },
       function(result) {
-        chrome.test.assertEq('Testing Provider', result.text);
+        chrome.test.assertEq(providerName, result.text);
         remoteCall.callRemoteTestUtil(
             'fakeMouseClick',
             appId,
@@ -140,7 +161,7 @@ function requestMountInternal(multipleMounts, manifest) {
       },
       function(result) {
         if (multipleMounts)
-          chrome.test.assertEq('Testing Provider', result.text);
+          chrome.test.assertEq(providerName, result.text);
         checkIfNoErrorsOccured(this.next);
       }
     ]

ui/file_manager/integration_tests/file_manager_test_manifest.json

 {
   // chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/
   "key": "MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDBjsTE4ocXJWzgcCDCUcsPASoRCGaTHrHn6b4zDTCayTuJtyGKzw4xZPMiG4dbEbmSAwEU7UCoyJAM1XfLS7UQ/Zz7ft8wpZkSS8/PJW+E4Qu++tMS0csj2Wdrrd2c5yyWxlJ+H9o2ivwtwuxs7pd+LXt+gsBA0epnT04T9EvOTQIDAQAB",
-  "name": "chrome file manager browser tests",
+  "name": "Files test extension",
   "version": "0.1",
   "incognito": "split",  // Run a separate instance for the incognito mode.
   "manifest_version": 2,

ui/file_manager/integration_tests/gallery_test_manifest.json

 {
   // chrome-extension://ejhcmmdhhpdhhgmifplfmjobgegbibkn/
   "key": "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA2fEDh/TfZD2T2rabtuF922S/6n6Yby1EbjYFEaMExJrir3KJOxOMbUMF+6xChlweGnHBy7CQPtzMfYfjmftHpN7SDWVRRjcAb8vu8pyEcaEkdFQPkij5k8L9v6d7uoygbEsak/IOTYNWTZDrqPc47ypuEM4AG7/bf8NNVDq7EYlj1Lq4AfboEujMb7iif5VNRSfCTUcfddbLxk/J6QyomYlSpssKBCw1LRDnM+aRMFt70ElTozf3Oho7/22P7BXEYPr6YHdZotzb2HyBZ6pV6W9LAhuhsbmNByj0s9C+UmiqeyLoL0ALlqTydW7zDSYGHDRRDZLVMIgrb9D1ZQcUnwIDAQAB",
-  "name": "chrome gallery browser tests",
+  "name": "Gallery test extension",
   "version": "0.1",
   "manifest_version": 2,
   "web_accessible_resources": ["*"],

ui/file_manager/integration_tests/testing_provider/background.js

@@ -54,7 +54,7 @@ chrome.fileSystemProvider.onGetActionsRequested.addListener(
 
 // If the manifest for device or file source is used, then mount a fake file
 // system on install.
-if (chrome.runtime.getManifest().name === "Testing Provider Device" ||
-    chrome.runtime.getManifest().name === "Testing Provider File") {
+if (chrome.runtime.getManifest().description === "Testing Provider device" ||
+    chrome.runtime.getManifest().description === "Testing Provider file") {
   chrome.runtime.onInstalled.addListener(mountFileSystem);
 }

ui/file_manager/integration_tests/testing_provider/manifest.json

 {
   // chrome-extension://pkplfbidichfdicaijlchgnapepdginl
   "key": "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAtDfX9dHNh948bt00YhZBm3P6E5QLaOt+v8kXVtibQfiPtOD2FTScB/f0wX/EQWVO7BkaSOsRkTPcPIgocyMPYr2FLgqGLFlYT9nQpKJZUFNF5oJ5rG6Nv7ppf4zEB3j6da1IBRTz2yOZ+6O1TMZxol/V62/QcqrJeggsHTEPGLdr9Ua4b1Ka0xKJnJngZljsbw93FI1o+P9dAh5BS6wTPiZI/vmJVjvMTkSTnaZ3n9Go2t7A0XLcSxLcVyuLAd2mAvSN0mIviOukdM66wr7llif71nKuUt+4qvlr/r9HfwzN6pA4jkwhtS1UD+3CmB+wsHwsnohNcuu4FIQ6rgq/7QIDAQAB",
-  "name": "Testing Provider",
+  "name": "Files Testing Provider test extension",
   "version": "0.1",
   "manifest_version": 2,
   "description": "Testing Provider",

ui/file_manager/integration_tests/testing_provider/manifest_multiple_mounts.json

 {
   // chrome-extension://pkplfbidichfdicaijlchgnapepdginl
   "key": "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAtDfX9dHNh948bt00YhZBm3P6E5QLaOt+v8kXVtibQfiPtOD2FTScB/f0wX/EQWVO7BkaSOsRkTPcPIgocyMPYr2FLgqGLFlYT9nQpKJZUFNF5oJ5rG6Nv7ppf4zEB3j6da1IBRTz2yOZ+6O1TMZxol/V62/QcqrJeggsHTEPGLdr9Ua4b1Ka0xKJnJngZljsbw93FI1o+P9dAh5BS6wTPiZI/vmJVjvMTkSTnaZ3n9Go2t7A0XLcSxLcVyuLAd2mAvSN0mIviOukdM66wr7llif71nKuUt+4qvlr/r9HfwzN6pA4jkwhtS1UD+3CmB+wsHwsnohNcuu4FIQ6rgq/7QIDAQAB",
-  "name": "Testing Provider",
+  "name": "Files Testing Provider multiple mounts test extension",
   "version": "0.1",
   "manifest_version": 2,
-  "description": "Testing Provider",
+  "description": "Testing Provider multiple mounts",
   "permissions": [
     "fileSystemProvider"
   ],

ui/file_manager/integration_tests/testing_provider/manifest_source_device.json

 {
   // chrome-extension://pkplfbidichfdicaijlchgnapepdginl
   "key": "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAtDfX9dHNh948bt00YhZBm3P6E5QLaOt+v8kXVtibQfiPtOD2FTScB/f0wX/EQWVO7BkaSOsRkTPcPIgocyMPYr2FLgqGLFlYT9nQpKJZUFNF5oJ5rG6Nv7ppf4zEB3j6da1IBRTz2yOZ+6O1TMZxol/V62/QcqrJeggsHTEPGLdr9Ua4b1Ka0xKJnJngZljsbw93FI1o+P9dAh5BS6wTPiZI/vmJVjvMTkSTnaZ3n9Go2t7A0XLcSxLcVyuLAd2mAvSN0mIviOukdM66wr7llif71nKuUt+4qvlr/r9HfwzN6pA4jkwhtS1UD+3CmB+wsHwsnohNcuu4FIQ6rgq/7QIDAQAB",
-  "name": "Testing Provider Device",
+  "name": "Files Testing Provider device test extension",
   "version": "0.1",
   "manifest_version": 2,
-  "description": "Testing Provider",
+  "description": "Testing Provider device",
   "permissions": [
     "fileSystemProvider"
   ],

ui/file_manager/integration_tests/testing_provider/manifest_source_file.json

 {
   // chrome-extension://pkplfbidichfdicaijlchgnapepdginl
   "key": "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAtDfX9dHNh948bt00YhZBm3P6E5QLaOt+v8kXVtibQfiPtOD2FTScB/f0wX/EQWVO7BkaSOsRkTPcPIgocyMPYr2FLgqGLFlYT9nQpKJZUFNF5oJ5rG6Nv7ppf4zEB3j6da1IBRTz2yOZ+6O1TMZxol/V62/QcqrJeggsHTEPGLdr9Ua4b1Ka0xKJnJngZljsbw93FI1o+P9dAh5BS6wTPiZI/vmJVjvMTkSTnaZ3n9Go2t7A0XLcSxLcVyuLAd2mAvSN0mIviOukdM66wr7llif71nKuUt+4qvlr/r9HfwzN6pA4jkwhtS1UD+3CmB+wsHwsnohNcuu4FIQ6rgq/7QIDAQAB",
-  "name": "Testing Provider File",
+  "name": "Files Testing Provider file test extension",
   "version": "0.1",
   "manifest_version": 2,
-  "description": "Testing Provider",
+  "description": "Testing Provider file",
   "permissions": [
     "fileSystemProvider"
   ],

ui/file_manager/integration_tests/video_player_test_manifest.json

 {
   // chrome-extension://ljoplibgfehghmibaoaepfagnmbbfiga
   "key": "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAvT+IcKSOCmrC9IOpAGaNaUX2pbJSJchiYUuE9YilghsxGTWA8nC34k5/+BycWnBOEUow2pQmTRHuxt9E/CBzH15ah7NmikclL6UsoRgDb0Sj3zmhVNLXWX2jbFnECjTBPPbASj8Xnf20n6HNX3Yp9nnAJKzk5d/xzSgFz8uL9defwlZQB7t0E28+3DD9IoOWkEJWz6FRzhiY07TC2n6tjo0CPS150x1jEHyZF2oVLn8Cus28hBkoZ70GPWB6BQCxzGLcYWUJ6EKgE4iO9tcSDC2MMvA++n18JMb1APtxH3MIqQyGE/2cydjxEhhNLiD5Mp4tYHKObGWFefKQ0WlmEwIDAQAB",
-  "name": "chrome os video player browser tests",
+  "name": "Video Player test extension",
   "version": "0.1",
   "manifest_version": 2,
   "web_accessible_resources": ["*"],