[Password Manager] Add flag for password selector and eye icon

Bug: 753806
Change-Id: I9c735122920dbc20a543125d9fa3fd0dc076845a
Reviewed-on: https://chromium-review.googlesource.com/672823Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502932}

chrome/browser/about_flags.cc

@@ -3490,6 +3490,10 @@ const FeatureEntry kFeatureEntries[] = {
      flag_descriptions::kParallelDownloadingDescription, kOsAll,
      FEATURE_VALUE_TYPE(features::kParallelDownloading)},
 
+    {"enable-password-selection", flag_descriptions::kPasswordSelectionName,
+     flag_descriptions::kPasswordSelectionDescription, kOsDesktop,
+     FEATURE_VALUE_TYPE(password_manager::features::kEnablePasswordSelection)},
+
     // NOTE: Adding new command-line switches requires adding corresponding
     // entries to enum "LoginCustomFlags" in histograms/enums.xml. See note in
     // enums.xml and don't forget to run AboutFlagsHistogramTest unit test.

chrome/browser/flag_descriptions.cc

@@ -1031,6 +1031,11 @@ const char kPasswordImportExportName[] = "Password import and export";
 const char kPasswordImportExportDescription[] =
     "Import and Export functionality in password settings.";
 
+const char kPasswordSelectionName[] =
+    "Password selection and eye icon in prompt";
+const char kPasswordSelectionDescription[] =
+    "Show a password selector and an eye icon in prompt";
+
 const char kPermissionActionReportingName[] = "Permission Action Reporting";
 const char kPermissionActionReportingDescription[] =
     "Enables permission action reporting to Safe Browsing servers for opted in "

chrome/browser/flag_descriptions.h

@@ -640,6 +640,9 @@ extern const char kPasswordGenerationDescription[];
 extern const char kPasswordImportExportName[];
 extern const char kPasswordImportExportDescription[];
 
+extern const char kPasswordSelectionName[];
+extern const char kPasswordSelectionDescription[];
+
 extern const char kPermissionActionReportingName[];
 extern const char kPermissionActionReportingDescription[];
 

tools/metrics/histograms/enums.xml

@@ -24305,6 +24305,7 @@ from previous Chrome versions.
   <int value="1514119870" label="enable-file-manager-touch-mode"/>
   <int value="1515196403" label="fast-user-switching"/>
   <int value="1517863401" label="history-entry-requires-user-gesture"/>
+  <int value="1529979182" label="EnablePasswordSelection:enabled"/>
   <int value="1533111748" label="Multidevice:enabled"/>
   <int value="1538690515" label="OneGoogleBarOnLocalNtp:enabled"/>
   <int value="1541723759" label="ServiceWorkerNavigationPreload:disabled"/>
@@ -24351,6 +24352,7 @@ from previous Chrome versions.
   <int value="1713230497" label="ColorCorrectRendering:disabled"/>
   <int value="1716104463" label="enable-fullscreen-app-list"/>
   <int value="1717987538" label="NTPTilesLowerResolutionFavicons:enabled"/>
+  <int value="1719189460" label="EnablePasswordSelection:disabled"/>
   <int value="1723601083" label="enable-app-window-controls"/>
   <int value="1724800383" label="AsmJsToWebAssembly:disabled"/>
   <int value="1730094138" label="enable-md-storage-manager"/>