Commit d98630f8 authored by Yuki Shiino's avatar Yuki Shiino Committed by Commit Bot

v8binding: Removes dead code (call_with_this_handle).

[CallWith=ThisValue] is obsolete from the beginning and only used at
Location's valueOf(), which must be implemented in the way of
https://html.spec.whatwg.org/multipage/history.html#the-location-interface

No need to support it in IDL callback interface, and it's actually not
supported now.

Change-Id: I3546f78a68fb2b335950d3848b6c4b51628cc505
Reviewed-on: https://chromium-review.googlesource.com/1025153Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553070}
parent ef95594f
......@@ -147,20 +147,16 @@ def method_context(operation):
if idl_type_str not in ['boolean', 'void']:
raise Exception('We only support callbacks that return boolean or void values.')
add_includes_for_operation(operation)
call_with = extended_attributes.get('CallWith')
call_with_this_handle = v8_utilities.extended_attribute_value_contains(call_with, 'ThisValue')
context = {
'call_with_this_handle': call_with_this_handle,
'cpp_type': idl_type.callback_cpp_type,
'idl_type': idl_type_str,
'name': operation.name,
}
context.update(arguments_context(operation.arguments,
call_with_this_handle))
context.update(arguments_context(operation.arguments))
return context
def arguments_context(arguments, call_with_this_handle):
def arguments_context(arguments):
def argument_context(argument):
return {
'cpp_value_to_v8_value': argument.idl_type.cpp_value_to_v8_value(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment