Commit d9ba67a8 authored by avi's avatar avi Committed by Commit bot

Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2844413004
Cr-Commit-Position: refs/heads/master@{#468005}
parent 3ed8a8e7
...@@ -4,6 +4,7 @@ ...@@ -4,6 +4,7 @@
#include "chromecast/browser/android/cast_web_contents_activity.h" #include "chromecast/browser/android/cast_web_contents_activity.h"
#include "base/memory/ptr_util.h"
#include "content/public/browser/web_contents.h" #include "content/public/browser/web_contents.h"
#include "jni/CastWebContentsActivity_jni.h" #include "jni/CastWebContentsActivity_jni.h"
...@@ -46,7 +47,8 @@ CastWebContentsActivity* CastWebContentsActivity::Get( ...@@ -46,7 +47,8 @@ CastWebContentsActivity* CastWebContentsActivity::Get(
web_contents->GetUserData(kCastWebContentsActivityKey)); web_contents->GetUserData(kCastWebContentsActivityKey));
if (!instance) { if (!instance) {
instance = new CastWebContentsActivity(web_contents); instance = new CastWebContentsActivity(web_contents);
web_contents->SetUserData(kCastWebContentsActivityKey, instance); web_contents->SetUserData(kCastWebContentsActivityKey,
base::WrapUnique(instance));
} }
return instance; return instance;
} }
......
...@@ -21,8 +21,10 @@ namespace shell { ...@@ -21,8 +21,10 @@ namespace shell {
// Helper class to get members of the CastWebContentsActivity displaying a // Helper class to get members of the CastWebContentsActivity displaying a
// given web_contents. This class is lazily created through the Get function and // given web_contents. This class is lazily created through the Get function and
// will manage its own lifetime via SupportsUserData. // will manage its own lifetime via SupportsUserData.
class CastWebContentsActivity : base::SupportsUserData::Data { class CastWebContentsActivity : public base::SupportsUserData::Data {
public: public:
~CastWebContentsActivity() override;
static bool RegisterJni(JNIEnv* env); static bool RegisterJni(JNIEnv* env);
static CastWebContentsActivity* Get(content::WebContents* web_contents); static CastWebContentsActivity* Get(content::WebContents* web_contents);
...@@ -32,7 +34,6 @@ class CastWebContentsActivity : base::SupportsUserData::Data { ...@@ -32,7 +34,6 @@ class CastWebContentsActivity : base::SupportsUserData::Data {
private: private:
explicit CastWebContentsActivity(content::WebContents* web_contents); explicit CastWebContentsActivity(content::WebContents* web_contents);
~CastWebContentsActivity() override;
base::android::ScopedJavaGlobalRef<jobject> content_video_view_embedder_; base::android::ScopedJavaGlobalRef<jobject> content_video_view_embedder_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment