Commit db9c8460 authored by Fady Samuel's avatar Fady Samuel Committed by Commit Bot

Surface synchronization: Fix RWHVChildFrame tear down crash

During tear down, surfaces will be garbage collected which may force
other surfaces to activate. However, during tear down, a
RenderWidgetHostViewChildFrame may no longer have a CrossProcessFrameConnector
and so it cannot send the new SurfaceInfo anywhere. If RWHVChildFrame does
not have a CPFC then we should just simply drop the SurfaceInfo.

Bug: 797801
Change-Id: I4b22af61ebc786dcc285311512cbc81bb570ba74
Reviewed-on: https://chromium-review.googlesource.com/849132Reviewed-by: default avatarkylechar <kylechar@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526730}
parent 9fc32d6f
......@@ -605,7 +605,8 @@ void RenderWidgetHostViewChildFrame::SendSurfaceInfoToEmbedder() {
void RenderWidgetHostViewChildFrame::SendSurfaceInfoToEmbedderImpl(
const viz::SurfaceInfo& surface_info,
const viz::SurfaceSequence& sequence) {
frame_connector_->SetChildFrameSurface(surface_info, sequence);
if (frame_connector_)
frame_connector_->SetChildFrameSurface(surface_info, sequence);
}
void RenderWidgetHostViewChildFrame::SubmitCompositorFrame(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment