Commit dbeb3357 authored by Adithya Srinivasan's avatar Adithya Srinivasan Committed by Commit Bot

Change WorkerThread::time_origin_ to use base::TimeTicks

Using double to represent time is error prone as the units are unclear.

Change-Id: Id3a6ce23e684643f424dcbc84e2cca708faeda3c
Reviewed-on: https://chromium-review.googlesource.com/1115904Reviewed-by: default avatarJeremy Roman <jbroman@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570879}
parent abc13a1c
...@@ -41,7 +41,7 @@ ...@@ -41,7 +41,7 @@
namespace blink { namespace blink {
WorkerPerformance::WorkerPerformance(WorkerGlobalScope* context) WorkerPerformance::WorkerPerformance(WorkerGlobalScope* context)
: Performance(TimeTicksFromSeconds(context->TimeOrigin()), : Performance(context->TimeOrigin(),
context->GetTaskRunner(TaskType::kPerformanceTimeline)), context->GetTaskRunner(TaskType::kPerformanceTimeline)),
execution_context_(context) {} execution_context_(context) {}
......
...@@ -52,7 +52,7 @@ namespace blink { ...@@ -52,7 +52,7 @@ namespace blink {
DedicatedWorkerGlobalScope::DedicatedWorkerGlobalScope( DedicatedWorkerGlobalScope::DedicatedWorkerGlobalScope(
std::unique_ptr<GlobalScopeCreationParams> creation_params, std::unique_ptr<GlobalScopeCreationParams> creation_params,
DedicatedWorkerThread* thread, DedicatedWorkerThread* thread,
double time_origin) base::TimeTicks time_origin)
: WorkerGlobalScope(std::move(creation_params), thread, time_origin) {} : WorkerGlobalScope(std::move(creation_params), thread, time_origin) {}
DedicatedWorkerGlobalScope::~DedicatedWorkerGlobalScope() = default; DedicatedWorkerGlobalScope::~DedicatedWorkerGlobalScope() = default;
......
...@@ -50,7 +50,7 @@ class CORE_EXPORT DedicatedWorkerGlobalScope final : public WorkerGlobalScope { ...@@ -50,7 +50,7 @@ class CORE_EXPORT DedicatedWorkerGlobalScope final : public WorkerGlobalScope {
public: public:
DedicatedWorkerGlobalScope(std::unique_ptr<GlobalScopeCreationParams>, DedicatedWorkerGlobalScope(std::unique_ptr<GlobalScopeCreationParams>,
DedicatedWorkerThread*, DedicatedWorkerThread*,
double time_origin); base::TimeTicks time_origin);
~DedicatedWorkerGlobalScope() override; ~DedicatedWorkerGlobalScope() override;
bool IsDedicatedWorkerGlobalScope() const override { return true; } bool IsDedicatedWorkerGlobalScope() const override { return true; }
......
...@@ -52,7 +52,7 @@ SharedWorkerGlobalScope::SharedWorkerGlobalScope( ...@@ -52,7 +52,7 @@ SharedWorkerGlobalScope::SharedWorkerGlobalScope(
const String& name, const String& name,
std::unique_ptr<GlobalScopeCreationParams> creation_params, std::unique_ptr<GlobalScopeCreationParams> creation_params,
SharedWorkerThread* thread, SharedWorkerThread* thread,
double time_origin) base::TimeTicks time_origin)
: WorkerGlobalScope(std::move(creation_params), thread, time_origin), : WorkerGlobalScope(std::move(creation_params), thread, time_origin),
name_(name) {} name_(name) {}
......
...@@ -49,7 +49,7 @@ class SharedWorkerGlobalScope final : public WorkerGlobalScope { ...@@ -49,7 +49,7 @@ class SharedWorkerGlobalScope final : public WorkerGlobalScope {
SharedWorkerGlobalScope(const String& name, SharedWorkerGlobalScope(const String& name,
std::unique_ptr<GlobalScopeCreationParams>, std::unique_ptr<GlobalScopeCreationParams>,
SharedWorkerThread*, SharedWorkerThread*,
double time_origin); base::TimeTicks time_origin);
~SharedWorkerGlobalScope() override; ~SharedWorkerGlobalScope() override;
bool IsSharedWorkerGlobalScope() const override { return true; } bool IsSharedWorkerGlobalScope() const override { return true; }
......
...@@ -329,7 +329,7 @@ void WorkerGlobalScope::EvaluateClassicScript( ...@@ -329,7 +329,7 @@ void WorkerGlobalScope::EvaluateClassicScript(
WorkerGlobalScope::WorkerGlobalScope( WorkerGlobalScope::WorkerGlobalScope(
std::unique_ptr<GlobalScopeCreationParams> creation_params, std::unique_ptr<GlobalScopeCreationParams> creation_params,
WorkerThread* thread, WorkerThread* thread,
double time_origin) base::TimeTicks time_origin)
: WorkerOrWorkletGlobalScope(thread->GetIsolate(), : WorkerOrWorkletGlobalScope(thread->GetIsolate(),
creation_params->worker_clients, creation_params->worker_clients,
thread->GetWorkerReportingProxy()), thread->GetWorkerReportingProxy()),
......
...@@ -141,7 +141,7 @@ class CORE_EXPORT WorkerGlobalScope ...@@ -141,7 +141,7 @@ class CORE_EXPORT WorkerGlobalScope
const FetchClientSettingsObjectSnapshot& outside_settings_object, const FetchClientSettingsObjectSnapshot& outside_settings_object,
network::mojom::FetchCredentialsMode) = 0; network::mojom::FetchCredentialsMode) = 0;
double TimeOrigin() const { return time_origin_; } base::TimeTicks TimeOrigin() const { return time_origin_; }
WorkerSettings* GetWorkerSettings() const { return worker_settings_.get(); } WorkerSettings* GetWorkerSettings() const { return worker_settings_.get(); }
void Trace(blink::Visitor*) override; void Trace(blink::Visitor*) override;
...@@ -160,7 +160,7 @@ class CORE_EXPORT WorkerGlobalScope ...@@ -160,7 +160,7 @@ class CORE_EXPORT WorkerGlobalScope
protected: protected:
WorkerGlobalScope(std::unique_ptr<GlobalScopeCreationParams>, WorkerGlobalScope(std::unique_ptr<GlobalScopeCreationParams>,
WorkerThread*, WorkerThread*,
double time_origin); base::TimeTicks time_origin);
void ApplyContentSecurityPolicyFromHeaders( void ApplyContentSecurityPolicyFromHeaders(
const ContentSecurityPolicyResponseHeaders&); const ContentSecurityPolicyResponseHeaders&);
...@@ -217,7 +217,7 @@ class CORE_EXPORT WorkerGlobalScope ...@@ -217,7 +217,7 @@ class CORE_EXPORT WorkerGlobalScope
DOMTimerCoordinator timers_; DOMTimerCoordinator timers_;
const double time_origin_; const base::TimeTicks time_origin_;
HeapHashMap<int, Member<ErrorEvent>> pending_error_events_; HeapHashMap<int, Member<ErrorEvent>> pending_error_events_;
int last_pending_error_event_id_ = 0; int last_pending_error_event_id_ = 0;
......
...@@ -353,7 +353,7 @@ void WorkerThread::ChildThreadTerminatedOnWorkerThread(WorkerThread* child) { ...@@ -353,7 +353,7 @@ void WorkerThread::ChildThreadTerminatedOnWorkerThread(WorkerThread* child) {
WorkerThread::WorkerThread(ThreadableLoadingContext* loading_context, WorkerThread::WorkerThread(ThreadableLoadingContext* loading_context,
WorkerReportingProxy& worker_reporting_proxy) WorkerReportingProxy& worker_reporting_proxy)
: time_origin_(CurrentTimeTicksInSeconds()), : time_origin_(CurrentTimeTicks()),
worker_thread_id_(GetNextWorkerThreadId()), worker_thread_id_(GetNextWorkerThreadId()),
forcible_termination_delay_(kForcibleTerminationDelay), forcible_termination_delay_(kForcibleTerminationDelay),
devtools_worker_token_(base::UnguessableToken::Create()), devtools_worker_token_(base::UnguessableToken::Create()),
......
...@@ -227,7 +227,7 @@ class CORE_EXPORT WorkerThread : public WebThread::TaskObserver { ...@@ -227,7 +227,7 @@ class CORE_EXPORT WorkerThread : public WebThread::TaskObserver {
// Official moment of creation of worker: when the worker thread is created. // Official moment of creation of worker: when the worker thread is created.
// (https://w3c.github.io/hr-time/#time-origin) // (https://w3c.github.io/hr-time/#time-origin)
const double time_origin_; const base::TimeTicks time_origin_;
private: private:
friend class WorkerThreadTest; friend class WorkerThreadTest;
......
...@@ -63,7 +63,7 @@ class FakeWorkerGlobalScope : public WorkerGlobalScope { ...@@ -63,7 +63,7 @@ class FakeWorkerGlobalScope : public WorkerGlobalScope {
WorkerThread* thread) WorkerThread* thread)
: WorkerGlobalScope(std::move(creation_params), : WorkerGlobalScope(std::move(creation_params),
thread, thread,
CurrentTimeTicksInSeconds()) {} CurrentTimeTicks()) {}
~FakeWorkerGlobalScope() override = default; ~FakeWorkerGlobalScope() override = default;
......
...@@ -75,7 +75,7 @@ namespace blink { ...@@ -75,7 +75,7 @@ namespace blink {
ServiceWorkerGlobalScope* ServiceWorkerGlobalScope::Create( ServiceWorkerGlobalScope* ServiceWorkerGlobalScope::Create(
ServiceWorkerThread* thread, ServiceWorkerThread* thread,
std::unique_ptr<GlobalScopeCreationParams> creation_params, std::unique_ptr<GlobalScopeCreationParams> creation_params,
double time_origin) { base::TimeTicks time_origin) {
// If the script is being loaded via script streaming, the script is not yet // If the script is being loaded via script streaming, the script is not yet
// loaded. // loaded.
if (thread->GetInstalledScriptsManager() && if (thread->GetInstalledScriptsManager() &&
...@@ -94,7 +94,7 @@ ServiceWorkerGlobalScope* ServiceWorkerGlobalScope::Create( ...@@ -94,7 +94,7 @@ ServiceWorkerGlobalScope* ServiceWorkerGlobalScope::Create(
ServiceWorkerGlobalScope::ServiceWorkerGlobalScope( ServiceWorkerGlobalScope::ServiceWorkerGlobalScope(
std::unique_ptr<GlobalScopeCreationParams> creation_params, std::unique_ptr<GlobalScopeCreationParams> creation_params,
ServiceWorkerThread* thread, ServiceWorkerThread* thread,
double time_origin) base::TimeTicks time_origin)
: WorkerGlobalScope(std::move(creation_params), thread, time_origin) {} : WorkerGlobalScope(std::move(creation_params), thread, time_origin) {}
ServiceWorkerGlobalScope::~ServiceWorkerGlobalScope() = default; ServiceWorkerGlobalScope::~ServiceWorkerGlobalScope() = default;
......
...@@ -60,7 +60,7 @@ class MODULES_EXPORT ServiceWorkerGlobalScope final : public WorkerGlobalScope { ...@@ -60,7 +60,7 @@ class MODULES_EXPORT ServiceWorkerGlobalScope final : public WorkerGlobalScope {
static ServiceWorkerGlobalScope* Create( static ServiceWorkerGlobalScope* Create(
ServiceWorkerThread*, ServiceWorkerThread*,
std::unique_ptr<GlobalScopeCreationParams>, std::unique_ptr<GlobalScopeCreationParams>,
double time_origin); base::TimeTicks time_origin);
~ServiceWorkerGlobalScope() override; ~ServiceWorkerGlobalScope() override;
bool IsServiceWorkerGlobalScope() const override { return true; } bool IsServiceWorkerGlobalScope() const override { return true; }
...@@ -134,7 +134,7 @@ class MODULES_EXPORT ServiceWorkerGlobalScope final : public WorkerGlobalScope { ...@@ -134,7 +134,7 @@ class MODULES_EXPORT ServiceWorkerGlobalScope final : public WorkerGlobalScope {
private: private:
ServiceWorkerGlobalScope(std::unique_ptr<GlobalScopeCreationParams>, ServiceWorkerGlobalScope(std::unique_ptr<GlobalScopeCreationParams>,
ServiceWorkerThread*, ServiceWorkerThread*,
double time_origin); base::TimeTicks time_origin);
void importScripts(const Vector<String>& urls, ExceptionState&) override; void importScripts(const Vector<String>& urls, ExceptionState&) override;
SingleCachedMetadataHandler* CreateWorkerScriptCachedMetadataHandler( SingleCachedMetadataHandler* CreateWorkerScriptCachedMetadataHandler(
const KURL& script_url, const KURL& script_url,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment