Commit dd3c04fc authored by erikchen's avatar erikchen Committed by Commit Bot

macOS: Disable UI updates during popup-menu fade out.

There's a large memory leak on macOS of CATransaction continuations.
There appears to be correlation with PopupMenus, and it begins in
approximately the date range the CL that introduced this functionality
was added.

Bug: 853438
Change-Id: I7f9b63584e6990f1ee87b4d33a5b8405f81efdb9
Reviewed-on: https://chromium-review.googlesource.com/1117608Reviewed-by: default avatarTrent Apted <tapted@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571015}
parent 80336320
...@@ -88,7 +88,10 @@ void PopupMenuHelper::ShowPopupMenu( ...@@ -88,7 +88,10 @@ void PopupMenuHelper::ShowPopupMenu(
base::mac::ScopedSendingEvent sending_event_scoper; base::mac::ScopedSendingEvent sending_event_scoper;
// Ensure the UI can update while the menu is fading out. // Ensure the UI can update while the menu is fading out.
pump_in_fade_ = std::make_unique<base::ScopedPumpMessagesInPrivateModes>(); // TODO(erikchen): Temporarily disabled as potential cause of memory leak of
// CATransaction continuations. See https://crbug.com/853438.
// pump_in_fade_ =
// std::make_unique<base::ScopedPumpMessagesInPrivateModes>();
// Now run a NESTED EVENT LOOP until the pop-up is finished. // Now run a NESTED EVENT LOOP until the pop-up is finished.
[runner runMenuInView:cocoa_view [runner runMenuInView:cocoa_view
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment