Commit ddb5625c authored by tzik@chromium.org's avatar tzik@chromium.org

[SyncFS] Crash fix on chrome://syncfs-internals

BUG=401906

Review URL: https://codereview.chromium.org/452063002

Cr-Commit-Position: refs/heads/master@{#288351}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288351 0039d316-1c4b-4281-b951-d872f2087c98
parent e44b9f4c
...@@ -548,7 +548,8 @@ void SyncFileSystemService::DidDumpV2Database( ...@@ -548,7 +548,8 @@ void SyncFileSystemService::DidDumpV2Database(
const DumpFilesCallback& callback, const DumpFilesCallback& callback,
scoped_ptr<base::ListValue> v1list, scoped_ptr<base::ListValue> v1list,
scoped_ptr<base::ListValue> v2list) { scoped_ptr<base::ListValue> v2list) {
DCHECK(v1list); if (!v1list)
v1list = make_scoped_ptr(new base::ListValue);
if (v2list) { if (v2list) {
for (base::ListValue::iterator itr = v2list->begin(); for (base::ListValue::iterator itr = v2list->begin();
...@@ -565,6 +566,8 @@ void SyncFileSystemService::DidDumpV2Database( ...@@ -565,6 +566,8 @@ void SyncFileSystemService::DidDumpV2Database(
void SyncFileSystemService::DidGetExtensionStatusMap( void SyncFileSystemService::DidGetExtensionStatusMap(
const ExtensionStatusMapCallback& callback, const ExtensionStatusMapCallback& callback,
scoped_ptr<RemoteFileSyncService::OriginStatusMap> status_map) { scoped_ptr<RemoteFileSyncService::OriginStatusMap> status_map) {
if (!status_map)
status_map = make_scoped_ptr(new RemoteFileSyncService::OriginStatusMap);
if (!v2_remote_service_) { if (!v2_remote_service_) {
callback.Run(*status_map); callback.Run(*status_map);
return; return;
...@@ -582,6 +585,9 @@ void SyncFileSystemService::DidGetV2ExtensionStatusMap( ...@@ -582,6 +585,9 @@ void SyncFileSystemService::DidGetV2ExtensionStatusMap(
scoped_ptr<RemoteFileSyncService::OriginStatusMap> status_map_v1, scoped_ptr<RemoteFileSyncService::OriginStatusMap> status_map_v1,
scoped_ptr<RemoteFileSyncService::OriginStatusMap> status_map_v2) { scoped_ptr<RemoteFileSyncService::OriginStatusMap> status_map_v2) {
// Merge |status_map_v2| into |status_map_v1|. // Merge |status_map_v2| into |status_map_v1|.
if (!status_map_v1)
status_map_v1 = make_scoped_ptr(new RemoteFileSyncService::OriginStatusMap);
if (status_map_v2)
status_map_v1->insert(status_map_v2->begin(), status_map_v2->end()); status_map_v1->insert(status_map_v2->begin(), status_map_v2->end());
callback.Run(*status_map_v1); callback.Run(*status_map_v1);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment