[Narrator] Fix VK show after narrator sets focus
Before this change we used to set the pointer type to touch only when DoDefaultAction was called. This led to issues as sometimes I don't see this API being called when narrator is active and the user double taps on the edit control to set the selection. VK should show up when caret starts blinking in the edit control, so we set the pointer type to touch when we receive focus from the narrator and then in blink we invoke a call to show the VK if the focus happened to be inside an edit control. FWIW, I discussed this with narrator team and it is hard to come up with a solution that is deterministic and reliable as narrator eats up all the gesture events and VK is controlled by a different component that relies on VK show call from Chromium when input modality is touch and input policy is set as manual(Chromium specific). This solution is just a heuristic. Bug: 1106556 Change-Id: I12fcfcda52ba058ed5377b0312e6652988dacced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361045Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#799384}
Showing
Please register or sign in to comment