GitLab

Simplify RuntimeFeatureEnableOptions

- Combine kEnableOnly into kDefault. The difference between them
  was that kDefault respects field trial settings and both
  --enable-feature and --disable-feature, while kEnableOnly didn't
  respect the disabled status of field trial and --disable-feature.
  This doesn't affect the default status of the features.

  35 features are changed from kEnableOnly to kDefault.

- If applicable, use kDefault for features that used kDisableOnly.
  The difference between kDisableOnly and kDefault was similar to
  the above, but for enabled status of field trial and
  --enable-features. All of the changed features are already enabled
  by default in Chromium and have status:"stable" in Blink, so the
  change doesn't affect the default status of the features.

  The following features are changed from kDisableOnly to kDefault:
    WebUsb, BackgroundFetch, InstallApp, BlockCredentialedSubresources.

- Remove kDisableOnly and kEnableOnlyIfOverriddenFromCommandLine,
  and add kSetOnlyIfOverridden for origin trial features that require
  the Chromium feature to be enabled by default and the blink feature to
  be controlled by origin trials, or for features that are enabled by
  default in Chromium but not in Blink.

  The following features are changed to kSetOnlyIfOverridden:
    NotificationContentImage, Portals, IdleDetection, SmsReceiver,
    WebNfc.

Bug: 1048656
Change-Id: Ifa3e590773212411097d07233b68b3c7a199a54f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419579
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809517}