Commit de99afb4 authored by Vaclav Brozek's avatar Vaclav Brozek Committed by Commit Bot

No DB thread in IOSChromePasswordStoreFactory any more

This CL removes the DB thread reference from IOSChromePasswordStoreFactory and
replaces it with an appropriate CreateSequencedTaskRunnerWithTraits call.

Bug: 689520
Change-Id: I19c7a6473f7d26ce192005e25b297c878716bee5
Reviewed-on: https://chromium-review.googlesource.com/567984Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486001}
parent 331c8e96
...@@ -10,6 +10,7 @@ ...@@ -10,6 +10,7 @@
#include "base/command_line.h" #include "base/command_line.h"
#include "base/memory/singleton.h" #include "base/memory/singleton.h"
#include "base/sequenced_task_runner.h" #include "base/sequenced_task_runner.h"
#include "base/task_scheduler/post_task.h"
#include "base/threading/sequenced_task_runner_handle.h" #include "base/threading/sequenced_task_runner_handle.h"
#include "components/browser_sync/profile_sync_service.h" #include "components/browser_sync/profile_sync_service.h"
#include "components/keyed_service/core/service_access_type.h" #include "components/keyed_service/core/service_access_type.h"
...@@ -26,7 +27,6 @@ ...@@ -26,7 +27,6 @@
#include "ios/chrome/browser/sync/glue/sync_start_util.h" #include "ios/chrome/browser/sync/glue/sync_start_util.h"
#include "ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.h" #include "ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.h"
#include "ios/chrome/browser/web_data_service_factory.h" #include "ios/chrome/browser/web_data_service_factory.h"
#include "ios/web/public/web_thread.h"
// static // static
scoped_refptr<password_manager::PasswordStore> scoped_refptr<password_manager::PasswordStore>
...@@ -80,8 +80,14 @@ IOSChromePasswordStoreFactory::BuildServiceInstanceFor( ...@@ -80,8 +80,14 @@ IOSChromePasswordStoreFactory::BuildServiceInstanceFor(
scoped_refptr<base::SequencedTaskRunner> main_thread_runner( scoped_refptr<base::SequencedTaskRunner> main_thread_runner(
base::SequencedTaskRunnerHandle::Get()); base::SequencedTaskRunnerHandle::Get());
// USER_VISIBLE priority is chosen for the background task runner, because
// the passwords obtained through tasks on the background runner influence
// what the user sees.
// TODO(crbug.com/741660): Create the task runner inside password_manager
// component instead.
scoped_refptr<base::SequencedTaskRunner> db_thread_runner( scoped_refptr<base::SequencedTaskRunner> db_thread_runner(
web::WebThread::GetTaskRunnerForThread(web::WebThread::DB)); base::CreateSequencedTaskRunnerWithTraits(
{base::MayBlock(), base::TaskPriority::USER_VISIBLE}));
scoped_refptr<password_manager::PasswordStore> store = scoped_refptr<password_manager::PasswordStore> store =
new password_manager::PasswordStoreDefault( new password_manager::PasswordStoreDefault(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment