Commit dea06809 authored by Marina Ciocea's avatar Marina Ciocea Committed by Commit Bot

Disable NetworkServiceRestartBrowserTests on chromium.memory/Linux TSan Tests.

Disabled tests:
NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_RespondWithFetch
NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_PassThrough
NetworkServiceRestartBrowserTest.FetchFromServiceWorkerControlledPage_NoFetchHandler

TBR=shimazu@chromium.org

Bug: 889855
Change-Id: I7215b4e074da8932725a2d6540cccf29eea823a3
Reviewed-on: https://chromium-review.googlesource.com/1249083Reviewed-by: default avatarMarina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594719}
parent 58171a8d
...@@ -624,10 +624,19 @@ IN_PROC_BROWSER_TEST_F(NetworkServiceRestartBrowserTest, MultipleWorkerFetch) { ...@@ -624,10 +624,19 @@ IN_PROC_BROWSER_TEST_F(NetworkServiceRestartBrowserTest, MultipleWorkerFetch) {
EXPECT_EQ(last_request_relative_url(), "/title2.html"); EXPECT_EQ(last_request_relative_url(), "/title2.html");
} }
// Flaky on Linux TSan (https://crbug.com/889855)
#if defined(OS_LINUX) && defined(THREAD_SANITIZER)
#define MAYBE_FetchFromServiceWorkerControlledPage_NoFetchHandler \
DISABLED_FetchFromServiceWorkerControlledPage_NoFetchHandler
#else
#define MAYBE_FetchFromServiceWorkerControlledPage_NoFetchHandler \
FetchFromServiceWorkerControlledPage_NoFetchHandler
#endif
// Make sure fetch from a page controlled by a service worker which doesn't have // Make sure fetch from a page controlled by a service worker which doesn't have
// a fetch handler works after crash. // a fetch handler works after crash.
IN_PROC_BROWSER_TEST_F(NetworkServiceRestartBrowserTest, IN_PROC_BROWSER_TEST_F(
FetchFromServiceWorkerControlledPage_NoFetchHandler) { NetworkServiceRestartBrowserTest,
MAYBE_FetchFromServiceWorkerControlledPage_NoFetchHandler) {
StoragePartitionImpl* partition = static_cast<StoragePartitionImpl*>( StoragePartitionImpl* partition = static_cast<StoragePartitionImpl*>(
BrowserContext::GetDefaultStoragePartition(browser_context())); BrowserContext::GetDefaultStoragePartition(browser_context()));
ServiceWorkerStatusObserver observer; ServiceWorkerStatusObserver observer;
...@@ -665,10 +674,18 @@ IN_PROC_BROWSER_TEST_F(NetworkServiceRestartBrowserTest, ...@@ -665,10 +674,18 @@ IN_PROC_BROWSER_TEST_F(NetworkServiceRestartBrowserTest,
service_worker_context->RemoveObserver(&observer); service_worker_context->RemoveObserver(&observer);
} }
// Flaky on Linux TSan (https://crbug.com/889855)
#if defined(OS_LINUX) && defined(THREAD_SANITIZER)
#define MAYBE_FetchFromServiceWorkerControlledPage_PassThrough \
DISABLED_FetchFromServiceWorkerControlledPage_PassThrough
#else
#define MAYBE_FetchFromServiceWorkerControlledPage_PassThrough \
FetchFromServiceWorkerControlledPage_PassThrough
#endif
// Make sure fetch from a page controlled by a service worker which has a fetch // Make sure fetch from a page controlled by a service worker which has a fetch
// handler but falls back to the network works after crash. // handler but falls back to the network works after crash.
IN_PROC_BROWSER_TEST_F(NetworkServiceRestartBrowserTest, IN_PROC_BROWSER_TEST_F(NetworkServiceRestartBrowserTest,
FetchFromServiceWorkerControlledPage_PassThrough) { MAYBE_FetchFromServiceWorkerControlledPage_PassThrough) {
StoragePartitionImpl* partition = static_cast<StoragePartitionImpl*>( StoragePartitionImpl* partition = static_cast<StoragePartitionImpl*>(
BrowserContext::GetDefaultStoragePartition(browser_context())); BrowserContext::GetDefaultStoragePartition(browser_context()));
ServiceWorkerStatusObserver observer; ServiceWorkerStatusObserver observer;
...@@ -706,10 +723,19 @@ IN_PROC_BROWSER_TEST_F(NetworkServiceRestartBrowserTest, ...@@ -706,10 +723,19 @@ IN_PROC_BROWSER_TEST_F(NetworkServiceRestartBrowserTest,
service_worker_context->RemoveObserver(&observer); service_worker_context->RemoveObserver(&observer);
} }
// Flaky on Linux TSan (https://crbug.com/889855)
#if defined(OS_LINUX) && defined(THREAD_SANITIZER)
#define MAYBE_FetchFromServiceWorkerControlledPage_RespondWithFetch \
DISABLED_FetchFromServiceWorkerControlledPage_RespondWithFetch
#else
#define MAYBE_FetchFromServiceWorkerControlledPage_RespondWithFetch \
FetchFromServiceWorkerControlledPage_RespondWithFetch
#endif
// Make sure fetch from a page controlled by a service worker which has a fetch // Make sure fetch from a page controlled by a service worker which has a fetch
// handler and responds with fetch() works after crash. // handler and responds with fetch() works after crash.
IN_PROC_BROWSER_TEST_F(NetworkServiceRestartBrowserTest, IN_PROC_BROWSER_TEST_F(
FetchFromServiceWorkerControlledPage_RespondWithFetch) { NetworkServiceRestartBrowserTest,
MAYBE_FetchFromServiceWorkerControlledPage_RespondWithFetch) {
StoragePartitionImpl* partition = static_cast<StoragePartitionImpl*>( StoragePartitionImpl* partition = static_cast<StoragePartitionImpl*>(
BrowserContext::GetDefaultStoragePartition(browser_context())); BrowserContext::GetDefaultStoragePartition(browser_context()));
ServiceWorkerStatusObserver observer; ServiceWorkerStatusObserver observer;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment