Commit df40a327 authored by Sunny Sachanandani's avatar Sunny Sachanandani Committed by Commit Bot

Add DumpWithoutCrashing for debugging NV12 create swap chain failures

Bug: 869677
Change-Id: I0f5e37ef5fbb2ca8853bab98cc10f822fab274df
Reviewed-on: https://chromium-review.googlesource.com/c/1340277Reviewed-by: default avatarZhenyao Mo <zmo@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609092}
parent bc6ba9d2
...@@ -9,6 +9,8 @@ ...@@ -9,6 +9,8 @@
#include <dxgi1_6.h> #include <dxgi1_6.h>
#include "base/containers/circular_deque.h" #include "base/containers/circular_deque.h"
#include "base/debug/alias.h"
#include "base/debug/dump_without_crashing.h"
#include "base/feature_list.h" #include "base/feature_list.h"
#include "base/metrics/histogram_functions.h" #include "base/metrics/histogram_functions.h"
#include "base/metrics/histogram_macros.h" #include "base/metrics/histogram_macros.h"
...@@ -1295,6 +1297,16 @@ bool DCLayerTree::SwapChainPresenter::ReallocateSwapChain( ...@@ -1295,6 +1297,16 @@ bool DCLayerTree::SwapChainPresenter::ReallocateSwapChain(
OverlayFormatToString(g_overlay_format_used), OverlayFormatToString(g_overlay_format_used),
SUCCEEDED(hr)); SUCCEEDED(hr));
if (FAILED(hr)) { if (FAILED(hr)) {
// TODO(sunnyps): Remove after debugging NV12 create swap chain failure.
OverlayFormat format = g_overlay_format_used;
DXGI_FORMAT dxgi_format = g_overlay_dxgi_format_used;
base::debug::Alias(&format);
base::debug::Alias(&dxgi_format);
base::debug::Alias(&hr);
base::debug::Alias(&swap_chain_size);
base::debug::Alias(&protected_video_type);
base::debug::DumpWithoutCrashing();
DLOG(ERROR) << "Failed to create " DLOG(ERROR) << "Failed to create "
<< OverlayFormatToString(g_overlay_format_used) << OverlayFormatToString(g_overlay_format_used)
<< " swap chain of size " << swap_chain_size.ToString() << " swap chain of size " << swap_chain_size.ToString()
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment