Commit dfc855bb authored by Xianzhu Wang's avatar Xianzhu Wang Committed by Commit Bot

Reland "[CompositeAfterPaint] Rebaseline tests"

This reverts commit fb7771dc.

Reason for revert: Long filenames excluded.

Original change's description:
> Revert "[CompositeAfterPaint] Rebaseline tests"
> 
> This reverts commit 9dc83eeb.
> 
> Reason for revert: causes bot_update failure on Win x64 Builder (dbg).
> 
> Sample build: https://ci.chromium.org/p/chromium/builders/ci/Win%20x64%20Builder%20%28dbg%29/99428
> 
> ---
> error: unable to create file third_party/blink/web_tests/flag-specific/enable-blink-features=CompositeAfterPaint/virtual/controls-refresh/fast/forms/controls-new-ui/color-scheme-validation/color/color-suggestion-picker-appearance-with-scrollbar-expected.png: Filename too long
> ---
> 
> Original change's description:
> > [CompositeAfterPaint] Rebaseline tests
> > 
> > Most of these rebaselines are for the mock scrollbar change which missed
> > rebaselining for CAP.
> > 
> > The other rebaselines are for new tests added for
> > virtual/controls-refresh.
> > 
> > TBR=schenney@chromium.org
> > 
> > Change-Id: Ia710bd0bf371eae8367c1ee3739691985f314840
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888572
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#710590}
> 
> TBR=wangxianzhu@chromium.org,schenney@chromium.org
> 
> Change-Id: Ic072356ff05e5c738f9b830a3ac398d0d8cb4f73
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889710
> Reviewed-by: Takashi Sakamoto <tasak@google.com>
> Commit-Queue: Takashi Sakamoto <tasak@google.com>
> Cr-Commit-Position: refs/heads/master@{#710696}

TBR=wangxianzhu@chromium.org,tasak@google.com,schenney@chromium.org

Change-Id: Ia3500803eb9f24d078cc8919b453821147e3df9a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890950Reviewed-by: default avatarXianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710882}
parent 8657999c
...@@ -19,6 +19,7 @@ Bug(none) virtual/threaded/http/tests/devtools/tracing/ [ Skip ] ...@@ -19,6 +19,7 @@ Bug(none) virtual/threaded/http/tests/devtools/tracing/ [ Skip ]
# Filenames are too long on Windows. # Filenames are too long on Windows.
Bug(1014132) virtual/controls-refresh-high-contrast/ [ Skip ] Bug(1014132) virtual/controls-refresh-high-contrast/ [ Skip ]
Bug(1014132) virtual/controls-refresh/ [ Skip ]
# Fail before CompositeAfterPaint but pass with it. # Fail before CompositeAfterPaint but pass with it.
crbug.com/472330 fast/borders/border-image-outset-split-inline-vertical-lr.html [ Pass ] crbug.com/472330 fast/borders/border-image-outset-split-inline-vertical-lr.html [ Pass ]
...@@ -32,7 +33,7 @@ crbug.com/918155 virtual/prefer_compositing_to_lcd_text/scrollbars/overlay-scrol ...@@ -32,7 +33,7 @@ crbug.com/918155 virtual/prefer_compositing_to_lcd_text/scrollbars/overlay-scrol
crbug.com/918155 virtual/prefer_compositing_to_lcd_text/scrollbars/overlay-scrollbar-over-child-layer-nested.html [ Pass ] crbug.com/918155 virtual/prefer_compositing_to_lcd_text/scrollbars/overlay-scrollbar-over-child-layer-nested.html [ Pass ]
Bug(none) virtual/android/fullscreen/video-overlay-scroll.html [ Failure ] Bug(none) virtual/android/fullscreen/video-overlay-scroll.html [ Failure ]
Bug(none) virtual/android/rootscroller/nested-rootscroller-browser-controls-bounds-hidden.html [ Crash ] Bug(none) virtual/android/rootscroller/fixed-chaining-with-implicit-pointer-events-none.html [ Failure ]
Bug(none) virtual/android/rootscroller/nested-rootscroller-browser-controls-bounds-shown.html [ Crash ] Bug(none) virtual/android/rootscroller/nested-rootscroller-browser-controls-bounds-shown.html [ Crash ]
Bug(none) virtual/android/url-bar/bottom-and-top-fixed-sticks-to-top.html [ Crash ] Bug(none) virtual/android/url-bar/bottom-and-top-fixed-sticks-to-top.html [ Crash ]
Bug(none) virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html [ Crash ] Bug(none) virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html [ Crash ]
...@@ -69,13 +70,13 @@ Bug(none) compositing/layer-creation/overlap-transformed-preserved-3d.html [ Fai ...@@ -69,13 +70,13 @@ Bug(none) compositing/layer-creation/overlap-transformed-preserved-3d.html [ Fai
Bug(none) compositing/layer-creation/overlap-transforms.html [ Failure ] Bug(none) compositing/layer-creation/overlap-transforms.html [ Failure ]
Bug(none) compositing/layer-creation/scroll-partial-update.html [ Failure ] Bug(none) compositing/layer-creation/scroll-partial-update.html [ Failure ]
Bug(none) compositing/masks/mask-with-removed-filters.html [ Failure ] Bug(none) compositing/masks/mask-with-removed-filters.html [ Failure ]
Bug(none) compositing/nested-multicol-mask-composited-filter-crash.html [ Crash ]
Bug(none) compositing/overflow/clip-descendents.html [ Failure ] Bug(none) compositing/overflow/clip-descendents.html [ Failure ]
Bug(none) compositing/overflow/opt-in-if-composited.html [ Failure ] Bug(none) compositing/overflow/opt-in-if-composited.html [ Failure ]
crbug.com/979367 compositing/overflow/overflow-scroll-background-fractional-offset.html [ Failure ] crbug.com/979367 compositing/overflow/overflow-scroll-background-fractional-offset.html [ Failure ]
Bug(none) compositing/overflow/overflow-scroll-background-opaque-to-transparent.html [ Failure ] Bug(none) compositing/overflow/overflow-scroll-background-opaque-to-transparent.html [ Failure ]
Bug(none) compositing/overflow/overflow-scroll-background-transparent-to-opaque.html [ Failure ] Bug(none) compositing/overflow/overflow-scroll-background-transparent-to-opaque.html [ Failure ]
Bug(none) compositing/overflow/overflow-scroll-content-fractional-offset.html [ Failure ] Bug(none) compositing/overflow/overflow-scroll-content-fractional-offset.html [ Failure ]
Bug(none) compositing/overflow/overflow-scroll-with-negative-offset-translucent-outline.html [ Failure ]
Bug(none) compositing/overflow/overflow-scroll-with-opaque-background-will-change.html [ Failure ] Bug(none) compositing/overflow/overflow-scroll-with-opaque-background-will-change.html [ Failure ]
Bug(none) compositing/overflow/overflow-scroll-with-opaque-background.html [ Failure ] Bug(none) compositing/overflow/overflow-scroll-with-opaque-background.html [ Failure ]
Bug(none) compositing/overflow/overflow-scroll-with-transparent-background.html [ Failure ] Bug(none) compositing/overflow/overflow-scroll-with-transparent-background.html [ Failure ]
...@@ -115,7 +116,6 @@ Bug(none) fast/css/outline-offset-large.html [ Failure ] ...@@ -115,7 +116,6 @@ Bug(none) fast/css/outline-offset-large.html [ Failure ]
Bug(none) fast/forms/validation-bubble-device-emulation-change.html [ Failure ] Bug(none) fast/forms/validation-bubble-device-emulation-change.html [ Failure ]
Bug(none) fast/webgl/pixelated.html [ Failure ] Bug(none) fast/webgl/pixelated.html [ Failure ]
Bug(none) images/color-profile-svg-foreign-object.html [ Failure ] Bug(none) images/color-profile-svg-foreign-object.html [ Failure ]
Bug(none) fast/multicol/insane-column-count-and-padding-nested-crash.html [ Crash ]
Bug(none) fast/sub-pixel/should-not-repaint-subpixel-composited-layer.html [ Failure ] Bug(none) fast/sub-pixel/should-not-repaint-subpixel-composited-layer.html [ Failure ]
Bug(none) fast/sub-pixel/transformed-iframe-copy-on-scroll.html [ Failure ] Bug(none) fast/sub-pixel/transformed-iframe-copy-on-scroll.html [ Failure ]
Bug(none) fragmentation/outline-crossing-columns.html [ Crash ] Bug(none) fragmentation/outline-crossing-columns.html [ Crash ]
...@@ -136,7 +136,6 @@ Bug(none) virtual/scalefactor200/external/wpt/largest-contentful-paint/invisible ...@@ -136,7 +136,6 @@ Bug(none) virtual/scalefactor200/external/wpt/largest-contentful-paint/invisible
Bug(none) virtual/scalefactor200withoutzoom/external/wpt/largest-contentful-paint/invisible-images.html [ Failure ] Bug(none) virtual/scalefactor200withoutzoom/external/wpt/largest-contentful-paint/invisible-images.html [ Failure ]
Bug(none) virtual/threaded-prefer-compositing/fast/scrolling/middle-click-autoscroll-latching-clicked-node.html [ Failure ] Bug(none) virtual/threaded-prefer-compositing/fast/scrolling/middle-click-autoscroll-latching-clicked-node.html [ Failure ]
Bug(none) virtual/threaded-prefer-compositing/fast/scrolling/scrollbar-mousedown-move-mouseup.html [ Failure ] Bug(none) virtual/threaded-prefer-compositing/fast/scrolling/scrollbar-mousedown-move-mouseup.html [ Failure ]
Bug(none) wpt_internal/display-lock/rendersubtree/paint/locked-iframe-doesnt-paint-contents.html [ Failure ]
# Loading an image in a subframe. # Loading an image in a subframe.
crbug.com/959936 http/tests/images/image-decode-in-frame.html [ Failure ] crbug.com/959936 http/tests/images/image-decode-in-frame.html [ Failure ]
...@@ -149,8 +148,6 @@ crbug.com/907601 virtual/threaded-prefer-compositing/fast/scrolling/events/scrol ...@@ -149,8 +148,6 @@ crbug.com/907601 virtual/threaded-prefer-compositing/fast/scrolling/events/scrol
crbug.com/979352 virtual/threaded-prefer-compositing/fast/scrolling/non-composited-scroller-in-scrolled-absolute-scroller.html [ Failure ] crbug.com/979352 virtual/threaded-prefer-compositing/fast/scrolling/non-composited-scroller-in-scrolled-absolute-scroller.html [ Failure ]
crbug.com/979352 virtual/threaded-prefer-compositing/fast/scrolling/non-composited-scroller-in-scrolled-position-fixed-scroller.html [ Failure ] crbug.com/979352 virtual/threaded-prefer-compositing/fast/scrolling/non-composited-scroller-in-scrolled-position-fixed-scroller.html [ Failure ]
crbug.com/979352 virtual/threaded-prefer-compositing/fast/scrolling/non-composited-scroller-in-sticky.html [ Failure ] crbug.com/979352 virtual/threaded-prefer-compositing/fast/scrolling/non-composited-scroller-in-sticky.html [ Failure ]
crbug.com/979352 virtual/android/rootscroller/fixed-chaining-with-implicit.html [ Failure ]
crbug.com/979352 virtual/android/rootscroller/fixed-scroller-chaining-with-implicit.html [ Failure ]
# Less invalidations or different invalidations without pixel failures. # Less invalidations or different invalidations without pixel failures.
# Some might be good. Some might be under-invalidations for which under-invalidation # Some might be good. Some might be under-invalidations for which under-invalidation
...@@ -162,7 +159,6 @@ Bug(none) paint/invalidation/scroll/overflow-hidden-yet-scrolled.html [ Failure ...@@ -162,7 +159,6 @@ Bug(none) paint/invalidation/scroll/overflow-hidden-yet-scrolled.html [ Failure
# Under-invalidation # Under-invalidation
Bug(none) fast/events/touch/touch-rect-crash-on-unpromote-layer.html [ Crash ] Bug(none) fast/events/touch/touch-rect-crash-on-unpromote-layer.html [ Crash ]
Bug(none) paint/background/scrolling-background-with-negative-z-child.html [ Crash ]
# "Missing" raster invalidation because composited layers are re-created. # "Missing" raster invalidation because composited layers are re-created.
crbug.com/842356 paint/invalidation/compositing/containing-block-added-individual.html [ Failure ] crbug.com/842356 paint/invalidation/compositing/containing-block-added-individual.html [ Failure ]
...@@ -277,7 +273,6 @@ crbug.com/738613 paint/invalidation/scroll/overflow-scroll-after-move.html [ Fai ...@@ -277,7 +273,6 @@ crbug.com/738613 paint/invalidation/scroll/overflow-scroll-after-move.html [ Fai
crbug.com/738613 compositing/overflow/overflow-scroll-with-pointer-events-toggle.html [ Failure ] crbug.com/738613 compositing/overflow/overflow-scroll-with-pointer-events-toggle.html [ Failure ]
# Needs fully composited scrollbar support. # Needs fully composited scrollbar support.
crbug.com/931486 compositing/composite-scrollable-fixed-position-when-descendants-composite.html [ Failure ]
crbug.com/931486 compositing/force-compositing-mode/overflow-iframe-enter-compositing.html [ Failure ] crbug.com/931486 compositing/force-compositing-mode/overflow-iframe-enter-compositing.html [ Failure ]
crbug.com/931486 compositing/force-compositing-mode/overflow-iframe-layer.html [ Failure ] crbug.com/931486 compositing/force-compositing-mode/overflow-iframe-layer.html [ Failure ]
crbug.com/931486 compositing/iframes/overlapped-iframe-iframe.html [ Failure ] crbug.com/931486 compositing/iframes/overlapped-iframe-iframe.html [ Failure ]
...@@ -422,17 +417,9 @@ crbug.com/980290 scrollingcoordinator/non-fast-scrollable-visibility-change.html ...@@ -422,17 +417,9 @@ crbug.com/980290 scrollingcoordinator/non-fast-scrollable-visibility-change.html
# These failures need to be triaged and are being added to unblock the CQ (see: https://crbug.com/966981). # These failures need to be triaged and are being added to unblock the CQ (see: https://crbug.com/966981).
crbug.com/966981 virtual/threaded/external/wpt/feature-policy/experimental-features/vertical-scroll-disabled-frame-no-scroll-manual.tentative.html [ Failure ] crbug.com/966981 virtual/threaded/external/wpt/feature-policy/experimental-features/vertical-scroll-disabled-frame-no-scroll-manual.tentative.html [ Failure ]
crbug.com/966981 virtual/threaded/external/wpt/feature-policy/experimental-features/vertical-scroll-main-frame-manual.tentative.html [ Failure ]
crbug.com/966981 virtual/threaded/external/wpt/feature-policy/experimental-features/vertical-scroll-touch-action-manual.tentative.html [ Failure ]
crbug.com/966981 virtual/threaded/external/wpt/feature-policy/experimental-features/vertical-scroll-touch-block-manual.tentative.html [ Failure ]
crbug.com/966981 virtual/threaded/external/wpt/feature-policy/experimental-features/vertical-scroll-wheel-block-manual.tentative.html [ Timeout ]
crbug.com/966981 virtual/threaded/fast/events/pinch/gesture-pinch-zoom-scroll-bubble.html [ Timeout ] crbug.com/966981 virtual/threaded/fast/events/pinch/gesture-pinch-zoom-scroll-bubble.html [ Timeout ]
crbug.com/966981 virtual/threaded/fast/events/pinch/pinch-zoom-pan-position-fixed.html [ Failure ]
crbug.com/966981 virtual/threaded-prefer-compositing/fast/scroll-behavior/overscroll-behavior.html [ Failure ] crbug.com/966981 virtual/threaded-prefer-compositing/fast/scroll-behavior/overscroll-behavior.html [ Failure ]
crbug.com/966981 virtual/threaded-prefer-compositing/fast/scroll-behavior/smooth-scroll/scroll-during-selection.html [ Failure ] crbug.com/966981 virtual/threaded-prefer-compositing/fast/scroll-behavior/smooth-scroll/scroll-during-selection.html [ Failure ]
crbug.com/966981 virtual/threaded-prefer-compositing/fast/scrolling/fractional-scroll-offset-document.html [ Failure ]
crbug.com/966981 virtual/threaded-prefer-compositing/fast/scrolling/hover-during-scroll.html [ Failure ]
crbug.com/966981 virtual/threaded-prefer-compositing/fast/scrolling/no-hover-during-scroll.html [ Failure ]
crbug.com/966981 virtual/threaded-prefer-compositing/fast/scrolling/non-composited-scroller-in-position-fixed-scrolled-document.html [ Failure ] crbug.com/966981 virtual/threaded-prefer-compositing/fast/scrolling/non-composited-scroller-in-position-fixed-scrolled-document.html [ Failure ]
crbug.com/966981 virtual/threaded-prefer-compositing/fast/scrolling/non-composited-scroller-in-position-fixed-scroller-scrolled-document.html [ Failure ] crbug.com/966981 virtual/threaded-prefer-compositing/fast/scrolling/non-composited-scroller-in-position-fixed-scroller-scrolled-document.html [ Failure ]
crbug.com/966981 virtual/threaded-prefer-compositing/fast/scrolling/non-composited-scroller-in-position-fixed-scroller.html [ Failure ] crbug.com/966981 virtual/threaded-prefer-compositing/fast/scrolling/non-composited-scroller-in-position-fixed-scroller.html [ Failure ]
...@@ -446,17 +433,9 @@ crbug.com/966981 virtual/threaded-prefer-compositing/fast/scrolling/events/overs ...@@ -446,17 +433,9 @@ crbug.com/966981 virtual/threaded-prefer-compositing/fast/scrolling/events/overs
crbug.com/966981 virtual/threaded-prefer-compositing/fast/scrolling/events/scrollend-event-fired-to-document.html [ Timeout ] crbug.com/966981 virtual/threaded-prefer-compositing/fast/scrolling/events/scrollend-event-fired-to-document.html [ Timeout ]
crbug.com/966981 virtual/threaded-prefer-compositing/fast/scrolling/events/scrollend-event-fired-to-scrolled-element.html [ Timeout ] crbug.com/966981 virtual/threaded-prefer-compositing/fast/scrolling/events/scrollend-event-fired-to-scrolled-element.html [ Timeout ]
crbug.com/966981 virtual/threaded-prefer-compositing/fast/scrolling/events/scrollend-event-fired-to-window.html [ Timeout ] crbug.com/966981 virtual/threaded-prefer-compositing/fast/scrolling/events/scrollend-event-fired-to-window.html [ Timeout ]
crbug.com/966981 virtual/threaded/synthetic_gestures/animated-wheel-tiny-delta.html [ Failure ]
# Added to land BGPT-fixes # Added to land BGPT-fixes
crbug.com/979002 virtual/threaded-prefer-compositing/fast/scrolling/uncomposite-and-composite-scroll.html [ Failure ] crbug.com/979002 virtual/threaded-prefer-compositing/fast/scrolling/uncomposite-and-composite-scroll.html [ Failure ]
crbug.com/981749 virtual/threaded-prefer-compositing/fast/scrolling/scroll-chaining-from-position-fixed.html [ Failure ]
# These tests are failing due to subpixel differences but can be rebaselined.
Bug(none) virtual/controls-refresh/fast/forms/controls-new-ui/color-scheme-validation/color/color-suggestion-picker-appearance.html [ Failure ]
Bug(none) virtual/controls-refresh/fast/forms/controls-new-ui/color-scheme-validation/color/color-suggestion-picker-appearance-with-scrollbar.html [ Failure ]
Bug(none) virtual/controls-refresh/fast/forms/controls-new-ui/color-scheme-validation/select/select-multiple-appearance-basic.html [ Failure ]
Bug(none) virtual/controls-refresh/fast/forms/controls-new-ui/color-scheme-validation/time-picker/time-picker-appearance.html [ Failure ]
# We need the inner viewport scroll layer. # We need the inner viewport scroll layer.
crbug.com/1015625 inspector-protocol/emulation/device-emulation-restore.js [ Crash ] crbug.com/1015625 inspector-protocol/emulation/device-emulation-restore.js [ Crash ]
...@@ -306,16 +306,6 @@ ...@@ -306,16 +306,6 @@
"rect": [701, 420, 40, 10], "rect": [701, 420, 40, 10],
"reason": "geometry" "reason": "geometry"
}, },
{
"object": "LayoutBlockFlow (floating) DIV",
"rect": [701, 255, 40, 10],
"reason": "geometry"
},
{
"object": "LayoutBlockFlow (floating) DIV",
"rect": [701, 249, 40, 10],
"reason": "geometry"
},
{ {
"object": "LayoutBlockFlow (floating) DIV", "object": "LayoutBlockFlow (floating) DIV",
"rect": [701, 216, 40, 10], "rect": [701, 216, 40, 10],
...@@ -406,6 +396,16 @@ ...@@ -406,6 +396,16 @@
"rect": [690, 291, 40, 10], "rect": [690, 291, 40, 10],
"reason": "geometry" "reason": "geometry"
}, },
{
"object": "LayoutBlockFlow (floating) DIV",
"rect": [671, 255, 40, 10],
"reason": "geometry"
},
{
"object": "LayoutBlockFlow (floating) DIV",
"rect": [671, 249, 40, 10],
"reason": "geometry"
},
{ {
"object": "NGPhysicalBoxFragment LayoutNGBlockFlow DIV", "object": "NGPhysicalBoxFragment LayoutNGBlockFlow DIV",
"rect": [701, 543, 32, 20], "rect": [701, 543, 32, 20],
...@@ -418,22 +418,22 @@ ...@@ -418,22 +418,22 @@
}, },
{ {
"object": "InlineTextBox 'x'", "object": "InlineTextBox 'x'",
"rect": [725, 257, 16, 17], "rect": [725, 218, 16, 17],
"reason": "geometry" "reason": "geometry"
}, },
{ {
"object": "InlineTextBox 'x'", "object": "InlineTextBox 'x'",
"rect": [725, 251, 16, 17], "rect": [725, 212, 16, 17],
"reason": "geometry" "reason": "geometry"
}, },
{ {
"object": "InlineTextBox 'x'", "object": "InlineTextBox 'x'",
"rect": [725, 218, 16, 17], "rect": [695, 257, 16, 17],
"reason": "geometry" "reason": "geometry"
}, },
{ {
"object": "InlineTextBox 'x'", "object": "InlineTextBox 'x'",
"rect": [725, 212, 16, 17], "rect": [695, 251, 16, 17],
"reason": "geometry" "reason": "geometry"
}, },
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment