[Passwords] Add a message when there is no password match

This patch means adding a message which indicates that
there is no result when searching for a password.

Bug: 1040875
Change-Id: If980d685a3f0bc3eec3d5717b484edb3f03c4cf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049424
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744651}

chrome/android/java/res/layout/password_no_result.xml

+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2020 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+
+<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto"
+    xmlns:tools="http://schemas.android.com/tools"
+    android:layout_width="match_parent"
+    android:layout_height="match_parent">
+
+    <FrameLayout
+        style="@style/Card"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:layout_gravity="center"
+        android:layout_marginStart="16dp"
+        android:layout_marginEnd="16dp">
+
+        <org.chromium.ui.widget.TextViewWithLeading
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:layout_gravity="center"
+            android:padding="@dimen/card_padding"
+            android:text="@string/password_no_result"
+            android:textAlignment="center"
+            android:textAppearance="@style/TextAppearance.TextMedium.Secondary"
+            app:leading="@dimen/text_size_medium_leading" />
+
+    </FrameLayout>
+
+</FrameLayout>

chrome/android/java/src/org/chromium/chrome/browser/settings/password/PasswordSettings.java

@@ -202,6 +202,16 @@ public class PasswordSettings
         getPreferenceScreen().addPreference(mEmptyView);
     }
 
+    /**
+     * Include a message when there's no match.
+     */
+    private void displayPasswordNoResultScreenMessage() {
+        Preference noResultView = new Preference(getStyledContext());
+        noResultView.setLayoutResource(R.layout.password_no_result);
+        noResultView.setSelectable(false);
+        getPreferenceScreen().addPreference(noResultView);
+    }
+
     @Override
     public void onDetach() {
         super.onDetach();
@@ -296,6 +306,7 @@ public class PasswordSettings
                 // If not searching, the category needs to be removed again.
                 getPreferenceScreen().removePreference(passwordParent);
             } else {
+                displayPasswordNoResultScreenMessage();
                 getView().announceForAccessibility(
                         getString(R.string.accessible_find_in_page_no_results));
             }

chrome/android/javatests/src/org/chromium/chrome/browser/settings/password/PasswordSettingsTest.java

@@ -1875,7 +1875,7 @@ public class PasswordSettingsTest {
     @Test
     @SmallTest
     @Feature({"Preferences"})
-    public void testSearchDisplaysBlankPageIfSearchTurnsUpEmpty() {
+    public void testSearchDisplaysNoResultMessageIfSearchTurnsUpEmpty() {
         setPasswordSourceWithMultipleEntries(GREEK_GODS);
         SettingsActivityTest.startSettingsActivity(
                 InstrumentationRegistry.getInstrumentation(), PasswordSettings.class.getName());
@@ -1898,6 +1898,8 @@ public class PasswordSettingsTest {
         Espresso.onView(allOf(withParent(isAssignableFrom(LinearLayout.class)),
                                 withText(R.string.password_settings_title)))
                 .check(doesNotExist());
+        // Check the message for no result.
+        Espresso.onView(withText(R.string.password_no_result)).check(matches(isDisplayed()));
     }
 
     /**

chrome/browser/ui/android/strings/android_chrome_strings.grd

@@ -500,6 +500,9 @@ CHAR-LIMIT guidelines:
       <message name="IDS_SAVED_PASSWORDS_NONE_TEXT" desc="Text when there are no saved passwords/exceptions.">
         Saved passwords will appear here.
       </message>
+      <message name="IDS_PASSWORD_NO_RESULT" desc="Text when a password search returned no results.">
+        Can’t find that password. Check your spelling and try again.
+      </message>
       <message name="IDS_PASSWORD_ENTRY_VIEWER_TITLE" desc='Title of the overview screen for a saved password.'>
         Saved password
       </message>

chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_PASSWORD_NO_RESULT.png.sha1

+821ca2ab80b59d7b81213e77ed7efc201dbe31f6