Commit e135d70b authored by Sven Zheng's avatar Sven Zheng Committed by Commit Bot

Remove setting ACLs after coping files

Added in crrev.com/c/1919544 trying to fix the bug. But it didn't work
and I've fixed the bug in crrev.com/c/1956145. So it's time to delete
these lines.

Bug: 956016
Change-Id: I73e7c89068652db2976a00cef106f644dbbfbd30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958697Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723550}
parent d1886d3c
......@@ -227,11 +227,6 @@ def _CopyRuntimeImpl(target, source, verbose=True):
# Make the file writable so that we can overwrite or delete it later,
# keep it readable.
os.chmod(target, stat.S_IWRITE | stat.S_IREAD)
# Sometimes BUILTIN/Administrators and SYSTEM doesn't grant the access
# to the file on bots. crbug.com/956016.
if _HostIsWindows(): # Skip if icacls is not available.
subprocess.call(['icacls', target, '/grant', 'Administrators:f'])
subprocess.call(['icacls', target, '/grant', 'SYSTEM:f'])
def _SortByHighestVersionNumberFirst(list_of_str_versions):
"""This sorts |list_of_str_versions| according to version number rules
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment