Commit e18da543 authored by Becky Zhou's avatar Becky Zhou Committed by Commit Bot

[History] Fix header shown after clearing browsing data

setPrivacyDisclaimer() shouldn't call setHeaders() if headers are not
set when history query completes. This fix would allow header visibility
to rely on the number of history items being shown.

Bug: 790921
Change-Id: Ieb65661490fab08fa65507205f5f32bc23b883c4
Reviewed-on: https://chromium-review.googlesource.com/807207
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: default avatarTheresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521541}
parent 9b504fd5
...@@ -52,7 +52,7 @@ public class HistoryAdapter extends DateDividedAdapter implements BrowsingHistor ...@@ -52,7 +52,7 @@ public class HistoryAdapter extends DateDividedAdapter implements BrowsingHistor
private boolean mHasOtherFormsOfBrowsingData; private boolean mHasOtherFormsOfBrowsingData;
private boolean mIsDestroyed; private boolean mIsDestroyed;
private boolean mIsInitialized; private boolean mAreHeadersInitialized;
private boolean mIsLoadingItems; private boolean mIsLoadingItems;
private boolean mIsSearching; private boolean mIsSearching;
private boolean mHasMorePotentialItems; private boolean mHasMorePotentialItems;
...@@ -84,7 +84,7 @@ public class HistoryAdapter extends DateDividedAdapter implements BrowsingHistor ...@@ -84,7 +84,7 @@ public class HistoryAdapter extends DateDividedAdapter implements BrowsingHistor
* Initializes the HistoryAdapter and loads the first set of browsing history items. * Initializes the HistoryAdapter and loads the first set of browsing history items.
*/ */
public void initialize() { public void initialize() {
mIsInitialized = false; mAreHeadersInitialized = false;
mIsLoadingItems = true; mIsLoadingItems = true;
mClearOnNextQueryComplete = true; mClearOnNextQueryComplete = true;
mHistoryProvider.queryHistory(mQueryText); mHistoryProvider.queryHistory(mQueryText);
...@@ -224,9 +224,9 @@ public class HistoryAdapter extends DateDividedAdapter implements BrowsingHistor ...@@ -224,9 +224,9 @@ public class HistoryAdapter extends DateDividedAdapter implements BrowsingHistor
mClearOnNextQueryComplete = false; mClearOnNextQueryComplete = false;
} }
if (!mIsInitialized) { if (!mAreHeadersInitialized && items.size() > 0 && !mIsSearching) {
if (items.size() > 0 && !mIsSearching) setHeaders(); setHeaders();
mIsInitialized = true; mAreHeadersInitialized = true;
} }
removeFooter(); removeFooter();
...@@ -337,7 +337,7 @@ public class HistoryAdapter extends DateDividedAdapter implements BrowsingHistor ...@@ -337,7 +337,7 @@ public class HistoryAdapter extends DateDividedAdapter implements BrowsingHistor
// Prevent from refreshing the recycler view if header visibility is not changed. // Prevent from refreshing the recycler view if header visibility is not changed.
if (mPrivacyDisclaimersVisible == shouldShowPrivacyDisclaimers) return; if (mPrivacyDisclaimersVisible == shouldShowPrivacyDisclaimers) return;
mPrivacyDisclaimersVisible = shouldShowPrivacyDisclaimers; mPrivacyDisclaimersVisible = shouldShowPrivacyDisclaimers;
if (mIsInitialized) setHeaders(); if (mAreHeadersInitialized) setHeaders();
} }
private void updateClearBrowsingDataButtonVisibility() { private void updateClearBrowsingDataButtonVisibility() {
...@@ -349,7 +349,7 @@ public class HistoryAdapter extends DateDividedAdapter implements BrowsingHistor ...@@ -349,7 +349,7 @@ public class HistoryAdapter extends DateDividedAdapter implements BrowsingHistor
if (mClearBrowsingDataButtonVisible == shouldShowButton) return; if (mClearBrowsingDataButtonVisible == shouldShowButton) return;
mClearBrowsingDataButtonVisible = shouldShowButton; mClearBrowsingDataButtonVisible = shouldShowButton;
mPrivacyDisclaimerBottomSpace.setVisibility(shouldShowButton ? View.GONE : View.VISIBLE); mPrivacyDisclaimerBottomSpace.setVisibility(shouldShowButton ? View.GONE : View.VISIBLE);
if (mIsInitialized) setHeaders(); if (mAreHeadersInitialized) setHeaders();
} }
@VisibleForTesting @VisibleForTesting
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment