[cleanup] Remove NGLineBreaker::in_line_height_quirks_mode_

... and other related removals.

There should be no behaviour change.

Change-Id: I4dc82343233a8be2fe32d590cc44194ab372c8b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446171
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813556}

third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.cc

@@ -68,10 +68,8 @@ NGInlineLayoutAlgorithm::NGInlineLayoutAlgorithm(
       box_states_(nullptr),
       context_(context),
       baseline_type_(container_builder_.Style().GetFontBaseline()),
-      is_horizontal_writing_mode_(
-          blink::IsHorizontalWritingMode(space.GetWritingMode())) {
+      quirks_mode_(inline_node.GetDocument().InLineHeightQuirksMode()) {
   DCHECK(context);
-  quirks_mode_ = inline_node.InLineHeightQuirksMode();
 }
 
 // Define the destructor here, so that we can forward-declare more in the

third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.h

@@ -63,8 +63,6 @@ class CORE_EXPORT NGInlineLayoutAlgorithm final
                                   LayoutObject* floating_object,
                                   NGExclusionSpace*) const;
 
-  bool IsHorizontalWritingMode() const { return is_horizontal_writing_mode_; }
-
   void PrepareBoxStates(const NGLineInfo&, const NGInlineBreakToken*);
   void RebuildBoxStates(const NGLineInfo&,
                         const NGInlineBreakToken*,
@@ -126,7 +124,8 @@ class CORE_EXPORT NGInlineLayoutAlgorithm final
 
   FontBaseline baseline_type_ = FontBaseline::kAlphabeticBaseline;
 
-  unsigned is_horizontal_writing_mode_ : 1;
+  // True if in quirks or limited-quirks mode, which require line-height quirks.
+  // https://quirks.spec.whatwg.org/#the-line-height-calculation-quirk
   unsigned quirks_mode_ : 1;
 
 #if DCHECK_IS_ON()

third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.h

@@ -35,13 +35,6 @@ class CORE_EXPORT NGInlineNode : public NGLayoutInputNode {
   }
   NGLayoutInputNode NextSibling() const { return nullptr; }
 
-  // True in quirks mode or limited-quirks mode, which require line-height
-  // quirks.
-  // https://quirks.spec.whatwg.org/#the-line-height-calculation-quirk
-  bool InLineHeightQuirksMode() const {
-    return GetDocument().InLineHeightQuirksMode();
-  }
-
   scoped_refptr<const NGLayoutResult> Layout(
       const NGConstraintSpace&,
       const NGBreakToken*,

third_party/blink/renderer/core/layout/ng/inline/ng_line_breaker.cc

@@ -180,7 +180,6 @@ NGLineBreaker::NGLineBreaker(NGInlineNode node,
                                node.CanContainFirstFormattedLine()),
       use_first_line_style_(is_first_formatted_line_ &&
                             node.UseFirstLineStyle()),
-      in_line_height_quirks_mode_(node.InLineHeightQuirksMode()),
       sticky_images_quirk_(mode != NGLineBreakerMode::kContent &&
                            node.IsStickyImagesQuirkForContentSize()),
       items_data_(node.ItemsData(use_first_line_style_)),

third_party/blink/renderer/core/layout/ng/inline/ng_line_breaker.h

@@ -254,11 +254,6 @@ class CORE_EXPORT NGLineBreaker {
   // True when breaking at soft hyphens (U+00AD) is allowed.
   bool enable_soft_hyphen_ = true;
 
-  // True in quirks mode or limited-quirks mode, which require line-height
-  // quirks.
-  // https://quirks.spec.whatwg.org/#the-line-height-calculation-quirk
-  bool in_line_height_quirks_mode_ = false;
-
   // True when the line we are breaking has a list marker.
   bool has_list_marker_ = false;