Run the incognito title-changing content_script extension for tests at document_end

In Blink r164582 ("Don't set document.title when there is no <head>") Blink aligns the behavior of the "document.title" property with the HTML specification, and now disregards users who set the title when no <head> or <title> element exist yet. This content_script extension runs at document_start, at which time no DOM is available yet. Changing this to document_end means that the DOM is available, and it's thus able to change the page's title (the sole purpose of the extension). BUG=332106 R=wjmaclean@chromium.org Review URL: https://codereview.chromium.org/117993006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243317 0039d316-1c4b-4281-b951-d872f2087c98

Run the incognito title-changing content_script extension for tests at document_end
In Blink r164582 ("Don't set document.title when there is no <head>") Blink aligns the behavior of the "document.title" property with the HTML specification, and now disregards users who set the title when no <head> or <title> element exist yet. This content_script extension runs at document_start, at which time no DOM is available yet. Changing this to document_end means that the DOM is available, and it's thus able to change the page's title (the sole purpose of the extension). BUG=332106 R=wjmaclean@chromium.org Review URL: https://codereview.chromium.org/117993006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243317 0039d316-1c4b-4281-b951-d872f2087c98
e1cdab2a · peter@chromium.org · f0355bde · e1cdab2a
Commit e1cdab2a authored Jan 07, 2014 by peter@chromium.org
Show whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

chrome/test/data/extensions/api_test/incognito/content_scripts/manifest.json ...tensions/api_test/incognito/content_scripts/manifest.json +1 -1

No files found.
--- a/chrome/test/data/extensions/api_test/incognito/content_scripts/manifest.json
+++ b/chrome/test/data/extensions/api_test/incognito/content_scripts/manifest.json
@@ -8,7 +8,7 @@
    {
      "matches": ["http://*/*", "https://*/*"],
      "js": ["change_page_title.js"],
-      "run_at": "document_start"
+      "run_at": "document_end"
    }
  ]
 }