Commit e2cabf12 authored by gogerald's avatar gogerald Committed by Commit Bot

[Autofill Assistant] Make comments and name consistent

Bug: 806868
Change-Id: Iffbbac28a2712e59e2c5a59c733c18b46b90f9ef
Reviewed-on: https://chromium-review.googlesource.com/1256015Reviewed-by: default avatarRouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595684}
parent b995027a
...@@ -14,8 +14,8 @@ void Action::UpdateProcessedAction(bool status) { ...@@ -14,8 +14,8 @@ void Action::UpdateProcessedAction(bool status) {
// Safety check in case process action is run twice. // Safety check in case process action is run twice.
*processed_action_proto_->mutable_action() = proto_; *processed_action_proto_->mutable_action() = proto_;
processed_action_proto_->set_status( processed_action_proto_->set_status(
status ? ProcessedActionStatus::ACTION_APPLIED status ? ProcessedActionStatusProto::ACTION_APPLIED
: ProcessedActionStatus::OTHER_ACTION_STATUS); : ProcessedActionStatusProto::OTHER_ACTION_STATUS);
} }
} // namespace autofill_assistant } // namespace autofill_assistant
...@@ -135,7 +135,7 @@ class AutofillActionTest : public testing::Test { ...@@ -135,7 +135,7 @@ class AutofillActionTest : public testing::Test {
DirectCallback callback; DirectCallback callback;
action.ProcessAction(&mock_action_delegate_, callback.Get()); action.ProcessAction(&mock_action_delegate_, callback.Get());
return callback.GetResultOrDie()->status() == return callback.GetResultOrDie()->status() ==
ProcessedActionStatus::ACTION_APPLIED; ProcessedActionStatusProto::ACTION_APPLIED;
} }
MockActionDelegate mock_action_delegate_; MockActionDelegate mock_action_delegate_;
......
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
#include "components/autofill_assistant/browser/actions/action.h" #include "components/autofill_assistant/browser/actions/action.h"
namespace autofill_assistant { namespace autofill_assistant {
// An action to display a message. // An action to navigate to a given web page.
class NavigateAction : public Action { class NavigateAction : public Action {
public: public:
explicit NavigateAction(const ActionProto& proto); explicit NavigateAction(const ActionProto& proto);
......
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
#include "components/autofill_assistant/browser/actions/action.h" #include "components/autofill_assistant/browser/actions/action.h"
namespace autofill_assistant { namespace autofill_assistant {
// An action to reset Autofill Assistant state.
class ResetAction : public Action { class ResetAction : public Action {
public: public:
explicit ResetAction(const ActionProto& proto); explicit ResetAction(const ActionProto& proto);
......
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
#include "components/autofill_assistant/browser/actions/action.h" #include "components/autofill_assistant/browser/actions/action.h"
namespace autofill_assistant { namespace autofill_assistant {
// An action to stop Autofill Assistant.
class StopAction : public Action { class StopAction : public Action {
public: public:
explicit StopAction(const ActionProto& proto); explicit StopAction(const ActionProto& proto);
......
...@@ -207,7 +207,7 @@ void ScriptExecutor::OnProcessedAction( ...@@ -207,7 +207,7 @@ void ScriptExecutor::OnProcessedAction(
std::unique_ptr<ProcessedActionProto> processed_action_proto) { std::unique_ptr<ProcessedActionProto> processed_action_proto) {
processed_actions_.emplace_back(*processed_action_proto); processed_actions_.emplace_back(*processed_action_proto);
if (processed_actions_.back().status() != if (processed_actions_.back().status() !=
ProcessedActionStatus::ACTION_APPLIED) { ProcessedActionStatusProto::ACTION_APPLIED) {
// Report error immediately, interrupting action processing. // Report error immediately, interrupting action processing.
GetNextActions(); GetNextActions();
return; return;
......
...@@ -240,12 +240,12 @@ message ProcessedActionProto { ...@@ -240,12 +240,12 @@ message ProcessedActionProto {
// The action that was processed. // The action that was processed.
optional ActionProto action = 1; optional ActionProto action = 1;
optional ProcessedActionStatus status = 2; optional ProcessedActionStatusProto status = 2;
optional PageContentProto page_content = 3; optional PageContentProto page_content = 3;
} }
enum ProcessedActionStatus { enum ProcessedActionStatusProto {
UNKNOWN_ACTION_STATUS = 0; UNKNOWN_ACTION_STATUS = 0;
ELEMENT_RESOLUTION_FAILED = 1; ELEMENT_RESOLUTION_FAILED = 1;
ACTION_APPLIED = 2; ACTION_APPLIED = 2;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment