Commit e3474cb4 authored by Guido Urdaneta's avatar Guido Urdaneta Committed by Commit Bot

Revert "Disable flaky WebRtcMediaRecorderTest.ResumeAndDataAvailable on TSAN/ASAN"

This reverts commit 3a45f157.

Reason for revert: This ASAN/TSAN failure is a more general failure not specific to this test. Re-enabling, since the issue should be fixed when the more general problem is fixed.

Original change's description:
> Disable flaky WebRtcMediaRecorderTest.ResumeAndDataAvailable on TSAN/ASAN
> 
> Bug: 1045381
> Change-Id: I285a44d32d47522786b1676b708b0723f336295b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031144
> Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#736883}

TBR=guidou@chromium.org,marinaciocea@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1045381
Change-Id: I02b5189bfbd2bcceb9ad8f01cda5c70b86146ddf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035370Reviewed-by: default avatarGuido Urdaneta <guidou@chromium.org>
Reviewed-by: default avatarMarina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737699}
parent 6dc11c53
......@@ -122,14 +122,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcMediaRecorderTest,
MakeTypicalCall("testIllegalResumeThrowsDOMError();", kMediaRecorderHtmlFile);
}
// Flaky on TSAN and ASAN. See https://crbug.com/1045381
#if defined(THREAD_SANITIZER) || defined(ADDRESS_SANITIZER)
#define MAYBE_ResumeAndDataAvailable DISABLED_ResumeAndDataAvailable
#else
#define MAYBE_ResumeAndDataAvailable ResumeAndDataAvailable
#endif
IN_PROC_BROWSER_TEST_P(MAYBE_WebRtcMediaRecorderTest,
MAYBE_ResumeAndDataAvailable) {
IN_PROC_BROWSER_TEST_P(MAYBE_WebRtcMediaRecorderTest, ResumeAndDataAvailable) {
MaybeForceDisableEncodeAccelerator(GetParam().disable_accelerator);
MakeTypicalCall(base::StringPrintf("testResumeAndDataAvailable(\"%s\");",
GetParam().mime_type.c_str()),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment