Commit e3f16242 authored by Josh Nohle's avatar Josh Nohle Committed by Chromium LUCI CQ

[SecureChannel] Upgrade init auth failure logs from VERBOSE to ERROR

Bug: 1157278, 1164572
Change-Id: I463c7c6fd65690f26004331a3475700ee0677351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629869
Commit-Queue: Josh Nohle <nohle@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843688}
parent f060d1dd
...@@ -162,7 +162,7 @@ void DeviceToDeviceInitiatorHelper::OnInnerMessageCreatedForInitiatorAuth( ...@@ -162,7 +162,7 @@ void DeviceToDeviceInitiatorHelper::OnInnerMessageCreatedForInitiatorAuth(
DeviceToDeviceInitiatorHelper::MessageCallback callback, DeviceToDeviceInitiatorHelper::MessageCallback callback,
const std::string& inner_message) { const std::string& inner_message) {
if (inner_message.empty()) { if (inner_message.empty()) {
PA_LOG(VERBOSE) << "Failed to create inner message for [Initiator Auth]."; PA_LOG(ERROR) << "Failed to create inner message for [Initiator Auth].";
std::move(callback).Run(std::string()); std::move(callback).Run(std::string());
return; return;
} }
...@@ -218,7 +218,7 @@ void DeviceToDeviceInitiatorHelper::BeginResponderAuthValidation( ...@@ -218,7 +218,7 @@ void DeviceToDeviceInitiatorHelper::BeginResponderAuthValidation(
if (!responder_hello.ParseFromString(header.decryption_key_id()) || if (!responder_hello.ParseFromString(header.decryption_key_id()) ||
!responder_hello.public_dh_key().SerializeToString( !responder_hello.public_dh_key().SerializeToString(
&context.responder_session_public_key)) { &context.responder_session_public_key)) {
PA_LOG(VERBOSE) << "Failed to extract responder session public key in " PA_LOG(ERROR) << "Failed to extract responder session public key in "
<< "[Responder Auth] header."; << "[Responder Auth] header.";
std::move(callback).Run(false, SessionKeys()); std::move(callback).Run(false, SessionKeys());
return; return;
...@@ -258,7 +258,7 @@ void DeviceToDeviceInitiatorHelper::OnOuterMessageUnwrappedForResponderAuth( ...@@ -258,7 +258,7 @@ void DeviceToDeviceInitiatorHelper::OnOuterMessageUnwrappedForResponderAuth(
const std::string& payload, const std::string& payload,
const securemessage::Header& header) { const securemessage::Header& header) {
if (!verified) { if (!verified) {
PA_LOG(VERBOSE) << "Failed to unwrap outer [Responder Auth] message."; PA_LOG(ERROR) << "Failed to unwrap outer [Responder Auth] message.";
std::move(callback).Run(false, SessionKeys()); std::move(callback).Run(false, SessionKeys());
return; return;
} }
...@@ -267,7 +267,7 @@ void DeviceToDeviceInitiatorHelper::OnOuterMessageUnwrappedForResponderAuth( ...@@ -267,7 +267,7 @@ void DeviceToDeviceInitiatorHelper::OnOuterMessageUnwrappedForResponderAuth(
securegcm::DeviceToDeviceMessage device_to_device_message; securegcm::DeviceToDeviceMessage device_to_device_message;
if (!device_to_device_message.ParseFromString(payload) || if (!device_to_device_message.ParseFromString(payload) ||
device_to_device_message.sequence_number() != 1) { device_to_device_message.sequence_number() != 1) {
PA_LOG(VERBOSE) << "Failed to validate DeviceToDeviceMessage payload."; PA_LOG(ERROR) << "Failed to validate DeviceToDeviceMessage payload.";
std::move(callback).Run(false, SessionKeys()); std::move(callback).Run(false, SessionKeys());
return; return;
} }
...@@ -294,7 +294,7 @@ void DeviceToDeviceInitiatorHelper::OnMiddleMessageUnwrappedForResponderAuth( ...@@ -294,7 +294,7 @@ void DeviceToDeviceInitiatorHelper::OnMiddleMessageUnwrappedForResponderAuth(
const std::string& payload, const std::string& payload,
const securemessage::Header& header) { const securemessage::Header& header) {
if (!verified) { if (!verified) {
PA_LOG(VERBOSE) << "Failed to unwrap middle [Responder Auth] message."; PA_LOG(ERROR) << "Failed to unwrap middle [Responder Auth] message.";
std::move(callback).Run(false, SessionKeys()); std::move(callback).Run(false, SessionKeys());
return; return;
} }
...@@ -321,7 +321,7 @@ void DeviceToDeviceInitiatorHelper::OnInnerMessageUnwrappedForResponderAuth( ...@@ -321,7 +321,7 @@ void DeviceToDeviceInitiatorHelper::OnInnerMessageUnwrappedForResponderAuth(
const std::string& payload, const std::string& payload,
const securemessage::Header& header) { const securemessage::Header& header) {
if (!verified) if (!verified)
PA_LOG(VERBOSE) << "Failed to unwrap inner [Responder Auth] message."; PA_LOG(ERROR) << "Failed to unwrap inner [Responder Auth] message.";
// Note: The GMS Core implementation does not properly set the metadata // Note: The GMS Core implementation does not properly set the metadata
// version, so we only check that the type is UNLOCK_KEY_SIGNED_CHALLENGE. // version, so we only check that the type is UNLOCK_KEY_SIGNED_CHALLENGE.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment