Commit e428744d authored by a.obzhirov's avatar a.obzhirov Committed by Commit bot

Build error in chrome/browser/extensions/api/tabs/tabs_api.cc.

BUG=

Review-Url: https://codereview.chromium.org/2275113003
Cr-Commit-Position: refs/heads/master@{#414793}
parent 5caadda2
...@@ -260,14 +260,6 @@ bool IsValidStateForWindowsCreateFunction( ...@@ -260,14 +260,6 @@ bool IsValidStateForWindowsCreateFunction(
return true; return true;
} }
bool IsHangoutsExtensionId(const std::string& extension_id) {
for (const char* id : extension_misc::kHangoutsExtensionIds) {
if (extension_id == id)
return true;
}
return false;
}
} // namespace } // namespace
void ZoomModeToZoomSettings(ZoomController::ZoomMode zoom_mode, void ZoomModeToZoomSettings(ZoomController::ZoomMode zoom_mode,
...@@ -516,11 +508,11 @@ bool WindowsCreateFunction::RunSync() { ...@@ -516,11 +508,11 @@ bool WindowsCreateFunction::RunSync() {
#if defined(USE_ASH) #if defined(USE_ASH)
bool create_ash_panel = false; bool create_ash_panel = false;
bool saw_focus_key = false;
#endif // defined(USE_ASH) #endif // defined(USE_ASH)
gfx::Rect window_bounds; gfx::Rect window_bounds;
bool focused = true; bool focused = true;
bool saw_focus_key = false;
std::string extension_id; std::string extension_id;
if (create_data) { if (create_data) {
...@@ -539,10 +531,12 @@ bool WindowsCreateFunction::RunSync() { ...@@ -539,10 +531,12 @@ bool WindowsCreateFunction::RunSync() {
// Only ChromeOS' version of chrome.windows.create would create a panel // Only ChromeOS' version of chrome.windows.create would create a panel
// window. It is whitelisted to Hangouts extension for limited time until // window. It is whitelisted to Hangouts extension for limited time until
// it transitioned to other types of windows. // it transitioned to other types of windows.
if (IsHangoutsExtensionId(extension_id)) { for (const char* id : extension_misc::kHangoutsExtensionIds) {
if (extension_id == id) {
create_ash_panel = true; create_ash_panel = true;
break; break;
} }
}
#endif // defined(USE_ASH) #endif // defined(USE_ASH)
// Everything else gets POPUP instead of PANEL. // Everything else gets POPUP instead of PANEL.
// TODO(dimich): Eventually, remove the 'panel' values form valid // TODO(dimich): Eventually, remove the 'panel' values form valid
...@@ -593,7 +587,9 @@ bool WindowsCreateFunction::RunSync() { ...@@ -593,7 +587,9 @@ bool WindowsCreateFunction::RunSync() {
if (create_data->focused) { if (create_data->focused) {
focused = *create_data->focused; focused = *create_data->focused;
#if defined(USE_ASH)
saw_focus_key = true; saw_focus_key = true;
#endif
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment