Commit e4bb2b8f authored by jbudorick's avatar jbudorick Committed by Commit bot

[Android] Pass isolate files when running tests via buildbot scripts.

This should allow https://codereview.chromium.org/878163004/ to land safely.

BUG=400499

Review URL: https://codereview.chromium.org/902053006

Cr-Commit-Position: refs/heads/master@{#315348}
parent 2eaa5d25
...@@ -43,36 +43,40 @@ GS_AUTH_URL = 'https://storage.cloud.google.com' ...@@ -43,36 +43,40 @@ GS_AUTH_URL = 'https://storage.cloud.google.com'
# annotation: Annotation of the tests to include. # annotation: Annotation of the tests to include.
# exclude_annotation: The annotation of the tests to exclude. # exclude_annotation: The annotation of the tests to exclude.
I_TEST = collections.namedtuple('InstrumentationTest', [ I_TEST = collections.namedtuple('InstrumentationTest', [
'name', 'apk', 'apk_package', 'test_apk', 'test_data', 'host_driven_root', 'name', 'apk', 'apk_package', 'test_apk', 'test_data', 'isolate_file_path',
'annotation', 'exclude_annotation', 'extra_flags']) 'host_driven_root', 'annotation', 'exclude_annotation', 'extra_flags'])
def SrcPath(*path): def SrcPath(*path):
return os.path.join(CHROME_SRC_DIR, *path) return os.path.join(CHROME_SRC_DIR, *path)
def I(name, apk, apk_package, test_apk, test_data, host_driven_root=None, def I(name, apk, apk_package, test_apk, test_data, isolate_file_path=None,
annotation=None, exclude_annotation=None, extra_flags=None): host_driven_root=None, annotation=None, exclude_annotation=None,
return I_TEST(name, apk, apk_package, test_apk, test_data, host_driven_root, extra_flags=None):
annotation, exclude_annotation, extra_flags) return I_TEST(name, apk, apk_package, test_apk, test_data, isolate_file_path,
host_driven_root, annotation, exclude_annotation, extra_flags)
INSTRUMENTATION_TESTS = dict((suite.name, suite) for suite in [ INSTRUMENTATION_TESTS = dict((suite.name, suite) for suite in [
I('ContentShell', I('ContentShell',
'ContentShell.apk', 'ContentShell.apk',
'org.chromium.content_shell_apk', 'org.chromium.content_shell_apk',
'ContentShellTest', 'ContentShellTest',
'content:content/test/data/android/device_files'), 'content:content/test/data/android/device_files',
isolate_file_path='content/content_shell_test_apk.isolate'),
I('ChromeShell', I('ChromeShell',
'ChromeShell.apk', 'ChromeShell.apk',
'org.chromium.chrome.shell', 'org.chromium.chrome.shell',
'ChromeShellTest', 'ChromeShellTest',
'chrome:chrome/test/data/android/device_files', 'chrome:chrome/test/data/android/device_files',
constants.CHROME_SHELL_HOST_DRIVEN_DIR), isolate_file_path='chrome/chrome_shell_test_apk.isolate',
host_driven_root=constants.CHROME_SHELL_HOST_DRIVEN_DIR),
I('AndroidWebView', I('AndroidWebView',
'AndroidWebView.apk', 'AndroidWebView.apk',
'org.chromium.android_webview.shell', 'org.chromium.android_webview.shell',
'AndroidWebViewTest', 'AndroidWebViewTest',
'webview:android_webview/test/data/device_files'), 'webview:android_webview/test/data/device_files',
isolate_file_path='android_webview/android_webview_test_apk.isolate'),
I('ChromeSyncShell', I('ChromeSyncShell',
'ChromeSyncShell.apk', 'ChromeSyncShell.apk',
'org.chromium.chrome.browser.sync', 'org.chromium.chrome.browser.sync',
...@@ -265,6 +269,8 @@ def RunInstrumentationSuite(options, test, flunk_on_failure=True, ...@@ -265,6 +269,8 @@ def RunInstrumentationSuite(options, test, flunk_on_failure=True,
options.flakiness_server) options.flakiness_server)
if options.coverage_bucket: if options.coverage_bucket:
args.append('--coverage-dir=%s' % options.coverage_dir) args.append('--coverage-dir=%s' % options.coverage_dir)
if test.isolate_file_path:
args.append('--isolate-file-path=%s' % test.isolate_file_path)
if test.host_driven_root: if test.host_driven_root:
args.append('--host-driven-root=%s' % test.host_driven_root) args.append('--host-driven-root=%s' % test.host_driven_root)
if test.annotation: if test.annotation:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment