Commit e5493174 authored by Caroline Rising's avatar Caroline Rising Committed by Chromium LUCI CQ

Read later: capture bookmark icon metric when read later is enabled.

This is a preexisting metric capturing the way the bookmark icon was
activated that we want to continue to capture when read later is
enabled.

Bug: 1163938, 1131547
Change-Id: I0c397d7f534c6c52726978d3a85c9fa2a046a6a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616418
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: default avatarCharlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841546}
parent d60db6a1
...@@ -74,6 +74,7 @@ void StarView::OnExecuting(PageActionIconView::ExecuteSource execute_source) { ...@@ -74,6 +74,7 @@ void StarView::OnExecuting(PageActionIconView::ExecuteSource execute_source) {
} }
void StarView::ExecuteCommand(ExecuteSource source) { void StarView::ExecuteCommand(ExecuteSource source) {
OnExecuting(source);
if (base::FeatureList::IsEnabled(reading_list::switches::kReadLater)) { if (base::FeatureList::IsEnabled(reading_list::switches::kReadLater)) {
menu_model_ = std::make_unique<StarMenuModel>( menu_model_ = std::make_unique<StarMenuModel>(
this, active(), chrome::CanMoveActiveTabToReadLater(browser_), this, active(), chrome::CanMoveActiveTabToReadLater(browser_),
...@@ -85,7 +86,6 @@ void StarView::ExecuteCommand(ExecuteSource source) { ...@@ -85,7 +86,6 @@ void StarView::ExecuteCommand(ExecuteSource source) {
views::MenuAnchorPosition::kTopRight, views::MenuAnchorPosition::kTopRight,
ui::MENU_SOURCE_NONE); ui::MENU_SOURCE_NONE);
} else { } else {
OnExecuting(source);
chrome::BookmarkCurrentTab(browser_); chrome::BookmarkCurrentTab(browser_);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment