Commit e5c66a4d authored by Kenichi Ishibashi's avatar Kenichi Ishibashi Committed by Chromium LUCI CQ

Stop using GetCoreThreadId() in ServiceWorkerRegistry

The core thread is always the UI thread now.

Bug: 1138155
Change-Id: Iefda8c1a33303f1ce39d1513f91a36b014d40057
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628268Reviewed-by: default avatarMatt Falkenhagen <falken@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843430}
parent 91d1da4d
...@@ -222,7 +222,7 @@ class ServiceWorkerRegistry::StoragePolicyObserver ...@@ -222,7 +222,7 @@ class ServiceWorkerRegistry::StoragePolicyObserver
base::BindOnce(&ServiceWorkerRegistry::OnStoragePolicyChanged, owner_)); base::BindOnce(&ServiceWorkerRegistry::OnStoragePolicyChanged, owner_));
} }
// |owner_| is dereferenced on the core thread. This shouldn't be dereferenced // |owner_| is dereferenced on the UI thread. This shouldn't be dereferenced
// on the IO thread. // on the IO thread.
base::WeakPtr<ServiceWorkerRegistry> owner_; base::WeakPtr<ServiceWorkerRegistry> owner_;
const scoped_refptr<storage::SpecialStoragePolicy> special_storage_policy_; const scoped_refptr<storage::SpecialStoragePolicy> special_storage_policy_;
...@@ -233,7 +233,7 @@ ServiceWorkerRegistry::ServiceWorkerRegistry( ...@@ -233,7 +233,7 @@ ServiceWorkerRegistry::ServiceWorkerRegistry(
storage::SpecialStoragePolicy* special_storage_policy) storage::SpecialStoragePolicy* special_storage_policy)
: context_(context), : context_(context),
special_storage_policy_(special_storage_policy) { special_storage_policy_(special_storage_policy) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(context_); DCHECK(context_);
Start(); Start();
} }
...@@ -243,7 +243,7 @@ ServiceWorkerRegistry::ServiceWorkerRegistry( ...@@ -243,7 +243,7 @@ ServiceWorkerRegistry::ServiceWorkerRegistry(
ServiceWorkerRegistry* old_registry) ServiceWorkerRegistry* old_registry)
: context_(context), : context_(context),
special_storage_policy_(old_registry->special_storage_policy_) { special_storage_policy_(old_registry->special_storage_policy_) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(context_); DCHECK(context_);
Start(); Start();
} }
...@@ -253,7 +253,7 @@ ServiceWorkerRegistry::~ServiceWorkerRegistry() = default; ...@@ -253,7 +253,7 @@ ServiceWorkerRegistry::~ServiceWorkerRegistry() = default;
void ServiceWorkerRegistry::CreateNewRegistration( void ServiceWorkerRegistry::CreateNewRegistration(
blink::mojom::ServiceWorkerRegistrationOptions options, blink::mojom::ServiceWorkerRegistrationOptions options,
NewRegistrationCallback callback) { NewRegistrationCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl::GetNewRegistrationId, &storage::mojom::ServiceWorkerStorageControl::GetNewRegistrationId,
base::BindRepeating(&ServiceWorkerRegistry::DidGetNewRegistrationId, base::BindRepeating(&ServiceWorkerRegistry::DidGetNewRegistrationId,
...@@ -266,7 +266,7 @@ void ServiceWorkerRegistry::CreateNewVersion( ...@@ -266,7 +266,7 @@ void ServiceWorkerRegistry::CreateNewVersion(
const GURL& script_url, const GURL& script_url,
blink::mojom::ScriptType script_type, blink::mojom::ScriptType script_type,
NewVersionCallback callback) { NewVersionCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(registration); DCHECK(registration);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl::GetNewVersionId, &storage::mojom::ServiceWorkerStorageControl::GetNewVersionId,
...@@ -278,7 +278,7 @@ void ServiceWorkerRegistry::CreateNewVersion( ...@@ -278,7 +278,7 @@ void ServiceWorkerRegistry::CreateNewVersion(
void ServiceWorkerRegistry::FindRegistrationForClientUrl( void ServiceWorkerRegistry::FindRegistrationForClientUrl(
const GURL& client_url, const GURL& client_url,
FindRegistrationCallback callback) { FindRegistrationCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
// To connect this TRACE_EVENT with the callback, Time::Now() is used as a // To connect this TRACE_EVENT with the callback, Time::Now() is used as a
// trace event id. // trace event id.
int64_t trace_event_id = int64_t trace_event_id =
...@@ -299,7 +299,7 @@ void ServiceWorkerRegistry::FindRegistrationForClientUrl( ...@@ -299,7 +299,7 @@ void ServiceWorkerRegistry::FindRegistrationForClientUrl(
void ServiceWorkerRegistry::FindRegistrationForScope( void ServiceWorkerRegistry::FindRegistrationForScope(
const GURL& scope, const GURL& scope,
FindRegistrationCallback callback) { FindRegistrationCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (is_storage_disabled_) { if (is_storage_disabled_) {
RunSoon( RunSoon(
FROM_HERE, FROM_HERE,
...@@ -341,7 +341,7 @@ void ServiceWorkerRegistry::FindRegistrationForIdOnly( ...@@ -341,7 +341,7 @@ void ServiceWorkerRegistry::FindRegistrationForIdOnly(
void ServiceWorkerRegistry::GetRegistrationsForOrigin( void ServiceWorkerRegistry::GetRegistrationsForOrigin(
const url::Origin& origin, const url::Origin& origin,
GetRegistrationsCallback callback) { GetRegistrationsCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl::GetRegistrationsForOrigin, &storage::mojom::ServiceWorkerStorageControl::GetRegistrationsForOrigin,
base::BindRepeating(&ServiceWorkerRegistry::DidGetRegistrationsForOrigin, base::BindRepeating(&ServiceWorkerRegistry::DidGetRegistrationsForOrigin,
...@@ -353,7 +353,7 @@ void ServiceWorkerRegistry::GetRegistrationsForOrigin( ...@@ -353,7 +353,7 @@ void ServiceWorkerRegistry::GetRegistrationsForOrigin(
void ServiceWorkerRegistry::GetStorageUsageForOrigin( void ServiceWorkerRegistry::GetStorageUsageForOrigin(
const url::Origin& origin, const url::Origin& origin,
GetStorageUsageForOriginCallback callback) { GetStorageUsageForOriginCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl::GetUsageForOrigin, &storage::mojom::ServiceWorkerStorageControl::GetUsageForOrigin,
base::BindRepeating(&ServiceWorkerRegistry::DidGetStorageUsageForOrigin, base::BindRepeating(&ServiceWorkerRegistry::DidGetStorageUsageForOrigin,
...@@ -363,7 +363,7 @@ void ServiceWorkerRegistry::GetStorageUsageForOrigin( ...@@ -363,7 +363,7 @@ void ServiceWorkerRegistry::GetStorageUsageForOrigin(
void ServiceWorkerRegistry::GetAllRegistrationsInfos( void ServiceWorkerRegistry::GetAllRegistrationsInfos(
GetRegistrationsInfosCallback callback) { GetRegistrationsInfosCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl:: &storage::mojom::ServiceWorkerStorageControl::
GetAllRegistrationsDeprecated, GetAllRegistrationsDeprecated,
...@@ -373,7 +373,7 @@ void ServiceWorkerRegistry::GetAllRegistrationsInfos( ...@@ -373,7 +373,7 @@ void ServiceWorkerRegistry::GetAllRegistrationsInfos(
ServiceWorkerRegistration* ServiceWorkerRegistry::GetUninstallingRegistration( ServiceWorkerRegistration* ServiceWorkerRegistry::GetUninstallingRegistration(
const GURL& scope) { const GURL& scope) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
// TODO(bashi): Should we check state of ServiceWorkerStorage? // TODO(bashi): Should we check state of ServiceWorkerStorage?
for (const auto& registration : uninstalling_registrations_) { for (const auto& registration : uninstalling_registrations_) {
if (registration.second->scope() == scope) { if (registration.second->scope() == scope) {
...@@ -387,7 +387,7 @@ ServiceWorkerRegistration* ServiceWorkerRegistry::GetUninstallingRegistration( ...@@ -387,7 +387,7 @@ ServiceWorkerRegistration* ServiceWorkerRegistry::GetUninstallingRegistration(
std::vector<scoped_refptr<ServiceWorkerRegistration>> std::vector<scoped_refptr<ServiceWorkerRegistration>>
ServiceWorkerRegistry::GetUninstallingRegistrationsForOrigin( ServiceWorkerRegistry::GetUninstallingRegistrationsForOrigin(
const url::Origin& origin) { const url::Origin& origin) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
std::vector<scoped_refptr<ServiceWorkerRegistration>> results; std::vector<scoped_refptr<ServiceWorkerRegistration>> results;
for (const auto& registration : uninstalling_registrations_) { for (const auto& registration : uninstalling_registrations_) {
if (url::Origin::Create(registration.second->scope()) == origin) { if (url::Origin::Create(registration.second->scope()) == origin) {
...@@ -401,7 +401,7 @@ void ServiceWorkerRegistry::StoreRegistration( ...@@ -401,7 +401,7 @@ void ServiceWorkerRegistry::StoreRegistration(
ServiceWorkerRegistration* registration, ServiceWorkerRegistration* registration,
ServiceWorkerVersion* version, ServiceWorkerVersion* version,
StatusCallback callback) { StatusCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(registration); DCHECK(registration);
DCHECK(version); DCHECK(version);
...@@ -476,7 +476,7 @@ void ServiceWorkerRegistry::DeleteRegistration( ...@@ -476,7 +476,7 @@ void ServiceWorkerRegistry::DeleteRegistration(
scoped_refptr<ServiceWorkerRegistration> registration, scoped_refptr<ServiceWorkerRegistration> registration,
const GURL& origin, const GURL& origin,
StatusCallback callback) { StatusCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (is_storage_disabled_) { if (is_storage_disabled_) {
RunSoon(FROM_HERE, RunSoon(FROM_HERE,
base::BindOnce(std::move(callback), base::BindOnce(std::move(callback),
...@@ -501,7 +501,7 @@ void ServiceWorkerRegistry::DeleteRegistration( ...@@ -501,7 +501,7 @@ void ServiceWorkerRegistry::DeleteRegistration(
void ServiceWorkerRegistry::NotifyInstallingRegistration( void ServiceWorkerRegistry::NotifyInstallingRegistration(
ServiceWorkerRegistration* registration) { ServiceWorkerRegistration* registration) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(installing_registrations_.find(registration->id()) == DCHECK(installing_registrations_.find(registration->id()) ==
installing_registrations_.end()); installing_registrations_.end());
installing_registrations_[registration->id()] = registration; installing_registrations_[registration->id()] = registration;
...@@ -511,7 +511,7 @@ void ServiceWorkerRegistry::NotifyDoneInstallingRegistration( ...@@ -511,7 +511,7 @@ void ServiceWorkerRegistry::NotifyDoneInstallingRegistration(
ServiceWorkerRegistration* registration, ServiceWorkerRegistration* registration,
ServiceWorkerVersion* version, ServiceWorkerVersion* version,
blink::ServiceWorkerStatusCode status) { blink::ServiceWorkerStatusCode status) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
installing_registrations_.erase(registration->id()); installing_registrations_.erase(registration->id());
if (status != blink::ServiceWorkerStatusCode::kOk && version) { if (status != blink::ServiceWorkerStatusCode::kOk && version) {
ResourceList resources; ResourceList resources;
...@@ -527,7 +527,7 @@ void ServiceWorkerRegistry::NotifyDoneInstallingRegistration( ...@@ -527,7 +527,7 @@ void ServiceWorkerRegistry::NotifyDoneInstallingRegistration(
void ServiceWorkerRegistry::NotifyDoneUninstallingRegistration( void ServiceWorkerRegistry::NotifyDoneUninstallingRegistration(
ServiceWorkerRegistration* registration, ServiceWorkerRegistration* registration,
ServiceWorkerRegistration::Status new_status) { ServiceWorkerRegistration::Status new_status) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
registration->SetStatus(new_status); registration->SetStatus(new_status);
uninstalling_registrations_.erase(registration->id()); uninstalling_registrations_.erase(registration->id());
} }
...@@ -535,7 +535,7 @@ void ServiceWorkerRegistry::NotifyDoneUninstallingRegistration( ...@@ -535,7 +535,7 @@ void ServiceWorkerRegistry::NotifyDoneUninstallingRegistration(
void ServiceWorkerRegistry::UpdateToActiveState(int64_t registration_id, void ServiceWorkerRegistry::UpdateToActiveState(int64_t registration_id,
const GURL& origin, const GURL& origin,
StatusCallback callback) { StatusCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl::UpdateToActiveState, &storage::mojom::ServiceWorkerStorageControl::UpdateToActiveState,
base::BindRepeating(&ServiceWorkerRegistry::DidUpdateRegistration, base::BindRepeating(&ServiceWorkerRegistry::DidUpdateRegistration,
...@@ -548,7 +548,7 @@ void ServiceWorkerRegistry::UpdateLastUpdateCheckTime( ...@@ -548,7 +548,7 @@ void ServiceWorkerRegistry::UpdateLastUpdateCheckTime(
const GURL& origin, const GURL& origin,
base::Time last_update_check_time, base::Time last_update_check_time,
StatusCallback callback) { StatusCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl::UpdateLastUpdateCheckTime, &storage::mojom::ServiceWorkerStorageControl::UpdateLastUpdateCheckTime,
base::BindRepeating(&ServiceWorkerRegistry::DidUpdateRegistration, base::BindRepeating(&ServiceWorkerRegistry::DidUpdateRegistration,
...@@ -562,7 +562,7 @@ void ServiceWorkerRegistry::UpdateNavigationPreloadEnabled( ...@@ -562,7 +562,7 @@ void ServiceWorkerRegistry::UpdateNavigationPreloadEnabled(
const GURL& origin, const GURL& origin,
bool enable, bool enable,
StatusCallback callback) { StatusCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl:: &storage::mojom::ServiceWorkerStorageControl::
UpdateNavigationPreloadEnabled, UpdateNavigationPreloadEnabled,
...@@ -577,7 +577,7 @@ void ServiceWorkerRegistry::UpdateNavigationPreloadHeader( ...@@ -577,7 +577,7 @@ void ServiceWorkerRegistry::UpdateNavigationPreloadHeader(
const GURL& origin, const GURL& origin,
const std::string& value, const std::string& value,
StatusCallback callback) { StatusCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl:: &storage::mojom::ServiceWorkerStorageControl::
UpdateNavigationPreloadHeader, UpdateNavigationPreloadHeader,
...@@ -588,7 +588,7 @@ void ServiceWorkerRegistry::UpdateNavigationPreloadHeader( ...@@ -588,7 +588,7 @@ void ServiceWorkerRegistry::UpdateNavigationPreloadHeader(
void ServiceWorkerRegistry::StoreUncommittedResourceId(int64_t resource_id, void ServiceWorkerRegistry::StoreUncommittedResourceId(int64_t resource_id,
const GURL& origin) { const GURL& origin) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl::StoreUncommittedResourceId, &storage::mojom::ServiceWorkerStorageControl::StoreUncommittedResourceId,
base::BindRepeating( base::BindRepeating(
...@@ -598,7 +598,7 @@ void ServiceWorkerRegistry::StoreUncommittedResourceId(int64_t resource_id, ...@@ -598,7 +598,7 @@ void ServiceWorkerRegistry::StoreUncommittedResourceId(int64_t resource_id,
} }
void ServiceWorkerRegistry::DoomUncommittedResource(int64_t resource_id) { void ServiceWorkerRegistry::DoomUncommittedResource(int64_t resource_id) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
std::vector<int64_t> resource_ids = {resource_id}; std::vector<int64_t> resource_ids = {resource_id};
DoomUncommittedResources(resource_ids); DoomUncommittedResources(resource_ids);
} }
...@@ -606,7 +606,7 @@ void ServiceWorkerRegistry::DoomUncommittedResource(int64_t resource_id) { ...@@ -606,7 +606,7 @@ void ServiceWorkerRegistry::DoomUncommittedResource(int64_t resource_id) {
void ServiceWorkerRegistry::GetUserData(int64_t registration_id, void ServiceWorkerRegistry::GetUserData(int64_t registration_id,
const std::vector<std::string>& keys, const std::vector<std::string>& keys,
GetUserDataCallback callback) { GetUserDataCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl::GetUserData, &storage::mojom::ServiceWorkerStorageControl::GetUserData,
base::BindRepeating(&ServiceWorkerRegistry::DidGetUserData, base::BindRepeating(&ServiceWorkerRegistry::DidGetUserData,
...@@ -618,7 +618,7 @@ void ServiceWorkerRegistry::GetUserDataByKeyPrefix( ...@@ -618,7 +618,7 @@ void ServiceWorkerRegistry::GetUserDataByKeyPrefix(
int64_t registration_id, int64_t registration_id,
const std::string& key_prefix, const std::string& key_prefix,
GetUserDataCallback callback) { GetUserDataCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl::GetUserDataByKeyPrefix, &storage::mojom::ServiceWorkerStorageControl::GetUserDataByKeyPrefix,
base::BindRepeating(&ServiceWorkerRegistry::DidGetUserData, base::BindRepeating(&ServiceWorkerRegistry::DidGetUserData,
...@@ -630,7 +630,7 @@ void ServiceWorkerRegistry::GetUserKeysAndDataByKeyPrefix( ...@@ -630,7 +630,7 @@ void ServiceWorkerRegistry::GetUserKeysAndDataByKeyPrefix(
int64_t registration_id, int64_t registration_id,
const std::string& key_prefix, const std::string& key_prefix,
GetUserKeysAndDataCallback callback) { GetUserKeysAndDataCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl:: &storage::mojom::ServiceWorkerStorageControl::
GetUserKeysAndDataByKeyPrefix, GetUserKeysAndDataByKeyPrefix,
...@@ -644,7 +644,7 @@ void ServiceWorkerRegistry::StoreUserData( ...@@ -644,7 +644,7 @@ void ServiceWorkerRegistry::StoreUserData(
const url::Origin& origin, const url::Origin& origin,
const std::vector<std::pair<std::string, std::string>>& key_value_pairs, const std::vector<std::pair<std::string, std::string>>& key_value_pairs,
StatusCallback callback) { StatusCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (registration_id == blink::mojom::kInvalidServiceWorkerRegistrationId || if (registration_id == blink::mojom::kInvalidServiceWorkerRegistrationId ||
key_value_pairs.empty()) { key_value_pairs.empty()) {
RunSoon(FROM_HERE, RunSoon(FROM_HERE,
...@@ -673,7 +673,7 @@ void ServiceWorkerRegistry::StoreUserData( ...@@ -673,7 +673,7 @@ void ServiceWorkerRegistry::StoreUserData(
void ServiceWorkerRegistry::ClearUserData(int64_t registration_id, void ServiceWorkerRegistry::ClearUserData(int64_t registration_id,
const std::vector<std::string>& keys, const std::vector<std::string>& keys,
StatusCallback callback) { StatusCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl::ClearUserData, &storage::mojom::ServiceWorkerStorageControl::ClearUserData,
base::BindRepeating(&ServiceWorkerRegistry::DidClearUserData, base::BindRepeating(&ServiceWorkerRegistry::DidClearUserData,
...@@ -685,7 +685,7 @@ void ServiceWorkerRegistry::ClearUserDataByKeyPrefixes( ...@@ -685,7 +685,7 @@ void ServiceWorkerRegistry::ClearUserDataByKeyPrefixes(
int64_t registration_id, int64_t registration_id,
const std::vector<std::string>& key_prefixes, const std::vector<std::string>& key_prefixes,
StatusCallback callback) { StatusCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl::ClearUserDataByKeyPrefixes, &storage::mojom::ServiceWorkerStorageControl::ClearUserDataByKeyPrefixes,
base::BindRepeating(&ServiceWorkerRegistry::DidClearUserData, base::BindRepeating(&ServiceWorkerRegistry::DidClearUserData,
...@@ -696,7 +696,7 @@ void ServiceWorkerRegistry::ClearUserDataByKeyPrefixes( ...@@ -696,7 +696,7 @@ void ServiceWorkerRegistry::ClearUserDataByKeyPrefixes(
void ServiceWorkerRegistry::ClearUserDataForAllRegistrationsByKeyPrefix( void ServiceWorkerRegistry::ClearUserDataForAllRegistrationsByKeyPrefix(
const std::string& key_prefix, const std::string& key_prefix,
StatusCallback callback) { StatusCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl:: &storage::mojom::ServiceWorkerStorageControl::
ClearUserDataForAllRegistrationsByKeyPrefix, ClearUserDataForAllRegistrationsByKeyPrefix,
...@@ -708,7 +708,7 @@ void ServiceWorkerRegistry::ClearUserDataForAllRegistrationsByKeyPrefix( ...@@ -708,7 +708,7 @@ void ServiceWorkerRegistry::ClearUserDataForAllRegistrationsByKeyPrefix(
void ServiceWorkerRegistry::GetUserDataForAllRegistrations( void ServiceWorkerRegistry::GetUserDataForAllRegistrations(
const std::string& key, const std::string& key,
GetUserDataForAllRegistrationsCallback callback) { GetUserDataForAllRegistrationsCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl:: &storage::mojom::ServiceWorkerStorageControl::
GetUserDataForAllRegistrations, GetUserDataForAllRegistrations,
...@@ -721,7 +721,7 @@ void ServiceWorkerRegistry::GetUserDataForAllRegistrations( ...@@ -721,7 +721,7 @@ void ServiceWorkerRegistry::GetUserDataForAllRegistrations(
void ServiceWorkerRegistry::GetUserDataForAllRegistrationsByKeyPrefix( void ServiceWorkerRegistry::GetUserDataForAllRegistrationsByKeyPrefix(
const std::string& key_prefix, const std::string& key_prefix,
GetUserDataForAllRegistrationsCallback callback) { GetUserDataForAllRegistrationsCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl:: &storage::mojom::ServiceWorkerStorageControl::
GetUserDataForAllRegistrationsByKeyPrefix, GetUserDataForAllRegistrationsByKeyPrefix,
...@@ -733,7 +733,7 @@ void ServiceWorkerRegistry::GetUserDataForAllRegistrationsByKeyPrefix( ...@@ -733,7 +733,7 @@ void ServiceWorkerRegistry::GetUserDataForAllRegistrationsByKeyPrefix(
void ServiceWorkerRegistry::GetRegisteredOrigins( void ServiceWorkerRegistry::GetRegisteredOrigins(
GetRegisteredOriginsCallback callback) { GetRegisteredOriginsCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl::GetRegisteredOrigins, &storage::mojom::ServiceWorkerStorageControl::GetRegisteredOrigins,
base::BindRepeating(&ServiceWorkerRegistry::DidGetRegisteredOrigins, base::BindRepeating(&ServiceWorkerRegistry::DidGetRegisteredOrigins,
...@@ -741,7 +741,7 @@ void ServiceWorkerRegistry::GetRegisteredOrigins( ...@@ -741,7 +741,7 @@ void ServiceWorkerRegistry::GetRegisteredOrigins(
} }
void ServiceWorkerRegistry::PerformStorageCleanup(base::OnceClosure callback) { void ServiceWorkerRegistry::PerformStorageCleanup(base::OnceClosure callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl::PerformStorageCleanup, &storage::mojom::ServiceWorkerStorageControl::PerformStorageCleanup,
base::BindRepeating(&ServiceWorkerRegistry::DidPerformStorageCleanup, base::BindRepeating(&ServiceWorkerRegistry::DidPerformStorageCleanup,
...@@ -758,7 +758,7 @@ void ServiceWorkerRegistry::PrepareForDeleteAndStartOver() { ...@@ -758,7 +758,7 @@ void ServiceWorkerRegistry::PrepareForDeleteAndStartOver() {
} }
void ServiceWorkerRegistry::DeleteAndStartOver(StatusCallback callback) { void ServiceWorkerRegistry::DeleteAndStartOver(StatusCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl::Delete, &storage::mojom::ServiceWorkerStorageControl::Delete,
base::BindRepeating(&ServiceWorkerRegistry::DidDeleteAndStartOver, base::BindRepeating(&ServiceWorkerRegistry::DidDeleteAndStartOver,
...@@ -771,7 +771,7 @@ void ServiceWorkerRegistry::DisableStorageForTesting( ...@@ -771,7 +771,7 @@ void ServiceWorkerRegistry::DisableStorageForTesting(
} }
void ServiceWorkerRegistry::Start() { void ServiceWorkerRegistry::Start() {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (special_storage_policy_) { if (special_storage_policy_) {
storage_policy_observer_ = base::SequenceBound<StoragePolicyObserver>( storage_policy_observer_ = base::SequenceBound<StoragePolicyObserver>(
base::CreateSequencedTaskRunner(BrowserThread::IO), base::CreateSequencedTaskRunner(BrowserThread::IO),
...@@ -788,7 +788,7 @@ void ServiceWorkerRegistry::FindRegistrationForIdInternal( ...@@ -788,7 +788,7 @@ void ServiceWorkerRegistry::FindRegistrationForIdInternal(
int64_t registration_id, int64_t registration_id,
const base::Optional<url::Origin>& origin, const base::Optional<url::Origin>& origin,
FindRegistrationCallback callback) { FindRegistrationCallback callback) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
// Registration lookup is expected to abort when storage is disabled. // Registration lookup is expected to abort when storage is disabled.
if (is_storage_disabled_) { if (is_storage_disabled_) {
CompleteFindNow(nullptr, blink::ServiceWorkerStatusCode::kErrorAbort, CompleteFindNow(nullptr, blink::ServiceWorkerStatusCode::kErrorAbort,
...@@ -819,7 +819,7 @@ void ServiceWorkerRegistry::FindRegistrationForIdInternal( ...@@ -819,7 +819,7 @@ void ServiceWorkerRegistry::FindRegistrationForIdInternal(
ServiceWorkerRegistration* ServiceWorkerRegistration*
ServiceWorkerRegistry::FindInstallingRegistrationForClientUrl( ServiceWorkerRegistry::FindInstallingRegistrationForClientUrl(
const GURL& client_url) { const GURL& client_url) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(!client_url.has_ref()); DCHECK(!client_url.has_ref());
blink::ServiceWorkerLongestScopeMatcher matcher(client_url); blink::ServiceWorkerLongestScopeMatcher matcher(client_url);
...@@ -835,7 +835,7 @@ ServiceWorkerRegistry::FindInstallingRegistrationForClientUrl( ...@@ -835,7 +835,7 @@ ServiceWorkerRegistry::FindInstallingRegistrationForClientUrl(
ServiceWorkerRegistration* ServiceWorkerRegistration*
ServiceWorkerRegistry::FindInstallingRegistrationForScope(const GURL& scope) { ServiceWorkerRegistry::FindInstallingRegistrationForScope(const GURL& scope) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
for (const auto& registration : installing_registrations_) for (const auto& registration : installing_registrations_)
if (registration.second->scope() == scope) if (registration.second->scope() == scope)
return registration.second.get(); return registration.second.get();
...@@ -845,7 +845,7 @@ ServiceWorkerRegistry::FindInstallingRegistrationForScope(const GURL& scope) { ...@@ -845,7 +845,7 @@ ServiceWorkerRegistry::FindInstallingRegistrationForScope(const GURL& scope) {
ServiceWorkerRegistration* ServiceWorkerRegistration*
ServiceWorkerRegistry::FindInstallingRegistrationForId( ServiceWorkerRegistry::FindInstallingRegistrationForId(
int64_t registration_id) { int64_t registration_id) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
RegistrationRefsById::const_iterator found = RegistrationRefsById::const_iterator found =
installing_registrations_.find(registration_id); installing_registrations_.find(registration_id);
if (found == installing_registrations_.end()) if (found == installing_registrations_.end())
...@@ -859,7 +859,7 @@ ServiceWorkerRegistry::GetOrCreateRegistration( ...@@ -859,7 +859,7 @@ ServiceWorkerRegistry::GetOrCreateRegistration(
const ResourceList& resources, const ResourceList& resources,
mojo::PendingRemote<storage::mojom::ServiceWorkerLiveVersionRef> mojo::PendingRemote<storage::mojom::ServiceWorkerLiveVersionRef>
version_reference) { version_reference) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
scoped_refptr<ServiceWorkerRegistration> registration = scoped_refptr<ServiceWorkerRegistration> registration =
context_->GetLiveRegistration(data.registration_id); context_->GetLiveRegistration(data.registration_id);
if (registration) if (registration)
...@@ -913,7 +913,7 @@ ServiceWorkerRegistry::GetOrCreateRegistration( ...@@ -913,7 +913,7 @@ ServiceWorkerRegistry::GetOrCreateRegistration(
base::Optional<scoped_refptr<ServiceWorkerRegistration>> base::Optional<scoped_refptr<ServiceWorkerRegistration>>
ServiceWorkerRegistry::FindFromLiveRegistrationsForId(int64_t registration_id) { ServiceWorkerRegistry::FindFromLiveRegistrationsForId(int64_t registration_id) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
scoped_refptr<ServiceWorkerRegistration> registration = scoped_refptr<ServiceWorkerRegistration> registration =
context_->GetLiveRegistration(registration_id); context_->GetLiveRegistration(registration_id);
if (registration) { if (registration) {
...@@ -934,7 +934,7 @@ ServiceWorkerRegistry::FindFromLiveRegistrationsForId(int64_t registration_id) { ...@@ -934,7 +934,7 @@ ServiceWorkerRegistry::FindFromLiveRegistrationsForId(int64_t registration_id) {
void ServiceWorkerRegistry::DoomUncommittedResources( void ServiceWorkerRegistry::DoomUncommittedResources(
const std::vector<int64_t>& resource_ids) { const std::vector<int64_t>& resource_ids) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
CreateInvokerAndStartRemoteCall( CreateInvokerAndStartRemoteCall(
&storage::mojom::ServiceWorkerStorageControl::DoomUncommittedResources, &storage::mojom::ServiceWorkerStorageControl::DoomUncommittedResources,
base::BindRepeating(&ServiceWorkerRegistry::DidDoomUncommittedResourceIds, base::BindRepeating(&ServiceWorkerRegistry::DidDoomUncommittedResourceIds,
...@@ -949,7 +949,7 @@ void ServiceWorkerRegistry::DidFindRegistrationForClientUrl( ...@@ -949,7 +949,7 @@ void ServiceWorkerRegistry::DidFindRegistrationForClientUrl(
uint64_t call_id, uint64_t call_id,
storage::mojom::ServiceWorkerDatabaseStatus database_status, storage::mojom::ServiceWorkerDatabaseStatus database_status,
storage::mojom::ServiceWorkerFindRegistrationResultPtr result) { storage::mojom::ServiceWorkerFindRegistrationResultPtr result) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
if (database_status != storage::mojom::ServiceWorkerDatabaseStatus::kOk && if (database_status != storage::mojom::ServiceWorkerDatabaseStatus::kOk &&
database_status != database_status !=
...@@ -1003,7 +1003,7 @@ void ServiceWorkerRegistry::DidFindRegistrationForScope( ...@@ -1003,7 +1003,7 @@ void ServiceWorkerRegistry::DidFindRegistrationForScope(
uint64_t call_id, uint64_t call_id,
storage::mojom::ServiceWorkerDatabaseStatus database_status, storage::mojom::ServiceWorkerDatabaseStatus database_status,
storage::mojom::ServiceWorkerFindRegistrationResultPtr result) { storage::mojom::ServiceWorkerFindRegistrationResultPtr result) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
if (database_status != storage::mojom::ServiceWorkerDatabaseStatus::kOk && if (database_status != storage::mojom::ServiceWorkerDatabaseStatus::kOk &&
database_status != database_status !=
...@@ -1033,7 +1033,7 @@ void ServiceWorkerRegistry::DidFindRegistrationForId( ...@@ -1033,7 +1033,7 @@ void ServiceWorkerRegistry::DidFindRegistrationForId(
uint64_t call_id, uint64_t call_id,
storage::mojom::ServiceWorkerDatabaseStatus database_status, storage::mojom::ServiceWorkerDatabaseStatus database_status,
storage::mojom::ServiceWorkerFindRegistrationResultPtr result) { storage::mojom::ServiceWorkerFindRegistrationResultPtr result) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
if (database_status != storage::mojom::ServiceWorkerDatabaseStatus::kOk && if (database_status != storage::mojom::ServiceWorkerDatabaseStatus::kOk &&
database_status != database_status !=
...@@ -1075,7 +1075,7 @@ void ServiceWorkerRegistry::DidGetRegistrationsForOrigin( ...@@ -1075,7 +1075,7 @@ void ServiceWorkerRegistry::DidGetRegistrationsForOrigin(
storage::mojom::ServiceWorkerDatabaseStatus database_status, storage::mojom::ServiceWorkerDatabaseStatus database_status,
std::vector<storage::mojom::ServiceWorkerFindRegistrationResultPtr> std::vector<storage::mojom::ServiceWorkerFindRegistrationResultPtr>
entries) { entries) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
blink::ServiceWorkerStatusCode status = blink::ServiceWorkerStatusCode status =
...@@ -1118,7 +1118,7 @@ void ServiceWorkerRegistry::DidGetAllRegistrations( ...@@ -1118,7 +1118,7 @@ void ServiceWorkerRegistry::DidGetAllRegistrations(
uint64_t call_id, uint64_t call_id,
storage::mojom::ServiceWorkerDatabaseStatus database_status, storage::mojom::ServiceWorkerDatabaseStatus database_status,
RegistrationList registration_data_list) { RegistrationList registration_data_list) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
blink::ServiceWorkerStatusCode status = blink::ServiceWorkerStatusCode status =
DatabaseStatusToStatusCode(database_status); DatabaseStatusToStatusCode(database_status);
...@@ -1214,7 +1214,7 @@ void ServiceWorkerRegistry::DidGetStorageUsageForOrigin( ...@@ -1214,7 +1214,7 @@ void ServiceWorkerRegistry::DidGetStorageUsageForOrigin(
uint64_t call_id, uint64_t call_id,
storage::mojom::ServiceWorkerDatabaseStatus database_status, storage::mojom::ServiceWorkerDatabaseStatus database_status,
int64_t usage) { int64_t usage) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
blink::ServiceWorkerStatusCode status = blink::ServiceWorkerStatusCode status =
DatabaseStatusToStatusCode(database_status); DatabaseStatusToStatusCode(database_status);
...@@ -1228,7 +1228,7 @@ void ServiceWorkerRegistry::DidStoreRegistration( ...@@ -1228,7 +1228,7 @@ void ServiceWorkerRegistry::DidStoreRegistration(
StatusCallback callback, StatusCallback callback,
uint64_t call_id, uint64_t call_id,
storage::mojom::ServiceWorkerDatabaseStatus database_status) { storage::mojom::ServiceWorkerDatabaseStatus database_status) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
blink::ServiceWorkerStatusCode status = blink::ServiceWorkerStatusCode status =
DatabaseStatusToStatusCode(database_status); DatabaseStatusToStatusCode(database_status);
...@@ -1263,7 +1263,7 @@ void ServiceWorkerRegistry::DidDeleteRegistration( ...@@ -1263,7 +1263,7 @@ void ServiceWorkerRegistry::DidDeleteRegistration(
uint64_t call_id, uint64_t call_id,
storage::mojom::ServiceWorkerDatabaseStatus database_status, storage::mojom::ServiceWorkerDatabaseStatus database_status,
ServiceWorkerStorage::OriginState origin_state) { ServiceWorkerStorage::OriginState origin_state) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
blink::ServiceWorkerStatusCode status = blink::ServiceWorkerStatusCode status =
DatabaseStatusToStatusCode(database_status); DatabaseStatusToStatusCode(database_status);
...@@ -1294,7 +1294,7 @@ void ServiceWorkerRegistry::DidUpdateRegistration( ...@@ -1294,7 +1294,7 @@ void ServiceWorkerRegistry::DidUpdateRegistration(
StatusCallback callback, StatusCallback callback,
uint64_t call_id, uint64_t call_id,
storage::mojom::ServiceWorkerDatabaseStatus status) { storage::mojom::ServiceWorkerDatabaseStatus status) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
if (status != storage::mojom::ServiceWorkerDatabaseStatus::kOk && if (status != storage::mojom::ServiceWorkerDatabaseStatus::kOk &&
status != storage::mojom::ServiceWorkerDatabaseStatus::kErrorNotFound) { status != storage::mojom::ServiceWorkerDatabaseStatus::kErrorNotFound) {
...@@ -1306,7 +1306,7 @@ void ServiceWorkerRegistry::DidUpdateRegistration( ...@@ -1306,7 +1306,7 @@ void ServiceWorkerRegistry::DidUpdateRegistration(
void ServiceWorkerRegistry::DidWriteUncommittedResourceIds( void ServiceWorkerRegistry::DidWriteUncommittedResourceIds(
uint64_t call_id, uint64_t call_id,
storage::mojom::ServiceWorkerDatabaseStatus status) { storage::mojom::ServiceWorkerDatabaseStatus status) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
if (status != storage::mojom::ServiceWorkerDatabaseStatus::kOk) if (status != storage::mojom::ServiceWorkerDatabaseStatus::kOk)
ScheduleDeleteAndStartOver(); ScheduleDeleteAndStartOver();
...@@ -1315,7 +1315,7 @@ void ServiceWorkerRegistry::DidWriteUncommittedResourceIds( ...@@ -1315,7 +1315,7 @@ void ServiceWorkerRegistry::DidWriteUncommittedResourceIds(
void ServiceWorkerRegistry::DidDoomUncommittedResourceIds( void ServiceWorkerRegistry::DidDoomUncommittedResourceIds(
uint64_t call_id, uint64_t call_id,
storage::mojom::ServiceWorkerDatabaseStatus status) { storage::mojom::ServiceWorkerDatabaseStatus status) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
if (status != storage::mojom::ServiceWorkerDatabaseStatus::kOk) if (status != storage::mojom::ServiceWorkerDatabaseStatus::kOk)
ScheduleDeleteAndStartOver(); ScheduleDeleteAndStartOver();
...@@ -1326,7 +1326,7 @@ void ServiceWorkerRegistry::DidGetUserData( ...@@ -1326,7 +1326,7 @@ void ServiceWorkerRegistry::DidGetUserData(
uint64_t call_id, uint64_t call_id,
storage::mojom::ServiceWorkerDatabaseStatus status, storage::mojom::ServiceWorkerDatabaseStatus status,
const std::vector<std::string>& data) { const std::vector<std::string>& data) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
if (status != storage::mojom::ServiceWorkerDatabaseStatus::kOk && if (status != storage::mojom::ServiceWorkerDatabaseStatus::kOk &&
status != storage::mojom::ServiceWorkerDatabaseStatus::kErrorNotFound) { status != storage::mojom::ServiceWorkerDatabaseStatus::kErrorNotFound) {
...@@ -1340,7 +1340,7 @@ void ServiceWorkerRegistry::DidGetUserKeysAndData( ...@@ -1340,7 +1340,7 @@ void ServiceWorkerRegistry::DidGetUserKeysAndData(
uint64_t call_id, uint64_t call_id,
storage::mojom::ServiceWorkerDatabaseStatus status, storage::mojom::ServiceWorkerDatabaseStatus status,
const base::flat_map<std::string, std::string>& data_map) { const base::flat_map<std::string, std::string>& data_map) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
if (status != storage::mojom::ServiceWorkerDatabaseStatus::kOk && if (status != storage::mojom::ServiceWorkerDatabaseStatus::kOk &&
status != storage::mojom::ServiceWorkerDatabaseStatus::kErrorNotFound) { status != storage::mojom::ServiceWorkerDatabaseStatus::kErrorNotFound) {
...@@ -1353,7 +1353,7 @@ void ServiceWorkerRegistry::DidStoreUserData( ...@@ -1353,7 +1353,7 @@ void ServiceWorkerRegistry::DidStoreUserData(
StatusCallback callback, StatusCallback callback,
uint64_t call_id, uint64_t call_id,
storage::mojom::ServiceWorkerDatabaseStatus status) { storage::mojom::ServiceWorkerDatabaseStatus status) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
// |status| can be NOT_FOUND when the associated registration did not exist in // |status| can be NOT_FOUND when the associated registration did not exist in
// the database. In the case, we don't have to schedule the corruption // the database. In the case, we don't have to schedule the corruption
...@@ -1369,7 +1369,7 @@ void ServiceWorkerRegistry::DidClearUserData( ...@@ -1369,7 +1369,7 @@ void ServiceWorkerRegistry::DidClearUserData(
StatusCallback callback, StatusCallback callback,
uint64_t call_id, uint64_t call_id,
storage::mojom::ServiceWorkerDatabaseStatus status) { storage::mojom::ServiceWorkerDatabaseStatus status) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
if (status != storage::mojom::ServiceWorkerDatabaseStatus::kOk) if (status != storage::mojom::ServiceWorkerDatabaseStatus::kOk)
ScheduleDeleteAndStartOver(); ScheduleDeleteAndStartOver();
...@@ -1381,7 +1381,7 @@ void ServiceWorkerRegistry::DidGetUserDataForAllRegistrations( ...@@ -1381,7 +1381,7 @@ void ServiceWorkerRegistry::DidGetUserDataForAllRegistrations(
uint64_t call_id, uint64_t call_id,
storage::mojom::ServiceWorkerDatabaseStatus status, storage::mojom::ServiceWorkerDatabaseStatus status,
std::vector<storage::mojom::ServiceWorkerUserDataPtr> entries) { std::vector<storage::mojom::ServiceWorkerUserDataPtr> entries) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
// TODO(crbug.com/1055677): Update call sites of // TODO(crbug.com/1055677): Update call sites of
// GetUserDataForAllRegistrations so that we can avoid converting mojo struct // GetUserDataForAllRegistrations so that we can avoid converting mojo struct
...@@ -1400,7 +1400,7 @@ void ServiceWorkerRegistry::DidGetNewRegistrationId( ...@@ -1400,7 +1400,7 @@ void ServiceWorkerRegistry::DidGetNewRegistrationId(
NewRegistrationCallback callback, NewRegistrationCallback callback,
uint64_t call_id, uint64_t call_id,
int64_t registration_id) { int64_t registration_id) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
if (registration_id == blink::mojom::kInvalidServiceWorkerRegistrationId) { if (registration_id == blink::mojom::kInvalidServiceWorkerRegistrationId) {
std::move(callback).Run(nullptr); std::move(callback).Run(nullptr);
...@@ -1419,7 +1419,7 @@ void ServiceWorkerRegistry::DidGetNewVersionId( ...@@ -1419,7 +1419,7 @@ void ServiceWorkerRegistry::DidGetNewVersionId(
int64_t version_id, int64_t version_id,
mojo::PendingRemote<storage::mojom::ServiceWorkerLiveVersionRef> mojo::PendingRemote<storage::mojom::ServiceWorkerLiveVersionRef>
version_reference) { version_reference) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
if (version_id == blink::mojom::kInvalidServiceWorkerVersionId) { if (version_id == blink::mojom::kInvalidServiceWorkerVersionId) {
std::move(callback).Run(nullptr); std::move(callback).Run(nullptr);
...@@ -1432,7 +1432,7 @@ void ServiceWorkerRegistry::DidGetNewVersionId( ...@@ -1432,7 +1432,7 @@ void ServiceWorkerRegistry::DidGetNewVersionId(
} }
void ServiceWorkerRegistry::ScheduleDeleteAndStartOver() { void ServiceWorkerRegistry::ScheduleDeleteAndStartOver() {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (!should_schedule_delete_and_start_over_) { if (!should_schedule_delete_and_start_over_) {
// Recovery process has already been scheduled. // Recovery process has already been scheduled.
return; return;
...@@ -1452,7 +1452,7 @@ void ServiceWorkerRegistry::DidDeleteAndStartOver( ...@@ -1452,7 +1452,7 @@ void ServiceWorkerRegistry::DidDeleteAndStartOver(
StatusCallback callback, StatusCallback callback,
uint64_t call_id, uint64_t call_id,
storage::mojom::ServiceWorkerDatabaseStatus status) { storage::mojom::ServiceWorkerDatabaseStatus status) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
remote_storage_control_.reset(); remote_storage_control_.reset();
std::move(callback).Run(DatabaseStatusToStatusCode(status)); std::move(callback).Run(DatabaseStatusToStatusCode(status));
...@@ -1462,33 +1462,33 @@ void ServiceWorkerRegistry::DidGetRegisteredOrigins( ...@@ -1462,33 +1462,33 @@ void ServiceWorkerRegistry::DidGetRegisteredOrigins(
GetRegisteredOriginsCallback callback, GetRegisteredOriginsCallback callback,
uint64_t call_id, uint64_t call_id,
const std::vector<url::Origin>& origins) { const std::vector<url::Origin>& origins) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
std::move(callback).Run(origins); std::move(callback).Run(origins);
} }
void ServiceWorkerRegistry::DidPerformStorageCleanup(base::OnceClosure callback, void ServiceWorkerRegistry::DidPerformStorageCleanup(base::OnceClosure callback,
uint64_t call_id) { uint64_t call_id) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
std::move(callback).Run(); std::move(callback).Run();
} }
void ServiceWorkerRegistry::DidDisable(uint64_t call_id) { void ServiceWorkerRegistry::DidDisable(uint64_t call_id) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
} }
void ServiceWorkerRegistry::DidApplyPolicyUpdates( void ServiceWorkerRegistry::DidApplyPolicyUpdates(
uint64_t call_id, uint64_t call_id,
storage::mojom::ServiceWorkerDatabaseStatus status) { storage::mojom::ServiceWorkerDatabaseStatus status) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
FinishRemoteCall(call_id); FinishRemoteCall(call_id);
} }
void ServiceWorkerRegistry::DidGetRegisteredOriginsOnStartup( void ServiceWorkerRegistry::DidGetRegisteredOriginsOnStartup(
const std::vector<url::Origin>& origins) { const std::vector<url::Origin>& origins) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
for (const auto& origin : origins) for (const auto& origin : origins)
EnsureRegisteredOriginIsTracked(origin); EnsureRegisteredOriginIsTracked(origin);
OnStoragePolicyChanged(); OnStoragePolicyChanged();
...@@ -1496,14 +1496,14 @@ void ServiceWorkerRegistry::DidGetRegisteredOriginsOnStartup( ...@@ -1496,14 +1496,14 @@ void ServiceWorkerRegistry::DidGetRegisteredOriginsOnStartup(
void ServiceWorkerRegistry::EnsureRegisteredOriginIsTracked( void ServiceWorkerRegistry::EnsureRegisteredOriginIsTracked(
const url::Origin& origin) { const url::Origin& origin) {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
auto it = tracked_origins_for_policy_update_.find(origin); auto it = tracked_origins_for_policy_update_.find(origin);
if (it == tracked_origins_for_policy_update_.end()) if (it == tracked_origins_for_policy_update_.end())
tracked_origins_for_policy_update_[origin] = {}; tracked_origins_for_policy_update_[origin] = {};
} }
void ServiceWorkerRegistry::OnStoragePolicyChanged() { void ServiceWorkerRegistry::OnStoragePolicyChanged() {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (is_storage_disabled_) if (is_storage_disabled_)
return; return;
...@@ -1557,7 +1557,7 @@ ServiceWorkerRegistry::GetRemoteStorageControl() { ...@@ -1557,7 +1557,7 @@ ServiceWorkerRegistry::GetRemoteStorageControl() {
void ServiceWorkerRegistry::OnRemoteStorageDisconnected() { void ServiceWorkerRegistry::OnRemoteStorageDisconnected() {
const size_t kMaxRetryCounts = 100; const size_t kMaxRetryCounts = 100;
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
remote_storage_control_.reset(); remote_storage_control_.reset();
...@@ -1588,7 +1588,7 @@ void ServiceWorkerRegistry::OnRemoteStorageDisconnected() { ...@@ -1588,7 +1588,7 @@ void ServiceWorkerRegistry::OnRemoteStorageDisconnected() {
} }
void ServiceWorkerRegistry::DidRecover() { void ServiceWorkerRegistry::DidRecover() {
DCHECK_CURRENTLY_ON(ServiceWorkerContext::GetCoreThreadId()); DCHECK_CURRENTLY_ON(BrowserThread::UI);
RecordRetryCount(recovery_retry_counts_); RecordRetryCount(recovery_retry_counts_);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment