Commit e73c0b43 authored by morrita's avatar morrita Committed by Commit bot

Fix a couple of ipc_channel_mojo_unittest failures.

This should've been covered by commit bot.
The bot configuration chagne will come with a separate CL.

R=viettrungluu@chromium.org, agl@chromium.org
TEST=ipc_channel_mojo_unittest.cc
BUG=

Review URL: https://codereview.chromium.org/976043003

Cr-Commit-Position: refs/heads/master@{#319199}
parent 21dbd12a
...@@ -431,7 +431,7 @@ TEST_F(IPCChannelMojoTest, SendMessagePipe) { ...@@ -431,7 +431,7 @@ TEST_F(IPCChannelMojoTest, SendMessagePipe) {
MULTIPROCESS_IPC_TEST_CLIENT_MAIN(IPCChannelMojoTestSendMessagePipeClient) { MULTIPROCESS_IPC_TEST_CLIENT_MAIN(IPCChannelMojoTestSendMessagePipeClient) {
ListenerThatExpectsMessagePipe listener; ListenerThatExpectsMessagePipe listener;
ChannelClient client(&listener, "IPCChannelMojoTestSendPlatformHandleClient"); ChannelClient client(&listener, "IPCChannelMojoTestSendMessagePipeClient");
client.Connect(); client.Connect();
listener.set_sender(client.channel()); listener.set_sender(client.channel());
...@@ -458,7 +458,7 @@ class IPCChannelMojoDeadHandleTest : public IPCChannelMojoTestBase { ...@@ -458,7 +458,7 @@ class IPCChannelMojoDeadHandleTest : public IPCChannelMojoTestBase {
const base::ProcessHandle client = client_process().Handle(); const base::ProcessHandle client = client_process().Handle();
// Forces GetFileHandleForProcess() fail. It happens occasionally // Forces GetFileHandleForProcess() fail. It happens occasionally
// in production, so we should exercise it somehow. // in production, so we should exercise it somehow.
// TODO(morrita): figure out how to safely test this. // TODO(morrita): figure out how to safely test this. See crbug.com/464109.
// ::CloseHandle(client); // ::CloseHandle(client);
host_->OnClientLaunched(client); host_->OnClientLaunched(client);
return true; return true;
...@@ -482,9 +482,11 @@ TEST_F(IPCChannelMojoDeadHandleTest, InvalidClientHandle) { ...@@ -482,9 +482,11 @@ TEST_F(IPCChannelMojoDeadHandleTest, InvalidClientHandle) {
this->channel()->Close(); this->channel()->Close();
// WaitForClientShutdown() fails as client_hanadle() is already // TODO(morrita): We need CloseHandle() call in DidStartClient(),
// closed. // which has been disabled since crrev.com/843113003, to
EXPECT_FALSE(WaitForClientShutdown()); // make this fail. See crbug.com/464109.
// EXPECT_FALSE(WaitForClientShutdown());
WaitForClientShutdown();
EXPECT_TRUE(listener.has_error()); EXPECT_TRUE(listener.has_error());
DestroyChannel(); DestroyChannel();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment