Commit e74b31d7 authored by Peter Kasting's avatar Peter Kasting Committed by Commit Bot

Use TimeDelta::operator/() more, chrome/ edition.

Bug: 1104532
Change-Id: I5a1ba068f5ed6bbf16e98339d534f5f083c5d058
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355010
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797892}
parent 6099f7bf
...@@ -191,8 +191,7 @@ void ArcAppPerformanceTracingSession::Analyze(base::TimeDelta tracing_period) { ...@@ -191,8 +191,7 @@ void ArcAppPerformanceTracingSession::Analyze(base::TimeDelta tracing_period) {
const size_t lower_position = frame_deltas_.size() / 10; const size_t lower_position = frame_deltas_.size() / 10;
const size_t upper_position = frame_deltas_.size() - 1 - lower_position; const size_t upper_position = frame_deltas_.size() - 1 - lower_position;
const double render_quality = const double render_quality =
frame_deltas_[lower_position].InMicrosecondsF() / frame_deltas_[lower_position] / frame_deltas_[upper_position];
frame_deltas_[upper_position].InMicrosecondsF();
const double fps = frame_deltas_.size() / tracing_period.InSecondsF(); const double fps = frame_deltas_.size() / tracing_period.InSecondsF();
......
...@@ -82,8 +82,7 @@ BuildState* GetBuildState() { ...@@ -82,8 +82,7 @@ BuildState* GetBuildState() {
} }
int GetDaysRounded(base::TimeDelta time) { int GetDaysRounded(base::TimeDelta time) {
return base::ClampRound(time.InSecondsF() / return base::ClampRound(time / base::TimeDelta::FromDays(1));
base::TimeDelta::FromDays(1).InSecondsF());
} }
chromeos::UpdateEngineClient* GetUpdateEngineClient() { chromeos::UpdateEngineClient* GetUpdateEngineClient() {
......
...@@ -141,8 +141,8 @@ TEST_F(PowerMetricsProviderTest, BatteryDischargeCaptureIsEarly) { ...@@ -141,8 +141,8 @@ TEST_F(PowerMetricsProviderTest, BatteryDischargeCaptureIsEarly) {
// |kMetricsCollectionInterval|. // |kMetricsCollectionInterval|.
int discharge = int discharge =
base::ClampFloor((kFirstReading - kSecondReading) * base::ClampFloor((kFirstReading - kSecondReading) *
kMetricsCollectionInterval.InSecondsF() / (kMetricsCollectionInterval /
(second_capture_time - first_capture_time).InSeconds()); (second_capture_time - first_capture_time)));
histogram_tester_.ExpectUniqueSample(kHistogramName, discharge, 1); histogram_tester_.ExpectUniqueSample(kHistogramName, discharge, 1);
} }
...@@ -191,7 +191,7 @@ TEST_F(PowerMetricsProviderTest, BatteryDischargeCaptureIsLate) { ...@@ -191,7 +191,7 @@ TEST_F(PowerMetricsProviderTest, BatteryDischargeCaptureIsLate) {
// |kMetricsCollectionInterval|. // |kMetricsCollectionInterval|.
int discharge = int discharge =
base::ClampFloor((kFirstReading - kSecondReading) * base::ClampFloor((kFirstReading - kSecondReading) *
kMetricsCollectionInterval.InSecondsF() / (kMetricsCollectionInterval /
(second_capture_time - first_capture_time).InSeconds()); (second_capture_time - first_capture_time)));
histogram_tester_.ExpectUniqueSample(kHistogramName, discharge, 1); histogram_tester_.ExpectUniqueSample(kHistogramName, discharge, 1);
} }
...@@ -41,8 +41,7 @@ constexpr double kInactiveTransparency = 0.5; ...@@ -41,8 +41,7 @@ constexpr double kInactiveTransparency = 0.5;
double TimeProportionSince(const base::Time& t1, double TimeProportionSince(const base::Time& t1,
const base::Time& t2, const base::Time& t2,
const base::TimeDelta& d) { const base::TimeDelta& d) {
return std::max( return std::max(0.0, std::min(1.0, (t2 - t1) / d));
0.0, std::min(1.0, (t2 - t1).InMillisecondsF() / d.InMillisecondsF()));
} }
} // namespace } // namespace
......
...@@ -343,15 +343,12 @@ void AccessibilityFocusHighlight::OnAnimationStep(base::TimeTicks timestamp) { ...@@ -343,15 +343,12 @@ void AccessibilityFocusHighlight::OnAnimationStep(base::TimeTicks timestamp) {
float opacity = 1.0f; float opacity = 1.0f;
if (time_since_layer_create < fade_in_time_) { if (time_since_layer_create < fade_in_time_) {
// We're fading in. // We're fading in.
opacity = time_since_layer_create.InSecondsF() / fade_in_time_.InSecondsF(); opacity = time_since_layer_create / fade_in_time_;
} else if (time_since_focus_move > persist_time_) { } else if (time_since_focus_move > persist_time_) {
// Fading out. // Fading out.
float time_since_began_fading = base::TimeDelta time_since_began_fading =
time_since_focus_move.InSecondsF() - time_since_focus_move - (fade_in_time_ + persist_time_);
(fade_in_time_.InSecondsF() + persist_time_.InSecondsF()); opacity = 1.0f - (time_since_began_fading / fade_out_time_);
float fade_out_time_float = fade_out_time_.InSecondsF();
opacity = 1.0f - (time_since_began_fading / fade_out_time_float);
} }
// Layer::SetOpacity will throw an error if we're not within 0...1. // Layer::SetOpacity will throw an error if we're not within 0...1.
......
...@@ -73,8 +73,8 @@ TabAnimationState TabAnimation::GetCurrentState() const { ...@@ -73,8 +73,8 @@ TabAnimationState TabAnimation::GetCurrentState() const {
return target_state_; return target_state_;
const base::TimeDelta elapsed_time = base::TimeTicks::Now() - start_time_; const base::TimeDelta elapsed_time = base::TimeTicks::Now() - start_time_;
const double normalized_elapsed_time = base::ClampToRange( const double normalized_elapsed_time =
elapsed_time.InMillisecondsF() / duration_.InMillisecondsF(), 0.0, 1.0); base::ClampToRange(elapsed_time / duration_, 0.0, 1.0);
const double interpolation_value = gfx::Tween::CalculateValue( const double interpolation_value = gfx::Tween::CalculateValue(
gfx::Tween::Type::EASE_OUT, normalized_elapsed_time); gfx::Tween::Type::EASE_OUT, normalized_elapsed_time);
return TabAnimationState::Interpolate(interpolation_value, initial_state_, return TabAnimationState::Interpolate(interpolation_value, initial_state_,
......
...@@ -193,9 +193,8 @@ PeriodicSamplingScheduler::PeriodicSamplingScheduler( ...@@ -193,9 +193,8 @@ PeriodicSamplingScheduler::PeriodicSamplingScheduler(
base::TimeDelta sampling_duration, base::TimeDelta sampling_duration,
double fraction_of_execution_time_to_sample, double fraction_of_execution_time_to_sample,
base::TimeTicks start_time) base::TimeTicks start_time)
: period_duration_( : period_duration_(sampling_duration /
base::TimeDelta::FromSecondsD(sampling_duration.InSecondsF() / fraction_of_execution_time_to_sample),
fraction_of_execution_time_to_sample)),
sampling_duration_(sampling_duration), sampling_duration_(sampling_duration),
period_start_time_(start_time) { period_start_time_(start_time) {
DCHECK(sampling_duration_ <= period_duration_); DCHECK(sampling_duration_ <= period_duration_);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment