Commit e9236744 authored by jbauman's avatar jbauman Committed by Commit bot

Revert of Set crash key if WM_QUIT message is received on GPU message loop....

Revert of Set crash key if WM_QUIT message is received on GPU message loop. (patchset #3 id:40001 of https://codereview.chromium.org/2342713002/ )

Reason for revert:
We've got enough data now.

Original issue's description:
> Set crash key if WM_QUIT message is received on GPU message loop.
>
> Threads seem to be exiting unexpectedly, so to help debugging set a
> crash key if an unexpected WM_QUIT message is received.
>
> BUG=647068
> TBR=scottmg@chromium.org
>
> Committed: https://crrev.com/18db6b0cc6f81fba74278cfab2856ccb11c0e0c7
> Cr-Commit-Position: refs/heads/master@{#419057}

TBR=dcheng@chromium.org,scottmg@chromium.org,rsesek@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=647068

Review-Url: https://codereview.chromium.org/2346353002
Cr-Commit-Position: refs/heads/master@{#419543}
parent 04e1e5ca
...@@ -9,7 +9,6 @@ ...@@ -9,7 +9,6 @@
#include <limits> #include <limits>
#include "base/debug/crash_logging.h"
#include "base/memory/ptr_util.h" #include "base/memory/ptr_util.h"
#include "base/message_loop/message_loop.h" #include "base/message_loop/message_loop.h"
#include "base/metrics/histogram.h" #include "base/metrics/histogram.h"
...@@ -637,11 +636,6 @@ bool MessagePumpForGpu::ProcessNextMessage() { ...@@ -637,11 +636,6 @@ bool MessagePumpForGpu::ProcessNextMessage() {
return false; return false;
if (msg.message == WM_QUIT) { if (msg.message == WM_QUIT) {
// Try to figure out if we've received a WM_QUIT targeted towards a
// window. http://crbug.com/647068
// TODO(jbauman): Remove once we've got some data about this.
base::debug::SetCrashKeyValue("received_quit_message",
base::StringPrintf("%d", !!msg.hwnd));
// Repost the QUIT message so that it will be retrieved by the primary // Repost the QUIT message so that it will be retrieved by the primary
// GetMessage() loop. // GetMessage() loop.
state_->should_quit = true; state_->should_quit = true;
......
...@@ -105,9 +105,6 @@ size_t RegisterEngineCrashKeys() { ...@@ -105,9 +105,6 @@ size_t RegisterEngineCrashKeys() {
// Temporary for https://crbug.com/630496. // Temporary for https://crbug.com/630496.
{ "swdh_get_registration_cannot_host_url", crash_keys::kLargeSize }, { "swdh_get_registration_cannot_host_url", crash_keys::kLargeSize },
{ "swdh_get_registration_cannot_document_url", crash_keys::kLargeSize }, { "swdh_get_registration_cannot_document_url", crash_keys::kLargeSize },
// Temporary for https://crbug.com/647068.
{ "received_quit_message", crash_keys::kSmallSize },
}; };
return base::debug::InitCrashKeys(engine_keys, arraysize(engine_keys), return base::debug::InitCrashKeys(engine_keys, arraysize(engine_keys),
......
...@@ -179,9 +179,6 @@ size_t RegisterCrashKeysHelper() { ...@@ -179,9 +179,6 @@ size_t RegisterCrashKeysHelper() {
// Temporary for https://crbug.com/630496. // Temporary for https://crbug.com/630496.
{"swdh_get_registration_cannot_host_url", crash_keys::kLargeSize}, {"swdh_get_registration_cannot_host_url", crash_keys::kLargeSize},
{"swdh_get_registration_cannot_document_url", crash_keys::kLargeSize}, {"swdh_get_registration_cannot_document_url", crash_keys::kLargeSize},
// Temporary for https://crbug.com/647068.
{"received_quit_message", crash_keys::kSmallSize},
}; };
// This dynamic set of keys is used for sets of key value pairs when gathering // This dynamic set of keys is used for sets of key value pairs when gathering
......
...@@ -228,9 +228,6 @@ size_t RegisterChromeCrashKeys() { ...@@ -228,9 +228,6 @@ size_t RegisterChromeCrashKeys() {
// Temporary for https://crbug.com/630496. // Temporary for https://crbug.com/630496.
{ "swdh_get_registration_cannot_host_url", crash_keys::kLargeSize }, { "swdh_get_registration_cannot_host_url", crash_keys::kLargeSize },
{ "swdh_get_registration_cannot_document_url", crash_keys::kLargeSize }, { "swdh_get_registration_cannot_document_url", crash_keys::kLargeSize },
// Temporary for https://crbug.com/647068.
{ "received_quit_message", crash_keys::kSmallSize },
}; };
// This dynamic set of keys is used for sets of key value pairs when gathering // This dynamic set of keys is used for sets of key value pairs when gathering
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment