Mark expected output as constexpr in SHA1Test.

Change-Id: If523c4b07a1f19a47ccdd3b241b7ff2db6c8cfec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828079Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700475}

base/hash/sha1_unittest.cc

@@ -14,12 +14,13 @@ TEST(SHA1Test, Test1) {
   // Example A.1 from FIPS 180-2: one-block message.
   std::string input = "abc";
 
-  int expected[] = {0xa9, 0x99, 0x3e, 0x36, 0x47, 0x06, 0x81, 0x6a, 0xba, 0x3e,
-                    0x25, 0x71, 0x78, 0x50, 0xc2, 0x6c, 0x9c, 0xd0, 0xd8, 0x9d};
+  static constexpr int kExpected[] = {0xa9, 0x99, 0x3e, 0x36, 0x47, 0x06, 0x81,
+                                      0x6a, 0xba, 0x3e, 0x25, 0x71, 0x78, 0x50,
+                                      0xc2, 0x6c, 0x9c, 0xd0, 0xd8, 0x9d};
 
   std::string output = base::SHA1HashString(input);
   for (size_t i = 0; i < base::kSHA1Length; i++)
-    EXPECT_EQ(expected[i], output[i] & 0xFF);
+    EXPECT_EQ(kExpected[i], output[i] & 0xFF);
 }
 
 TEST(SHA1Test, Test2) {
@@ -27,24 +28,26 @@ TEST(SHA1Test, Test2) {
   std::string input =
       "abcdbcdecdefdefgefghfghighijhijkijkljklmklmnlmnomnopnopq";
 
-  int expected[] = {0x84, 0x98, 0x3e, 0x44, 0x1c, 0x3b, 0xd2, 0x6e, 0xba, 0xae,
-                    0x4a, 0xa1, 0xf9, 0x51, 0x29, 0xe5, 0xe5, 0x46, 0x70, 0xf1};
+  static constexpr int kExpected[] = {0x84, 0x98, 0x3e, 0x44, 0x1c, 0x3b, 0xd2,
+                                      0x6e, 0xba, 0xae, 0x4a, 0xa1, 0xf9, 0x51,
+                                      0x29, 0xe5, 0xe5, 0x46, 0x70, 0xf1};
 
   std::string output = base::SHA1HashString(input);
   for (size_t i = 0; i < base::kSHA1Length; i++)
-    EXPECT_EQ(expected[i], output[i] & 0xFF);
+    EXPECT_EQ(kExpected[i], output[i] & 0xFF);
 }
 
 TEST(SHA1Test, Test3) {
   // Example A.3 from FIPS 180-2: long message.
   std::string input(1000000, 'a');
 
-  int expected[] = {0x34, 0xaa, 0x97, 0x3c, 0xd4, 0xc4, 0xda, 0xa4, 0xf6, 0x1e,
-                    0xeb, 0x2b, 0xdb, 0xad, 0x27, 0x31, 0x65, 0x34, 0x01, 0x6f};
+  static constexpr int kExpected[] = {0x34, 0xaa, 0x97, 0x3c, 0xd4, 0xc4, 0xda,
+                                      0xa4, 0xf6, 0x1e, 0xeb, 0x2b, 0xdb, 0xad,
+                                      0x27, 0x31, 0x65, 0x34, 0x01, 0x6f};
 
   std::string output = base::SHA1HashString(input);
   for (size_t i = 0; i < base::kSHA1Length; i++)
-    EXPECT_EQ(expected[i], output[i] & 0xFF);
+    EXPECT_EQ(kExpected[i], output[i] & 0xFF);
 }
 
 TEST(SHA1Test, Test1Bytes) {
@@ -52,14 +55,14 @@ TEST(SHA1Test, Test1Bytes) {
   std::string input = "abc";
   unsigned char output[base::kSHA1Length];
 
-  unsigned char expected[] = {0xa9, 0x99, 0x3e, 0x36, 0x47, 0x06, 0x81,
-                              0x6a, 0xba, 0x3e, 0x25, 0x71, 0x78, 0x50,
-                              0xc2, 0x6c, 0x9c, 0xd0, 0xd8, 0x9d};
+  static constexpr unsigned char kExpected[] = {
+      0xa9, 0x99, 0x3e, 0x36, 0x47, 0x06, 0x81, 0x6a, 0xba, 0x3e,
+      0x25, 0x71, 0x78, 0x50, 0xc2, 0x6c, 0x9c, 0xd0, 0xd8, 0x9d};
 
   base::SHA1HashBytes(reinterpret_cast<const unsigned char*>(input.c_str()),
                       input.length(), output);
   for (size_t i = 0; i < base::kSHA1Length; i++)
-    EXPECT_EQ(expected[i], output[i]);
+    EXPECT_EQ(kExpected[i], output[i]);
 }
 
 TEST(SHA1Test, Test2Bytes) {
@@ -68,14 +71,14 @@ TEST(SHA1Test, Test2Bytes) {
       "abcdbcdecdefdefgefghfghighijhijkijkljklmklmnlmnomnopnopq";
   unsigned char output[base::kSHA1Length];
 
-  unsigned char expected[] = {0x84, 0x98, 0x3e, 0x44, 0x1c, 0x3b, 0xd2,
-                              0x6e, 0xba, 0xae, 0x4a, 0xa1, 0xf9, 0x51,
-                              0x29, 0xe5, 0xe5, 0x46, 0x70, 0xf1};
+  static constexpr unsigned char kExpected[] = {
+      0x84, 0x98, 0x3e, 0x44, 0x1c, 0x3b, 0xd2, 0x6e, 0xba, 0xae,
+      0x4a, 0xa1, 0xf9, 0x51, 0x29, 0xe5, 0xe5, 0x46, 0x70, 0xf1};
 
   base::SHA1HashBytes(reinterpret_cast<const unsigned char*>(input.c_str()),
                       input.length(), output);
   for (size_t i = 0; i < base::kSHA1Length; i++)
-    EXPECT_EQ(expected[i], output[i]);
+    EXPECT_EQ(kExpected[i], output[i]);
 }
 
 TEST(SHA1Test, Test3Bytes) {
@@ -83,12 +86,12 @@ TEST(SHA1Test, Test3Bytes) {
   std::string input(1000000, 'a');
   unsigned char output[base::kSHA1Length];
 
-  unsigned char expected[] = {0x34, 0xaa, 0x97, 0x3c, 0xd4, 0xc4, 0xda,
-                              0xa4, 0xf6, 0x1e, 0xeb, 0x2b, 0xdb, 0xad,
-                              0x27, 0x31, 0x65, 0x34, 0x01, 0x6f};
+  static constexpr unsigned char kExpected[] = {
+      0x34, 0xaa, 0x97, 0x3c, 0xd4, 0xc4, 0xda, 0xa4, 0xf6, 0x1e,
+      0xeb, 0x2b, 0xdb, 0xad, 0x27, 0x31, 0x65, 0x34, 0x01, 0x6f};
 
   base::SHA1HashBytes(reinterpret_cast<const unsigned char*>(input.c_str()),
                       input.length(), output);
   for (size_t i = 0; i < base::kSHA1Length; i++)
-    EXPECT_EQ(expected[i], output[i]);
+    EXPECT_EQ(kExpected[i], output[i]);
 }