Commit e9780e62 authored by Eric Lawrence's avatar Eric Lawrence Committed by Commit Bot

Ensure SecurityInfoForRequest sets cert_missing_subject_alt_name

Previously, SecurityInfoForRequest updated cert_missing_subject_alt_name
only if a certificate was present. It should instead set the field to
false if a certificate is not present.

Bug: 733308
Change-Id: Ieff93a1b6c243d2019c23fb1484d727211eeab20
Reviewed-on: https://chromium-review.googlesource.com/576114Reviewed-by: default avatarAdrienne Porter Felt <felt@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488441}
parent 5275eb16
......@@ -248,11 +248,9 @@ void SecurityInfoForRequest(
visible_security_state.displayed_password_field_on_http;
security_info->displayed_credit_card_field_on_http =
visible_security_state.displayed_credit_card_field_on_http;
if (visible_security_state.certificate) {
security_info->cert_missing_subject_alt_name =
!visible_security_state.certificate->GetSubjectAltName(nullptr,
nullptr);
}
security_info->cert_missing_subject_alt_name =
visible_security_state.certificate &&
!visible_security_state.certificate->GetSubjectAltName(nullptr, nullptr);
security_info->contained_mixed_form =
visible_security_state.contained_mixed_form;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment