Commit eacb9456 authored by Yuwei Huang's avatar Yuwei Huang Committed by Chromium LUCI CQ

[remoting host][mac] Add microphone usage description

When AudioCapturerMac starts the audio queue, macOS would not show the
prompt asking for microphone permission for the host unless
NSMicrophoneUsageDescription is set on Info.Plist. Without it
AudioCapturerMac capatures nothing but silence. This CL sets the missing
key.

Bug: 1161363
Change-Id: I5e0a57a42b8276439a68cf0647199094ff7c8eec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628890
Auto-Submit: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: default avatarJoe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843548}
parent 090c2e04
NSHumanReadableCopyright = "{% trans %}COPYRIGHT{% endtrans %}"; NSHumanReadableCopyright = "{% trans %}COPYRIGHT{% endtrans %}";
NSMicrophoneUsageDescription = "{% trans %}MAC_MICROPHONE_USAGE{% endtrans %}";
...@@ -328,6 +328,9 @@ ...@@ -328,6 +328,9 @@
<message name="IDS_MAC_UNINSTALLER_BUNDLE_NAME" desc="The bundle name specified in the property list of Chrome Remote Desktop Host Uninstaller bundle on MacOS. The Chrome Remote Desktop host allows a user to connect to their computer remotely (it 'hosts' a connection from a remote computer)."> <message name="IDS_MAC_UNINSTALLER_BUNDLE_NAME" desc="The bundle name specified in the property list of Chrome Remote Desktop Host Uninstaller bundle on MacOS. The Chrome Remote Desktop host allows a user to connect to their computer remotely (it 'hosts' a connection from a remote computer).">
Chrome Remote Desktop Host Uninstaller Chrome Remote Desktop Host Uninstaller
</message> </message>
<message name="IDS_MAC_MICROPHONE_USAGE" desc="The description explaining how the Chrome Remote Desktop host requests for microphone access.">
Microphone access is required to capture audio and stream it to the Chrome Remote Desktop client.
</message>
</if> <!-- _google_chrome --> </if> <!-- _google_chrome -->
<if expr="not _google_chrome"> <if expr="not _google_chrome">
...@@ -367,6 +370,9 @@ ...@@ -367,6 +370,9 @@
<message name="IDS_MAC_UNINSTALLER_BUNDLE_NAME" desc="The bundle name specified in the property list of Chromoting Host Uninstaller bundle on MacOS."> <message name="IDS_MAC_UNINSTALLER_BUNDLE_NAME" desc="The bundle name specified in the property list of Chromoting Host Uninstaller bundle on MacOS.">
Chromoting Host Uninstaller Chromoting Host Uninstaller
</message> </message>
<message name="IDS_MAC_MICROPHONE_USAGE" desc="The description explaining how the Chrome Remote Desktop host uses microphone.">
Microphone access is required to capture audio and stream it to the Chrome Remote Desktop client.
</message>
</if> <!-- not _google_chrome --> </if> <!-- not _google_chrome -->
<message desc="Error that is shown on the client side when incompatible Chrome Remote Desktop versions are installed on host and client." name="IDS_ERROR_INCOMPATIBLE_PROTOCOL" formatter_data="android_java"> <message desc="Error that is shown on the client side when incompatible Chrome Remote Desktop versions are installed on host and client." name="IDS_ERROR_INCOMPATIBLE_PROTOCOL" formatter_data="android_java">
......
d765611bf772bcfe5f6d4b4475c3f119f52ef5db
\ No newline at end of file
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment