Commit eadadd67 authored by Jun Kokatsu's avatar Jun Kokatsu Committed by Commit Bot

Remove innerHTML usage in chrome://signin-internals

This change removes innerHTML usage by changing it to textContent.
This make the page compatible with Trusted Types.

Bug: 1125965
Change-Id: I0f01d25ef3e001be1c1aa6d056b0a5b72da99592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399821
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: default avatarDavid Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805229}
parent e5a86652
...@@ -526,7 +526,7 @@ AboutSigninInternals::TokenInfo::ToValue() const { ...@@ -526,7 +526,7 @@ AboutSigninInternals::TokenInfo::ToValue() const {
std::string scopes_str; std::string scopes_str;
for (auto it = scopes.begin(); it != scopes.end(); ++it) { for (auto it = scopes.begin(); it != scopes.end(); ++it) {
scopes_str += *it + "<br/>"; scopes_str += *it + "\n";
} }
token_info->SetString("scopes", scopes_str); token_info->SetString("scopes", scopes_str);
token_info->SetString("request_time", base::TimeToISO8601(request_time)); token_info->SetString("request_time", base::TimeToISO8601(request_time));
......
...@@ -36,6 +36,7 @@ div#cookie-info { ...@@ -36,6 +36,7 @@ div#cookie-info {
} }
table.signin-details { table.signin-details {
white-space: pre;
width: 100%; width: 100%;
} }
......
...@@ -48,9 +48,9 @@ ...@@ -48,9 +48,9 @@
[this.children[2].innerText, request_time], [this.children[2].innerText, request_time],
[this.children[3].innerText, status]])"> [this.children[3].innerText, status]])">
<td jscontent="service"></td> <td jscontent="service"></td>
<td jsvalues=".innerHTML: scopes"></td> <td jsvalues=".textContent: scopes"></td>
<td jscontent="request_time"></td> <td jscontent="request_time"></td>
<td jsvalues=".innerHTML: status"></td> <td jsvalues=".textContent: status"></td>
</tr> </tr>
</table> </table>
</div> </div>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment