Commit eb672074 authored by ssid's avatar ssid Committed by Commit Bot

Fix upload limit check for background tracing

Add missing enum value for background tracing state. Enum changed in:
https://chromium-review.googlesource.com/c/chromium/src/+/1659607

Change-Id: Ife1a821a9e1e9f0ac631970c768dba42c3e15c52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714329
Commit-Queue: ssid <ssid@chromium.org>
Reviewed-by: default avataroysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680237}
parent 81604e9f
......@@ -62,7 +62,7 @@ constexpr size_t kUploadLimitOnWifiKb = 5 * 1024; // ~1MB compressed size.
constexpr size_t kUploadLimitKb = 30 * 1024; // Less than 10MB compressed size.
#endif
bool IsTraceLogUploadAllowed(size_t trace_size_kb) {
size_t TraceLogUploadLimitKb() {
#if defined(OS_ANDROID)
auto connection_type = net::NetworkChangeNotifier::GetConnectionType();
if (connection_type != net::NetworkChangeNotifier::CONNECTION_WIFI &&
......@@ -235,7 +235,7 @@ bool BackgroundTracingManagerImpl::HasTraceToUpload() {
if (trace_to_upload_.empty()) {
return false;
}
if (!IsTraceLogUploadAllowed(trace_to_upload_.size())) {
if (trace_to_upload_.size() > TraceLogUploadLimitKb() * 1024) {
RecordMetric(Metrics::LARGE_UPLOAD_WAITING_TO_RETRY);
return false;
}
......
......@@ -4593,6 +4593,7 @@ Unknown properties are collapsed to zero. -->
<int value="10" label="Trace upload failed"/>
<int value="11" label="Trace upload succeeded"/>
<int value="12" label="Startup scenario triggered"/>
<int value="13" label="Large upload waiting to retry"/>
</enum>
<enum name="BackingStoreResults">
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment