Commit eb7b4aac authored by kkimlabs@chromium.org's avatar kkimlabs@chromium.org

Add MobileUsingMenuBy* metric actions owner and remove an unused one.

BUG=401821

Review URL: https://codereview.chromium.org/455543003

Cr-Commit-Position: refs/heads/master@{#288434}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288434 0039d316-1c4b-4281-b951-d872f2087c98
parent 433c2212
......@@ -23,7 +23,7 @@ static void RecordUsingMenu(JNIEnv*,
jboolean is_dragging) {
if (is_by_hw_button) {
if (is_dragging) {
RecordAction(UserMetricsAction("MobileUsingMenuByHwButtonDragging"));
NOTREACHED() << "We do not support dragging for hardware menu button.";
} else {
RecordAction(UserMetricsAction("MobileUsingMenuByHwButtonTap"));
}
......
......@@ -7539,23 +7539,34 @@ should be able to be added at any place in this file.
</action>
<action name="MobileUsingMenuByHwButtonDragging">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<description>Please enter the description of this user action.</description>
<owner>kkimlabs@chromium.org</owner>
<description>
Only for Android. Menu is shown by dragging from hardware menu button.
</description>
<obsolete>
Deprecated as of 06/2014. We removed this feature http://crbug.com/366154 .
</obsolete>
</action>
<action name="MobileUsingMenuByHwButtonTap">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<description>Please enter the description of this user action.</description>
<owner>kkimlabs@chromium.org</owner>
<description>
Only for Android. Menu is shown by tapping hardware menu button.
</description>
</action>
<action name="MobileUsingMenuBySwButtonDragging">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<description>Please enter the description of this user action.</description>
<owner>kkimlabs@chromium.org</owner>
<description>
Only for Android. Menu is shown by dragging from software menu button.
</description>
</action>
<action name="MobileUsingMenuBySwButtonTap">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<description>Please enter the description of this user action.</description>
<owner>kkimlabs@chromium.org</owner>
<description>
Only for Android. Menu is shown by tapping software menu button.
</description>
</action>
<action name="MostVisited0">
......
......@@ -310,7 +310,6 @@ def AddAndroidActions(actions):
actions.add('MobileToolbarShowStackView')
actions.add('MobileToolbarStackViewNewTab')
actions.add('MobileToolbarToggleBookmark')
actions.add('MobileUsingMenuByHwButtonDragging')
actions.add('MobileUsingMenuByHwButtonTap')
actions.add('MobileUsingMenuBySwButtonDragging')
actions.add('MobileUsingMenuBySwButtonTap')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment