Commit ebd0dc7a authored by Nick Burris's avatar Nick Burris Committed by Commit Bot

Remove TODO in PaymentAppProviderImpl

This TODO was added to address cases where the web contents is destroyed
before explicitly closing the window. However, enforcing this would
violate encapsulation, e.g. the Java bottomsheet code shouldn't need
to worry about this nuance. See comment 20 on the bug for more detail.

Bug: 1099270
Change-Id: I66cc6fcbeefbdf16a9c9c6a1aa598ce0eb3f1b59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521779Reviewed-by: default avatarLiquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824921}
parent 024da4c4
......@@ -317,9 +317,6 @@ void PaymentAppProviderImpl::SetOpenedWindow(
void PaymentAppProviderImpl::CloseOpenedWindow() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
// TODO(crbug.com/1099270): Fix cases where the web contents has already been
// destroyed without calling this function, e.g. when the bottom sheet UI is
// closed.
if (payment_handler_window_ && payment_handler_window_->web_contents()) {
payment_handler_window_->web_contents()->Close();
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment