Commit ec3ef8fa authored by Jérôme Lebel's avatar Jérôme Lebel Committed by Commit Bot

[iOS] Don't show encryption error when sync is disabled

Don't show encryption error when sync is disabled.

Bug: 914059
Change-Id: I719bf76ea87d670c8deda34532ed185a4d4d4685
Reviewed-on: https://chromium-review.googlesource.com/c/1487814Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635472}
parent 61d7bcf2
...@@ -311,7 +311,7 @@ NSString* kGoogleServicesSyncErrorImage = @"google_services_sync_error"; ...@@ -311,7 +311,7 @@ NSString* kGoogleServicesSyncErrorImage = @"google_services_sync_error";
BOOL hasError = NO; BOOL hasError = NO;
ItemType type; ItemType type;
if (self.isAuthenticated) { if (self.isAuthenticated && self.syncSetupService->IsSyncEnabled()) {
switch (self.syncSetupService->GetSyncServiceState()) { switch (self.syncSetupService->GetSyncServiceState()) {
case SyncSetupService::kSyncServiceUnrecoverableError: case SyncSetupService::kSyncServiceUnrecoverableError:
type = RestartAuthenticationFlowErrorItemType; type = RestartAuthenticationFlowErrorItemType;
......
...@@ -223,7 +223,8 @@ NSString* kGoogleServicesSyncErrorImage = @"google_services_sync_error"; ...@@ -223,7 +223,8 @@ NSString* kGoogleServicesSyncErrorImage = @"google_services_sync_error";
BOOL needsUpdate = BOOL needsUpdate =
self.shouldEncryptionItemBeEnabled && self.shouldEncryptionItemBeEnabled &&
(self.encryptionItem.enabled != self.shouldEncryptionItemBeEnabled); (self.encryptionItem.enabled != self.shouldEncryptionItemBeEnabled);
if (self.syncSetupService->GetSyncServiceState() == if (self.shouldEncryptionItemBeEnabled &&
self.syncSetupService->GetSyncServiceState() ==
SyncSetupService::kSyncServiceNeedsPassphrase) { SyncSetupService::kSyncServiceNeedsPassphrase) {
needsUpdate = needsUpdate || self.encryptionItem.image == nil; needsUpdate = needsUpdate || self.encryptionItem.image == nil;
self.encryptionItem.image = self.encryptionItem.image =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment